ReVanced/jadb
1
0
Fork 0
mirror of https://github.com/revanced/jadb.git synced 2025-05-29 13:00:11 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix: Try-with-resources should be used (squid:S2093)

Browse Source
This commit is contained in:
Jano Svitok 2018-07-30 14:00:27 +02:00
parent 9cd5f509ae
commit b9a86b85fa
1 changed files with 3 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/se/vidstige/jadb/managers/PackageManager.java
View File

@ -22,10 +22,8 @@ public class PackageManager {
} }
public List<Package> getPackages() throws IOException, JadbException { public List<Package> getPackages() throws IOException, JadbException {
ArrayList<Package> result = new ArrayList<>(); try (BufferedReader input = new BufferedReader(new InputStreamReader(device.executeShell("pm", "list", "packages"), StandardCharsets.UTF_8))) {
BufferedReader input = null; ArrayList<Package> result = new ArrayList<>();
try {
input = new BufferedReader(new InputStreamReader(device.executeShell("pm", "list", "packages"), StandardCharsets.UTF_8));
String line; String line;
while ((line = input.readLine()) != null) { while ((line = input.readLine()) != null) {
final String prefix = "package:"; final String prefix = "package:";
@ -33,10 +31,8 @@ public class PackageManager {
result.add(new Package(line.substring(prefix.length()))); result.add(new Package(line.substring(prefix.length())));
} }
} }
} finally { return result;
if (input != null) input.close();
} }
return result;
} }
private String getErrorMessage(String operation, String target, String errorMessage) { private String getErrorMessage(String operation, String target, String errorMessage) {