From b9a86b85fa470da8d58b553a133718034f8b3e73 Mon Sep 17 00:00:00 2001
From: Jano Svitok <jan.svitok@gmail.com>
Date: Mon, 30 Jul 2018 14:00:27 +0200
Subject: [PATCH] Fix: Try-with-resources should be used (squid:S2093)

---
 src/se/vidstige/jadb/managers/PackageManager.java | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/src/se/vidstige/jadb/managers/PackageManager.java b/src/se/vidstige/jadb/managers/PackageManager.java
index 5d7ed02..40d0fde 100644
--- a/src/se/vidstige/jadb/managers/PackageManager.java
+++ b/src/se/vidstige/jadb/managers/PackageManager.java
@@ -22,10 +22,8 @@ public class PackageManager {
     }
 
     public List<Package> getPackages() throws IOException, JadbException {
-        ArrayList<Package> result = new ArrayList<>();
-        BufferedReader input = null;
-        try {
-            input = new BufferedReader(new InputStreamReader(device.executeShell("pm", "list", "packages"), StandardCharsets.UTF_8));
+        try (BufferedReader input = new BufferedReader(new InputStreamReader(device.executeShell("pm", "list", "packages"), StandardCharsets.UTF_8))) {
+            ArrayList<Package> result = new ArrayList<>();
             String line;
             while ((line = input.readLine()) != null) {
                 final String prefix = "package:";
@@ -33,10 +31,8 @@ public class PackageManager {
                     result.add(new Package(line.substring(prefix.length())));
                 }
             }
-        } finally {
-            if (input != null) input.close();
+            return result;
         }
-        return result;
     }
 
     private String getErrorMessage(String operation, String target, String errorMessage) {