Mirrors/PrismLauncher
1
0
Fork 0
mirror of https://github.com/PrismLauncher/PrismLauncher.git synced 2025-06-12 21:27:44 +02:00
Code Issues Packages Projects Releases Wiki Activity

Use null QString instead of empty

Browse Source 
Signed-off-by: Yihe Li <winmikedows@hotmail.com>
This commit is contained in:
Yihe Li
2025-06-01 18:31:27 +08:00
parent d9884f0d03
commit caff4b884f
2 changed files with 13 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
launcher/FileSystem.cpp
View File

@ -905,19 +905,19 @@ QString createShortcut(QString destination, QString target, QStringList args, QS
}
if (!ensureFilePathExists(destination)) {
qWarning() << "Destination path can't be created!";
return "";
return QString();
}
#if defined(Q_OS_MACOS)
QDir application = destination + ".app/";
if (application.exists()) {
qWarning() << "Application already exists!";
return "";
return QString();
}
if (!application.mkpath(".")) {
qWarning() << "Couldn't create application";
return "";
return QString();
}
QDir content = application.path() + "/Contents/";
@ -927,7 +927,7 @@ QString createShortcut(QString destination, QString target, QStringList args, QS
if (!(content.mkpath(".") && resources.mkpath(".") && binaryDir.mkpath("."))) {
qWarning() << "Couldn't create directories within application";
return "";
return QString();
}
info.open(QIODevice::WriteOnly | QIODevice::Text);
@ -1008,26 +1008,26 @@ QString createShortcut(QString destination, QString target, QStringList args, QS
if (!targetInfo.exists()) {
qWarning() << "Target file does not exist!";
return "";
return QString();
}
target = targetInfo.absoluteFilePath();
if (target.length() >= MAX_PATH) {
qWarning() << "Target file path is too long!";
return "";
return QString();
}
if (!icon.isEmpty() && icon.length() >= MAX_PATH) {
qWarning() << "Icon path is too long!";
return "";
return QString();
}
destination += ".lnk";
if (destination.length() >= MAX_PATH) {
qWarning() << "Destination path is too long!";
return "";
return QString();
}
QString argStr;
@ -1046,7 +1046,7 @@ QString createShortcut(QString destination, QString target, QStringList args, QS
if (argStr.length() >= MAX_PATH) {
qWarning() << "Arguments string is too long!";
return "";
return QString();
}
HRESULT hres;
@ -1055,7 +1055,7 @@ QString createShortcut(QString destination, QString target, QStringList args, QS
hres = CoInitialize(nullptr);
if (FAILED(hres)) {
qWarning() << "Failed to initialize COM!";
return "";
return QString();
}
WCHAR wsz[MAX_PATH];
@ -1111,10 +1111,10 @@ QString createShortcut(QString destination, QString target, QStringList args, QS
if (SUCCEEDED(hres))
return destination;
return "";
return QString();
#else
qWarning("Desktop Shortcuts not supported on your platform!");
return "";
return QString();
#endif
}

2
launcher/FileSystem.h
View File

@ -362,7 +362,7 @@ bool overrideFolder(QString overwritten_path, QString override_path);
/**
* Creates a shortcut to the specified target file at the specified destination path.
* Returns empty string if creation failed; otherwise returns the path to the created shortcut.
* Returns null QString if creation failed; otherwise returns the path to the created shortcut.
*/
QString createShortcut(QString destination, QString target, QStringList args, QString name, QString icon);