From 63e0d63d4ac83d2f1b58d0856b21264e90298666 Mon Sep 17 00:00:00 2001
From: madkarmaa <madkarma99@gmail.com>
Date: Tue, 8 Apr 2025 09:19:42 +0200
Subject: [PATCH] refactor: use conditional types

---
 src/lib/components/atoms/Button.svelte | 25 ++++++++++++++++++++-----
 src/lib/types.d.ts                     |  4 ++++
 2 files changed, 24 insertions(+), 5 deletions(-)

diff --git a/src/lib/components/atoms/Button.svelte b/src/lib/components/atoms/Button.svelte
index baf6257..d666850 100644
--- a/src/lib/components/atoms/Button.svelte
+++ b/src/lib/components/atoms/Button.svelte
@@ -1,21 +1,36 @@
 <script lang="ts">
 	import type { Component, Snippet } from 'svelte';
-	import type { SpecialTargetValues } from '$types';
+	import type { SpecialTargetValues, Prettify } from '$types';
 
 	type ButtonType = 'filled' | 'tonal' | 'text' | 'outlined';
 
-	type Props = {
+	type BaseProps = {
 		type: ButtonType;
 		icon?: Component;
 		iconSize?: number;
 		iconColor?: string;
-		href?: string;
-		target?: `${SpecialTargetValues}` | SpecialTargetValues;
 		label?: string;
 		children?: Snippet;
-		onclick?: () => void;
 	};
 
+	type ButtonProps = Prettify<
+		BaseProps & {
+			onclick: () => void;
+			href: never;
+			target: never;
+		}
+	>;
+
+	type LinkProps = Prettify<
+		BaseProps & {
+			href: string;
+			target?: `${SpecialTargetValues}` | SpecialTargetValues;
+			onclick: never;
+		}
+	>;
+
+	type Props = ButtonProps | LinkProps;
+
 	let {
 		type,
 		// https://svelte.dev/docs/svelte/compiler-warnings#svelte_component_deprecated
diff --git a/src/lib/types.d.ts b/src/lib/types.d.ts
index 7ac0324..c43dd16 100644
--- a/src/lib/types.d.ts
+++ b/src/lib/types.d.ts
@@ -7,3 +7,7 @@ export enum SpecialTargetValues {
 	PARENT = '_parent',
 	TOP = '_top'
 }
+
+type Prettify<T> = {
+	[K in keyof T]: T[K];
+} & {};