From 25fed14a0a332948dde4329b0237f9f89d8b9753 Mon Sep 17 00:00:00 2001 From: oSumAtrIX Date: Wed, 21 Jun 2023 02:27:21 +0200 Subject: [PATCH 01/10] fix: only collect analytics when consent given --- src/app.html | 11 ++++- src/routes/+layout.svelte | 92 ++++++++++++--------------------------- 2 files changed, 37 insertions(+), 66 deletions(-) diff --git a/src/app.html b/src/app.html index 584000e..4393f4f 100644 --- a/src/app.html +++ b/src/app.html @@ -3,14 +3,21 @@ - + %sveltekit.head%
%sveltekit.body%
+ + diff --git a/src/routes/+layout.svelte b/src/routes/+layout.svelte index 449faaa..bac2dbf 100644 --- a/src/routes/+layout.svelte +++ b/src/routes/+layout.svelte @@ -2,7 +2,6 @@ import { writable } from 'svelte/store'; // There might be a better place to put this, but I am not entirely sure... export const isRestoring = writable(false); - declare const telemetryInit: () => void; - + - - - - - + It's your choice - This site uses analytics to understand better how you use it. Opting in is - optional and won't impact your experience. + We use analytics to improve your experience on this site. By clicking "Accept" you allow us to + collect anonymous data about your visit. - - + + @@ -145,6 +110,5 @@ {:else} {/if} - From 9900635879f1dda7f7131c88ee529685dc57acf7 Mon Sep 17 00:00:00 2001 From: oSumAtrIX Date: Wed, 21 Jun 2023 03:13:01 +0200 Subject: [PATCH 02/10] fix: use wider modal gaps --- src/lib/components/Dialogue.svelte | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/lib/components/Dialogue.svelte b/src/lib/components/Dialogue.svelte index c8da0ac..8799867 100644 --- a/src/lib/components/Dialogue.svelte +++ b/src/lib/components/Dialogue.svelte @@ -47,9 +47,9 @@ {/if} {#if $$slots.title} -

+

-

+ {/if} @@ -85,7 +85,7 @@ display: flex; flex-direction: column; align-items: center; - margin-bottom: 0.75rem; + gap: 1rem; } .title { @@ -94,13 +94,11 @@ gap: 1rem; width: 100%; background-color: var(--grey-six); - margin-bottom: 8px; } .buttons { display: flex; gap: 2rem; - margin-top: 1rem; justify-content: flex-end; width: 100%; } From 75df0b77bfd69495d8458dd4fe2637b0ce0d1088 Mon Sep 17 00:00:00 2001 From: oSumAtrIX Date: Wed, 21 Jun 2023 03:13:30 +0200 Subject: [PATCH 03/10] feat: make consent more suggestive --- src/routes/+layout.svelte | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/routes/+layout.svelte b/src/routes/+layout.svelte index bac2dbf..12a6393 100644 --- a/src/routes/+layout.svelte +++ b/src/routes/+layout.svelte @@ -96,12 +96,12 @@ It's your choice - We use analytics to improve your experience on this site. By clicking "Accept" you allow us to + We use analytics to improve your experience on this site. By clicking "Allow", you allow us to collect anonymous data about your visit. - + From f0e1eb42f07a75f6b9ce2505e4cbb327d2ad1161 Mon Sep 17 00:00:00 2001 From: oSumAtrIX Date: Wed, 21 Jun 2023 03:21:06 +0200 Subject: [PATCH 04/10] feat: remove wavy text decoration (#121) --- src/layout/Footer/FooterHost.svelte | 4 +--- src/routes/contributors/+page.svelte | 4 +--- src/routes/contributors/ContributorPerson.svelte | 4 +--- src/routes/contributors/ContributorSection.svelte | 4 +--- src/routes/patches/PatchItem.svelte | 4 +--- 5 files changed, 5 insertions(+), 15 deletions(-) diff --git a/src/layout/Footer/FooterHost.svelte b/src/layout/Footer/FooterHost.svelte index b9db0d4..9e60cd2 100644 --- a/src/layout/Footer/FooterHost.svelte +++ b/src/layout/Footer/FooterHost.svelte @@ -155,9 +155,7 @@ } a:hover { - text-decoration: underline; - text-decoration-style: wavy; - text-decoration-color: var(--accent-color-two); + text-decoration: underline var(--accent-color-two); color: var(--white); } diff --git a/src/routes/contributors/+page.svelte b/src/routes/contributors/+page.svelte index 3926970..4ba6603 100644 --- a/src/routes/contributors/+page.svelte +++ b/src/routes/contributors/+page.svelte @@ -83,9 +83,7 @@ } a:hover { - text-decoration: underline; - text-decoration-style: wavy; - text-decoration-color: var(--grey-four); + text-decoration: underline var(--grey-four); } a:hover::after { diff --git a/src/routes/contributors/ContributorPerson.svelte b/src/routes/contributors/ContributorPerson.svelte index 5da40d4..ac17411 100644 --- a/src/routes/contributors/ContributorPerson.svelte +++ b/src/routes/contributors/ContributorPerson.svelte @@ -26,9 +26,7 @@ } a:hover { - text-decoration: underline; - text-decoration-style: wavy; - text-decoration-color: var(--accent-color); + text-decoration: underline var(--accent-color); color: var(--white); } diff --git a/src/routes/contributors/ContributorSection.svelte b/src/routes/contributors/ContributorSection.svelte index fc35355..64edbea 100644 --- a/src/routes/contributors/ContributorSection.svelte +++ b/src/routes/contributors/ContributorSection.svelte @@ -79,9 +79,7 @@ } a:hover { - text-decoration: underline; - text-decoration-style: wavy; - text-decoration-color: var(--accent-color); + text-decoration: underline var(--accent-color); color: var(--white); } diff --git a/src/routes/patches/PatchItem.svelte b/src/routes/patches/PatchItem.svelte index 830dd07..195e42e 100644 --- a/src/routes/patches/PatchItem.svelte +++ b/src/routes/patches/PatchItem.svelte @@ -92,10 +92,8 @@ } a .patch-info:hover { - text-decoration: underline; + text-decoration: underline var(--accent-color-two); color: var(--accent-color-two); - text-decoration-style: wavy; - text-decoration-color: var(--accent-color-two); } .info-container { From 6b7fb1d5c0d340f2f45acc1986a612e10ebe320a Mon Sep 17 00:00:00 2001 From: Radu Bratan Date: Wed, 21 Jun 2023 04:22:41 +0300 Subject: [PATCH 05/10] fix: hide scrollbar in dialogue modals (#123) --- src/lib/components/Dialogue.svelte | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/lib/components/Dialogue.svelte b/src/lib/components/Dialogue.svelte index 8799867..23eaad8 100644 --- a/src/lib/components/Dialogue.svelte +++ b/src/lib/components/Dialogue.svelte @@ -132,6 +132,8 @@ padding: 32px; box-shadow: 0px 4px 5px 0px rgba(0, 0, 0, 0.14), 0px 1px 10px 0px rgba(0, 0, 0, 0.12), 0px 2px 4px -1px rgba(0, 0, 0, 0.2); + scrollbar-width: none; + -ms-overflow-style: none; } button { From ea2ee26aa38182bd1ae9eeca12d182d79efd786e Mon Sep 17 00:00:00 2001 From: oSumAtrIX Date: Wed, 21 Jun 2023 03:27:38 +0200 Subject: [PATCH 06/10] feat: add hover background color feedback to contributor persons --- src/routes/contributors/ContributorPerson.svelte | 1 + 1 file changed, 1 insertion(+) diff --git a/src/routes/contributors/ContributorPerson.svelte b/src/routes/contributors/ContributorPerson.svelte index ac17411..771c081 100644 --- a/src/routes/contributors/ContributorPerson.svelte +++ b/src/routes/contributors/ContributorPerson.svelte @@ -26,6 +26,7 @@ } a:hover { + background: var(--grey-one); text-decoration: underline var(--accent-color); color: var(--white); } From aec1bbee68ae13f8f89fcc62956dbb77941d5745 Mon Sep 17 00:00:00 2001 From: oSumAtrIX Date: Wed, 21 Jun 2023 03:33:18 +0200 Subject: [PATCH 07/10] fix: add missing padding to logo --- src/layout/Navbar/NavHost.svelte | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/layout/Navbar/NavHost.svelte b/src/layout/Navbar/NavHost.svelte index a26bba4..c67f252 100644 --- a/src/layout/Navbar/NavHost.svelte +++ b/src/layout/Navbar/NavHost.svelte @@ -134,6 +134,10 @@ From 8b7900d75cdfa551e22fc9fde912bfc019064795 Mon Sep 17 00:00:00 2001 From: oSumAtrIX Date: Wed, 21 Jun 2023 03:52:16 +0200 Subject: [PATCH 10/10] feat: improve visual feedback on patch containers --- src/routes/patches/PatchItem.svelte | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/src/routes/patches/PatchItem.svelte b/src/routes/patches/PatchItem.svelte index 195e42e..7dbff17 100644 --- a/src/routes/patches/PatchItem.svelte +++ b/src/routes/patches/PatchItem.svelte @@ -66,7 +66,7 @@ {/if} -