fix(TikTok - Feed filter): Hide ads in following feed (#4844)

extensions/tiktok/src/main/java/app/revanced/extension/tiktok/feedfilter/FeedItemsFilter.java

@@ -2,6 +2,7 @@ package app.revanced.extension.tiktok.feedfilter;
 
 import com.ss.android.ugc.aweme.feed.model.Aweme;
 import com.ss.android.ugc.aweme.feed.model.FeedItemList;
+import com.ss.android.ugc.aweme.follow.presenter.FollowFeedList;
 
 import java.util.Iterator;
 import java.util.List;
@@ -17,18 +18,36 @@ public final class FeedItemsFilter {
     );
 
     public static void filter(FeedItemList feedItemList) {
-        Iterator<Aweme> feedItemListIterator = feedItemList.items.iterator();
+        filterFeedList(feedItemList.items, item -> item);
-        while (feedItemListIterator.hasNext()) {
+    }
-            Aweme item = feedItemListIterator.next();
-            if (item == null) continue;
 
+    public static void filter(FollowFeedList followFeedList) {
+        filterFeedList(followFeedList.mItems, feed -> (feed != null) ? feed.aweme : null);
+    }
+
+    private static <T> void filterFeedList(List<T> list, AwemeExtractor<T> extractor) {
+        // Could be simplified with removeIf() but requires Android 7.0+ while TikTok supports 4.0+.
+        Iterator<T> iterator = list.iterator();
+        while (iterator.hasNext()) {
+            T container = iterator.next();
+            Aweme item = extractor.extract(container);
+            if (item != null && shouldFilter(item)) {
+                iterator.remove();
+            }
+        }
+    }
+
+    private static boolean shouldFilter(Aweme item) {
         for (IFilter filter : FILTERS) {
-                boolean enabled = filter.getEnabled();
+            if (filter.getEnabled() && filter.getFiltered(item)) {
-                if (enabled && filter.getFiltered(item)) {
+                return true;
-                    feedItemListIterator.remove();
-                    break;
-                }
             }
         }
+        return false;
+    }
+
+    @FunctionalInterface
+    interface AwemeExtractor<T> {
+        Aweme extract(T source);
     }
 }

extensions/tiktok/stub/src/main/java/com/ss/android/ugc/aweme/follow/presenter/FollowFeed.java

@@ -0,0 +1,8 @@
+package com.ss.android.ugc.aweme.follow.presenter;
+
+import com.ss.android.ugc.aweme.feed.model.Aweme;
+
+//Dummy class
+public class FollowFeed {
+    public Aweme aweme;
+}

extensions/tiktok/stub/src/main/java/com/ss/android/ugc/aweme/follow/presenter/FollowFeedList.java

@@ -0,0 +1,8 @@
+package com.ss.android.ugc.aweme.follow.presenter;
+
+import java.util.List;
+
+//Dummy class
+public class FollowFeedList {
+    public List<FollowFeed> mItems;
+}

patches/src/main/kotlin/app/revanced/patches/tiktok/feedfilter/FeedFilterPatch.kt

@@ -9,6 +9,8 @@ import app.revanced.patches.tiktok.misc.settings.settingsStatusLoadFingerprint
 import com.android.tools.smali.dexlib2.Opcode
 import com.android.tools.smali.dexlib2.iface.instruction.OneRegisterInstruction
 
+private const val EXTENSION_CLASS_DESCRIPTOR = "Lapp/revanced/extension/tiktok/feedfilter/FeedItemsFilter;"
+
 @Suppress("unused")
 val feedFilterPatch = bytecodePatch(
     name = "Feed filter",
@@ -26,14 +28,15 @@ val feedFilterPatch = bytecodePatch(
     )
 
     execute {
-        feedApiServiceLIZFingerprint.method.apply {
+        arrayOf(
-            val returnFeedItemInstruction = instructions.first { it.opcode == Opcode.RETURN_OBJECT }
+            feedApiServiceLIZFingerprint.method to "$EXTENSION_CLASS_DESCRIPTOR->filter(Lcom/ss/android/ugc/aweme/feed/model/FeedItemList;)V",
-            val feedItemsRegister = (returnFeedItemInstruction as OneRegisterInstruction).registerA
+            followFeedFingerprint.method to "$EXTENSION_CLASS_DESCRIPTOR->filter(Lcom/ss/android/ugc/aweme/follow/presenter/FollowFeedList;)V"
-
+        ).forEach { (method, filterSignature) ->
-            addInstruction(
+            val returnInstruction = method.instructions.first { it.opcode == Opcode.RETURN_OBJECT }
-                returnFeedItemInstruction.location.index,
+            val register = (returnInstruction as OneRegisterInstruction).registerA
-                "invoke-static { v$feedItemsRegister }, " +
+            method.addInstruction(
-                    "Lapp/revanced/extension/tiktok/feedfilter/FeedItemsFilter;->filter(Lcom/ss/android/ugc/aweme/feed/model/FeedItemList;)V",
+                returnInstruction.location.index,
+                "invoke-static { v$register }, $filterSignature"
             )
         }
 
@@ -42,4 +45,5 @@ val feedFilterPatch = bytecodePatch(
             "invoke-static {}, Lapp/revanced/extension/tiktok/settings/SettingsStatus;->enableFeedFilter()V",
         )
     }
+
 }

patches/src/main/kotlin/app/revanced/patches/tiktok/feedfilter/Fingerprints.kt

@@ -1,9 +1,22 @@
 package app.revanced.patches.tiktok.feedfilter
 
 import app.revanced.patcher.fingerprint
+import com.android.tools.smali.dexlib2.AccessFlags
+import com.android.tools.smali.dexlib2.Opcode
 
 internal val feedApiServiceLIZFingerprint = fingerprint {
     custom { method, classDef ->
         classDef.endsWith("/FeedApiService;") && method.name == "fetchFeedList"
     }
 }
+
+internal val followFeedFingerprint = fingerprint {
+    accessFlags(AccessFlags.PUBLIC, AccessFlags.STATIC)
+    returns("Lcom/ss/android/ugc/aweme/follow/presenter/FollowFeedList;")
+    strings("getFollowFeedList")
+    opcodes(
+        Opcode.INVOKE_INTERFACE_RANGE,
+        Opcode.MOVE_RESULT_OBJECT,
+        Opcode.INVOKE_INTERFACE
+    )
+}