From 506d2414bbc760e764e5a514b32926083d6ecb6b Mon Sep 17 00:00:00 2001 From: LisoUseInAIKyrios <118716522+LisoUseInAIKyrios@users.noreply.github.com> Date: Fri, 21 Feb 2025 14:09:01 +0200 Subject: [PATCH] feat(YouTube - Navigation buttons): Add 'Hide notifications' setting (#4485) --- .../app/revanced/extension/shared/spoof/ClientType.java | 2 +- .../extension/youtube/patches/NavigationButtonsPatch.java | 1 + .../app/revanced/extension/youtube/settings/Settings.java | 4 +++- .../layout/buttons/navigation/NavigationButtonsPatch.kt | 1 + patches/src/main/resources/addresources/values/strings.xml | 6 ++++++ 5 files changed, 12 insertions(+), 2 deletions(-) diff --git a/extensions/shared/library/src/main/java/app/revanced/extension/shared/spoof/ClientType.java b/extensions/shared/library/src/main/java/app/revanced/extension/shared/spoof/ClientType.java index b2e7a5e5f..9f0d17363 100644 --- a/extensions/shared/library/src/main/java/app/revanced/extension/shared/spoof/ClientType.java +++ b/extensions/shared/library/src/main/java/app/revanced/extension/shared/spoof/ClientType.java @@ -111,7 +111,7 @@ public enum ClientType { ANDROID_VR_NO_AUTH.clientVersion, ANDROID_VR_NO_AUTH.requiresAuth, true, - "Android VR" + "Android VR Auth" ); private static boolean forceAVC() { diff --git a/extensions/youtube/src/main/java/app/revanced/extension/youtube/patches/NavigationButtonsPatch.java b/extensions/youtube/src/main/java/app/revanced/extension/youtube/patches/NavigationButtonsPatch.java index 3494ada58..d2e1d5f8b 100644 --- a/extensions/youtube/src/main/java/app/revanced/extension/youtube/patches/NavigationButtonsPatch.java +++ b/extensions/youtube/src/main/java/app/revanced/extension/youtube/patches/NavigationButtonsPatch.java @@ -21,6 +21,7 @@ public final class NavigationButtonsPatch { { put(NavigationButton.HOME, Settings.HIDE_HOME_BUTTON.get()); put(NavigationButton.CREATE, Settings.HIDE_CREATE_BUTTON.get()); + put(NavigationButton.NOTIFICATIONS, Settings.HIDE_NOTIFICATIONS_BUTTON.get()); put(NavigationButton.SHORTS, Settings.HIDE_SHORTS_BUTTON.get()); put(NavigationButton.SUBSCRIPTIONS, Settings.HIDE_SUBSCRIPTIONS_BUTTON.get()); } diff --git a/extensions/youtube/src/main/java/app/revanced/extension/youtube/settings/Settings.java b/extensions/youtube/src/main/java/app/revanced/extension/youtube/settings/Settings.java index a82d48e34..4bc75a413 100644 --- a/extensions/youtube/src/main/java/app/revanced/extension/youtube/settings/Settings.java +++ b/extensions/youtube/src/main/java/app/revanced/extension/youtube/settings/Settings.java @@ -228,7 +228,9 @@ public class Settings extends BaseSettings { public static final BooleanSetting HIDE_SHORTS_BUTTON = new BooleanSetting("revanced_hide_shorts_button", TRUE, true); public static final BooleanSetting HIDE_SUBSCRIPTIONS_BUTTON = new BooleanSetting("revanced_hide_subscriptions_button", FALSE, true); public static final BooleanSetting HIDE_NAVIGATION_BUTTON_LABELS = new BooleanSetting("revanced_hide_navigation_button_labels", FALSE, true); - public static final BooleanSetting SWITCH_CREATE_WITH_NOTIFICATIONS_BUTTON = new BooleanSetting("revanced_switch_create_with_notifications_button", TRUE, true); + public static final BooleanSetting HIDE_NOTIFICATIONS_BUTTON = new BooleanSetting("revanced_hide_notifications_button", FALSE, true); + public static final BooleanSetting SWITCH_CREATE_WITH_NOTIFICATIONS_BUTTON = new BooleanSetting("revanced_switch_create_with_notifications_button", TRUE, true, + "revanced_switch_create_with_notifications_button_user_dialog_message"); public static final BooleanSetting DISABLE_TRANSLUCENT_STATUS_BAR = new BooleanSetting("revanced_disable_translucent_status_bar", FALSE, true); public static final BooleanSetting DISABLE_TRANSLUCENT_NAVIGATION_BAR_LIGHT = new BooleanSetting("revanced_disable_translucent_navigation_bar_light", FALSE, true); public static final BooleanSetting DISABLE_TRANSLUCENT_NAVIGATION_BAR_DARK = new BooleanSetting("revanced_disable_translucent_navigation_bar_dark", FALSE, true); diff --git a/patches/src/main/kotlin/app/revanced/patches/youtube/layout/buttons/navigation/NavigationButtonsPatch.kt b/patches/src/main/kotlin/app/revanced/patches/youtube/layout/buttons/navigation/NavigationButtonsPatch.kt index 06e872f3c..6e560cf3f 100644 --- a/patches/src/main/kotlin/app/revanced/patches/youtube/layout/buttons/navigation/NavigationButtonsPatch.kt +++ b/patches/src/main/kotlin/app/revanced/patches/youtube/layout/buttons/navigation/NavigationButtonsPatch.kt @@ -58,6 +58,7 @@ val navigationButtonsPatch = bytecodePatch( SwitchPreference("revanced_hide_shorts_button"), SwitchPreference("revanced_hide_create_button"), SwitchPreference("revanced_hide_subscriptions_button"), + SwitchPreference("revanced_hide_notifications_button"), SwitchPreference("revanced_switch_create_with_notifications_button"), SwitchPreference("revanced_hide_navigation_button_labels"), ) diff --git a/patches/src/main/resources/addresources/values/strings.xml b/patches/src/main/resources/addresources/values/strings.xml index 336df4bd0..534f78b07 100644 --- a/patches/src/main/resources/addresources/values/strings.xml +++ b/patches/src/main/resources/addresources/values/strings.xml @@ -587,12 +587,18 @@ Adjust volume by swiping vertically on the right side of the screen" Hide Subscriptions Subscriptions button is hidden Subscriptions button is shown + Hide Notifications + Notifications button is hidden + Notifications button is shown Switch Create with Notifications "Create button is switched with Notifications button Note: Enabling this also forcibly hides video ads" Create button is not switched with Notifications button + "Disabling this setting will also disable Shorts ad blocking. + +If changing this setting does not take effect, try switching to Incognito mode." Hide navigation button labels Labels are hidden Labels are shown