From 5535eb4f01c46851765739679de29b44fec6ae3a Mon Sep 17 00:00:00 2001 From: oSumAtrIX Date: Mon, 23 May 2022 20:58:03 +0200 Subject: [PATCH] refactor: improve `ExampleResourcePatch` Signed-off-by: oSumAtrIX --- .../patcher/{ => usage}/PatcherTest.kt | 2 +- .../resource/patch/ExampleResourcePatch.kt | 26 ++++++++----------- 2 files changed, 12 insertions(+), 16 deletions(-) rename src/test/kotlin/app/revanced/patcher/{ => usage}/PatcherTest.kt (97%) diff --git a/src/test/kotlin/app/revanced/patcher/PatcherTest.kt b/src/test/kotlin/app/revanced/patcher/usage/PatcherTest.kt similarity index 97% rename from src/test/kotlin/app/revanced/patcher/PatcherTest.kt rename to src/test/kotlin/app/revanced/patcher/usage/PatcherTest.kt index d4b091f..a6845ef 100644 --- a/src/test/kotlin/app/revanced/patcher/PatcherTest.kt +++ b/src/test/kotlin/app/revanced/patcher/usage/PatcherTest.kt @@ -1,4 +1,4 @@ -package app.revanced.patcher +package app.revanced.patcher.usage import org.junit.jupiter.api.Test diff --git a/src/test/kotlin/app/revanced/patcher/usage/resource/patch/ExampleResourcePatch.kt b/src/test/kotlin/app/revanced/patcher/usage/resource/patch/ExampleResourcePatch.kt index dc99de9..d5b2c42 100644 --- a/src/test/kotlin/app/revanced/patcher/usage/resource/patch/ExampleResourcePatch.kt +++ b/src/test/kotlin/app/revanced/patcher/usage/resource/patch/ExampleResourcePatch.kt @@ -18,21 +18,17 @@ import org.w3c.dom.Element @Version("0.0.1") class ExampleResourcePatch : ResourcePatch() { override fun execute(data: ResourceData): PatchResult { - val editor = data.getXmlEditor("AndroidManifest.xml") - - // regular DomFileEditor - val element = editor - .file - .getElementsByTagName("application") - .item(0) as Element - element - .setAttribute( - "exampleAttribute", - "exampleValue" - ) - - // close the editor to write changes - editor.close() + data.getXmlEditor("AndroidManifest.xml").use { domFileEditor -> + val element = domFileEditor // regular DomFileEditor + .file + .getElementsByTagName("application") + .item(0) as Element + element + .setAttribute( + "exampleAttribute", + "exampleValue" + ) + } // iterate through all available resources data.forEach {