From 066ad274ed98e903786b873f315bd2458a4c49d0 Mon Sep 17 00:00:00 2001 From: Lucaskyy Date: Fri, 8 Apr 2022 22:54:23 +0200 Subject: [PATCH] docs: fixup --- src/main/kotlin/app/revanced/patcher/proxy/ClassProxy.kt | 8 +++++--- .../app/revanced/patcher/smali/InlineSmaliCompiler.kt | 1 + 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/src/main/kotlin/app/revanced/patcher/proxy/ClassProxy.kt b/src/main/kotlin/app/revanced/patcher/proxy/ClassProxy.kt index d0d37a2..037864a 100644 --- a/src/main/kotlin/app/revanced/patcher/proxy/ClassProxy.kt +++ b/src/main/kotlin/app/revanced/patcher/proxy/ClassProxy.kt @@ -4,7 +4,8 @@ import app.revanced.patcher.proxy.mutableTypes.MutableClass import org.jf.dexlib2.iface.ClassDef /** - * A proxy class for a [ClassDef] + * A proxy class for a [ClassDef]. + * * A class proxy simply holds a reference to the original class * and creates a mutable clone for the original class if needed. * @param immutableClass The class to proxy @@ -18,8 +19,9 @@ class ClassProxy( internal lateinit var mutatedClass: MutableClass /** - * Creates and returns a mutable clone of the original class - * A patch should always use the original immutable class reference to avoid unnecessary allocations for the mutable class + * Creates and returns a mutable clone of the original class. + * A patch should always use the original immutable class reference + * to avoid unnecessary allocations for the mutable class. */ fun resolve(): MutableClass { if (!proxyUsed) { diff --git a/src/main/kotlin/app/revanced/patcher/smali/InlineSmaliCompiler.kt b/src/main/kotlin/app/revanced/patcher/smali/InlineSmaliCompiler.kt index d1ced4f..e12ae20 100644 --- a/src/main/kotlin/app/revanced/patcher/smali/InlineSmaliCompiler.kt +++ b/src/main/kotlin/app/revanced/patcher/smali/InlineSmaliCompiler.kt @@ -29,6 +29,7 @@ class InlineSmaliCompiler { * as that will result in exceptions since the labels cannot be calculated. * Do not create dummy labels to fix the issue, since the code addresses will * be messed up and results in broken Dalvik bytecode. + * FIXME: Fix the above issue. When this is fixed, add the proper conversions in [InstructionConverter]. */ fun compileMethodInstructions(instructions: String): List { val input = METHOD_TEMPLATE.format(instructions)