From db304a70c8af816c3fbe7160e60bce6527faeb2e Mon Sep 17 00:00:00 2001 From: Pun Butrach Date: Mon, 27 Jan 2025 16:41:18 +0700 Subject: [PATCH] Merge suggestions from Copilot --- CONTRIBUTING.md | 2 +- README.md | 2 +- docs/developer/0_prerequisites.md | 6 +++--- docs/developer/1_develop.md | 2 +- docs/developer/3_verifying.md | 6 +++--- 5 files changed, 9 insertions(+), 9 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index e8cd2c33..a230c8d4 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -105,7 +105,7 @@ See the guideline for reporting security vulnerability [here](/SECURITY.md) ## 🤚 I don't want to do any of that but I want to contribute either way You can still contribute by spreading positive word about us or if you'd like to sponsor us, checkout https://revanced.app/donate -to learn more on how to you can sponsor via GitHub, Open Collective and cryptocurrencies. +to learn more about how you can sponsor via GitHub, Open Collective, and cryptocurrencies. ❤️ Thank you for considering contributing to ReVanced Manager, ReVanced diff --git a/README.md b/README.md index 8abd70eb..95db690a 100644 --- a/README.md +++ b/README.md @@ -80,7 +80,7 @@ Some of the features ReVanced Manager provides are: ## 🔽 Download -You can get ReVanced Manager the most recent version of by downloading from +You can get the most recent version of ReVanced Manager by downloading from the [ReVanced site](https://revanced.app/download). Learn how to use ReVanced Manager by following the [documentation](/docs). diff --git a/docs/developer/0_prerequisites.md b/docs/developer/0_prerequisites.md index f835402d..c5624e95 100644 --- a/docs/developer/0_prerequisites.md +++ b/docs/developer/0_prerequisites.md @@ -4,19 +4,19 @@ Here's everything you'll need to develop on ReVanced Manager ## 🤝 Recommended environment -- Any environment that capable of running the latest Android Studio, latest Android SDK and JDK 17 with at least 4 GB of memory for coding +- Any environment that is capable of running the latest Android Studio, latest Android SDK, and JDK 17 with at least 4 GB of memory for coding - Any devices with preferably the latest Android version or at least higher than the [`minSdk`](/app/build.gradle.kts) for testing ### Additional Requirements -- Device with root capabilities with latest version of [KernelSU](https://github.com/tiann/KernelSU) or [Magisk](https://github.com/topjohnwu/Magisk) +- A device with root capabilities using the latest version of [KernelSU](https://github.com/tiann/KernelSU) or [Magisk](https://github.com/topjohnwu/Magisk) ## ⚙️ Setting up ### Authenticating to GitHub Registry ReVanced Manager uses dependency from the GitHub Registry (i.e., [ReVanced Patcher](https://github.com/ReVanced/revanced-patcher/packages)) and so your build may fail without authenticating to the service, -to authenticate you must add create a personal access token with the scope `read:packages` [here](https://github.com/settings/tokens/new?scopes=read:packages&description=ReVanced) +to authenticate you must create a personal access token with the scope `read:packages` [here](https://github.com/settings/tokens/new?scopes=read:packages&description=ReVanced) and add your token to `~/.gradle/gradle.properties`, create the file if it does not exist. ```properties diff --git a/docs/developer/1_develop.md b/docs/developer/1_develop.md index 023288f5..596ab2fc 100644 --- a/docs/developer/1_develop.md +++ b/docs/developer/1_develop.md @@ -8,7 +8,7 @@ The styling is based on https://kotlinlang.org/docs/coding-conventions.html ## Commit -At ReVanced, we adopt a naming convention for commit called [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) so for example when your adding new feature you must add `feat: ` before the description of your commit. +At ReVanced, we adopt a naming convention for commit called [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) so for example when you're adding a new feature you must add `feat: ` before the description of your commit. ## Building diff --git a/docs/developer/3_verifying.md b/docs/developer/3_verifying.md index b6131a8c..33bbf1cd 100644 --- a/docs/developer/3_verifying.md +++ b/docs/developer/3_verifying.md @@ -3,13 +3,13 @@ > [!NOTE] > This information is more relevant to alternative store providers -To distribute ReVanced Manager safely and recommended way is to provide the user's with link to +To distribute ReVanced Manager safely and recommended way is to provide the users with a link to user-side . -The certificate SHA-256 of the APK will always be `b6362c6ea7888efd15c0800f480786ad0f5b133b4f84e12d46afba5f9eac1223` unless otherwise notice. +The certificate SHA-256 of the APK will always be `b6362c6ea7888efd15c0800f480786ad0f5b133b4f84e12d46afba5f9eac1223` unless otherwise noted. ## `libaapt2.so` -ReVanced Manager include prebuilt binaries of [`libaapt2.so`][location of libaapt2.so] from https://github.com/ReVanced/aapt2 +ReVanced Manager includes prebuilt binaries of [`libaapt2.so`][location of libaapt2.so] from https://github.com/ReVanced/aapt2 which fixes issue on ARM32-based system, attestation is provided here: https://github.com/ReVanced/aapt2/attestations [location of libaapt2.so]: /app/src/main/jniLibs/