feat: update rules of analysis_options.yaml. and solved all problems (#665)

* update rules of analysis_options.yaml. and solved all problems * refactor: fix remaining problems --------- Co-authored-by: Ushie <ushiekane@gmail.com>
2025-06-13 13:07:38 +02:00 · 2023-01-30 18:05:06 +05:30
parent f5bc1a996f
commit a54ca799b9
62 changed files with 804 additions and 643 deletions
--- a/lib/ui/widgets/shared/application_item.dart
+++ b/lib/ui/widgets/shared/application_item.dart
@ -1,19 +1,13 @@
 import 'dart:typed_data';
+
+import 'package:expandable/expandable.dart';
 import 'package:flutter/material.dart';
 import 'package:flutter_i18n/flutter_i18n.dart';
-import 'package:revanced_manager/ui/widgets/shared/custom_material_button.dart';
 import 'package:revanced_manager/ui/widgets/shared/custom_card.dart';
-import 'package:expandable/expandable.dart';
+import 'package:revanced_manager/ui/widgets/shared/custom_material_button.dart';
 import 'package:timeago/timeago.dart';

 class ApplicationItem extends StatefulWidget {
-  final Uint8List icon;
-  final String name;
-  final DateTime patchDate;
-  final List<String> changelog;
-  final bool isUpdatableApp;
-  final Function() onPressed;
-
  const ApplicationItem({
    Key? key,
    required this.icon,
@ -23,6 +17,12 @@ class ApplicationItem extends StatefulWidget {
    required this.isUpdatableApp,
    required this.onPressed,
  }) : super(key: key);
+  final Uint8List icon;
+  final String name;
+  final DateTime patchDate;
+  final List<String> changelog;
+  final bool isUpdatableApp;
+  final Function() onPressed;

  @override
  State<ApplicationItem> createState() => _ApplicationItemState();
@ -33,7 +33,7 @@ class _ApplicationItemState extends State<ApplicationItem>
  late AnimationController _animationController;

  @override
-  initState() {
+  void initState() {
    super.initState();
    _animationController = AnimationController(
      vsync: this,
@ -49,95 +49,100 @@ class _ApplicationItemState extends State<ApplicationItem>

  @override
  Widget build(BuildContext context) {
-    ExpandableController expController = ExpandableController();
+    final ExpandableController expController = ExpandableController();
    return Container(
-        margin: const EdgeInsets.only(bottom: 16.0),
-        child: CustomCard(
-          onTap: () {
-            expController.toggle();
-            _animationController.isCompleted
-                ? _animationController.reverse()
-                : _animationController.forward();
-          },
-          child: ExpandablePanel(
-            controller: expController,
-            theme: const ExpandableThemeData(
-              inkWellBorderRadius: BorderRadius.all(Radius.circular(16)),
-              tapBodyToCollapse: false,
-              tapBodyToExpand: false,
-              tapHeaderToExpand: false,
-              hasIcon: false,
-              animationDuration: Duration(milliseconds: 450),
-            ),
-            header: Row(
-              children: <Widget>[
-                SizedBox(
-                  width: 40,
-                  child: Image.memory(widget.icon, height: 40, width: 40),
-                ),
-                const SizedBox(width: 4),
-                Padding(
-                  padding: const EdgeInsets.only(left: 15.0),
-                  child: Column(
-                    crossAxisAlignment: CrossAxisAlignment.start,
-                    children: <Widget>[
-                      Text(
-                        widget.name.length > 12
-                            ? '${widget.name.substring(0, 12)}...'
-                            : widget.name,
-                        style: const TextStyle(
-                          fontSize: 16,
-                          fontWeight: FontWeight.w500,
-                        ),
-                      ),
-                      Text(format(widget.patchDate)),
-                    ],
-                  ),
-                ),
-                const Spacer(),
-                RotationTransition(
-                  turns: Tween(begin: 0.0, end: 0.50)
-                      .animate(_animationController),
-                  child: const Padding(
-                    padding: EdgeInsets.all(8.0),
-                    child: Icon(Icons.arrow_drop_down),
-                  ),
-                ),
-                const SizedBox(width: 8),
-                Column(
-                  mainAxisAlignment: MainAxisAlignment.center,
-                  crossAxisAlignment: CrossAxisAlignment.end,
+      margin: const EdgeInsets.only(bottom: 16.0),
+      child: CustomCard(
+        onTap: () {
+          expController.toggle();
+          _animationController.isCompleted
+              ? _animationController.reverse()
+              : _animationController.forward();
+        },
+        child: ExpandablePanel(
+          controller: expController,
+          theme: const ExpandableThemeData(
+            inkWellBorderRadius: BorderRadius.all(Radius.circular(16)),
+            tapBodyToCollapse: false,
+            tapBodyToExpand: false,
+            tapHeaderToExpand: false,
+            hasIcon: false,
+            animationDuration: Duration(milliseconds: 450),
+          ),
+          header: Row(
+            children: <Widget>[
+              SizedBox(
+                width: 40,
+                child: Image.memory(widget.icon, height: 40, width: 40),
+              ),
+              const SizedBox(width: 4),
+              Padding(
+                padding: const EdgeInsets.only(left: 15.0),
+                child: Column(
+                  crossAxisAlignment: CrossAxisAlignment.start,
                  children: <Widget>[
-                    CustomMaterialButton(
-                      label: widget.isUpdatableApp
-                          ? I18nText('applicationItem.patchButton')
-                          : I18nText('applicationItem.infoButton'),
-                      onPressed: widget.onPressed,
+                    Text(
+                      widget.name.length > 12
+                          ? '${widget.name.substring(0, 12)}...'
+                          : widget.name,
+                      style: const TextStyle(
+                        fontSize: 16,
+                        fontWeight: FontWeight.w500,
+                      ),
                    ),
+                    Text(format(widget.patchDate)),
                  ],
                ),
-              ],
-            ),
-            collapsed: const SizedBox(),
-            expanded: Padding(
-              padding: const EdgeInsets.only(
-                  top: 16.0, left: 4.0, right: 4.0, bottom: 4.0),
-              child: Column(
-                crossAxisAlignment: CrossAxisAlignment.start,
+              ),
+              const Spacer(),
+              RotationTransition(
+                turns:
+                    Tween(begin: 0.0, end: 0.50).animate(_animationController),
+                child: const Padding(
+                  padding: EdgeInsets.all(8.0),
+                  child: Icon(Icons.arrow_drop_down),
+                ),
+              ),
+              const SizedBox(width: 8),
+              Column(
+                mainAxisAlignment: MainAxisAlignment.center,
+                crossAxisAlignment: CrossAxisAlignment.end,
                children: <Widget>[
-                  I18nText(
-                    'applicationItem.changelogLabel',
-                    child: const Text(
-                      '',
-                      style: TextStyle(fontWeight: FontWeight.w700),
-                    ),
+                  CustomMaterialButton(
+                    label: widget.isUpdatableApp
+                        ? I18nText('applicationItem.patchButton')
+                        : I18nText('applicationItem.infoButton'),
+                    onPressed: widget.onPressed,
                  ),
-                  const SizedBox(height: 4),
-                  Text('\u2022 ${widget.changelog.join('\n\u2022 ')}'),
                ],
              ),
+            ],
+          ),
+          collapsed: const SizedBox(),
+          expanded: Padding(
+            padding: const EdgeInsets.only(
+              top: 16.0,
+              left: 4.0,
+              right: 4.0,
+              bottom: 4.0,
+            ),
+            child: Column(
+              crossAxisAlignment: CrossAxisAlignment.start,
+              children: <Widget>[
+                I18nText(
+                  'applicationItem.changelogLabel',
+                  child: const Text(
+                    '',
+                    style: TextStyle(fontWeight: FontWeight.w700),
+                  ),
+                ),
+                const SizedBox(height: 4),
+                Text('\u2022 ${widget.changelog.join('\n\u2022 ')}'),
+              ],
            ),
          ),
-        ));
+        ),
+      ),
+    );
  }
 }
--- a/lib/ui/widgets/shared/custom_card.dart
+++ b/lib/ui/widgets/shared/custom_card.dart
@ -1,21 +1,20 @@
 import 'package:flutter/material.dart';

 class CustomCard extends StatelessWidget {
+  const CustomCard({
+    Key? key,
+    this.isFilled = true,
+    required this.child,
+    this.onTap,
+    this.padding,
+    this.backgroundColor,
+  }) : super(key: key);
  final bool isFilled;
  final Widget child;
  final Function()? onTap;
  final EdgeInsetsGeometry? padding;
  final Color? backgroundColor;

-  const CustomCard(
-      {Key? key,
-      this.isFilled = true,
-      required this.child,
-      this.onTap,
-      this.padding,
-      this.backgroundColor})
-      : super(key: key);
-
  @override
  Widget build(BuildContext context) {
    return Material(
--- a/lib/ui/widgets/shared/custom_chip.dart
+++ b/lib/ui/widgets/shared/custom_chip.dart
@ -1,16 +1,15 @@
 import 'package:flutter/material.dart';

 class CustomChip extends StatelessWidget {
-  final Widget label;
-  final bool isSelected;
-  final Function(bool)? onSelected;
-
  const CustomChip({
    Key? key,
    required this.label,
    this.isSelected = false,
    this.onSelected,
  }) : super(key: key);
+  final Widget label;
+  final bool isSelected;
+  final Function(bool)? onSelected;

  @override
  Widget build(BuildContext context) {
--- a/lib/ui/widgets/shared/custom_material_button.dart
+++ b/lib/ui/widgets/shared/custom_material_button.dart
@ -1,11 +1,6 @@
 import 'package:flutter/material.dart';

 class CustomMaterialButton extends StatelessWidget {
-  final Widget label;
-  final bool isFilled;
-  final bool isExpanded;
-  final Function()? onPressed;
-
  const CustomMaterialButton({
    Key? key,
    required this.label,
@ -13,6 +8,10 @@ class CustomMaterialButton extends StatelessWidget {
    this.isExpanded = false,
    required this.onPressed,
  }) : super(key: key);
+  final Widget label;
+  final bool isFilled;
+  final bool isExpanded;
+  final Function()? onPressed;

  @override
  Widget build(BuildContext context) {
@ -28,7 +27,6 @@ class CustomMaterialButton extends StatelessWidget {
            side: isFilled
                ? BorderSide.none
                : BorderSide(
-                    width: 1,
                    color: Theme.of(context).colorScheme.primary,
                  ),
          ),
@ -50,12 +48,6 @@ class CustomMaterialButton extends StatelessWidget {

 // ignore: must_be_immutable
 class TimerButton extends StatefulWidget {
-  Widget label;
-  bool isFilled;
-  int seconds;
-  final bool isRunning;
-  final Function()? onTimerEnd;
-
  TimerButton({
    Key? key,
    required this.seconds,
@ -64,6 +56,11 @@ class TimerButton extends StatefulWidget {
    this.label = const Text(''),
    this.isFilled = true,
  }) : super(key: key);
+  Widget label;
+  bool isFilled;
+  int seconds;
+  final bool isRunning;
+  final Function()? onTimerEnd;

  @override
  State<TimerButton> createState() => _TimerButtonState();
@ -101,7 +98,6 @@ class _TimerButtonState extends State<TimerButton> {
            side: widget.isFilled
                ? BorderSide.none
                : BorderSide(
-                    width: 1,
                    color: Theme.of(context).colorScheme.primary,
                  ),
          ),
--- a/lib/ui/widgets/shared/custom_popup_menu.dart
+++ b/lib/ui/widgets/shared/custom_popup_menu.dart
@ -1,14 +1,13 @@
 import 'package:flutter/material.dart';

 class CustomPopupMenu extends StatelessWidget {
-  final Function(dynamic) onSelected;
-  final Map<int, Widget> children;
-
  const CustomPopupMenu({
    Key? key,
    required this.onSelected,
    required this.children,
  }) : super(key: key);
+  final Function(dynamic) onSelected;
+  final Map<int, Widget> children;

  @override
  Widget build(BuildContext context) {
--- a/lib/ui/widgets/shared/custom_sliver_app_bar.dart
+++ b/lib/ui/widgets/shared/custom_sliver_app_bar.dart
@ -1,12 +1,6 @@
 import 'package:flutter/material.dart';

 class CustomSliverAppBar extends StatelessWidget {
-  final Widget title;
-  final List<Widget>? actions;
-  final PreferredSizeWidget? bottom;
-  final bool isMainView;
-  final Function()? onBackButtonPressed;
-
  const CustomSliverAppBar({
    Key? key,
    required this.title,
@ -15,13 +9,16 @@ class CustomSliverAppBar extends StatelessWidget {
    this.isMainView = false,
    this.onBackButtonPressed,
  }) : super(key: key);
+  final Widget title;
+  final List<Widget>? actions;
+  final PreferredSizeWidget? bottom;
+  final bool isMainView;
+  final Function()? onBackButtonPressed;

  @override
  Widget build(BuildContext context) {
    return SliverAppBar(
      pinned: true,
-      snap: false,
-      floating: false,
      expandedHeight: 100.0,
      automaticallyImplyLeading: !isMainView,
      flexibleSpace: FlexibleSpaceBar(
--- a/lib/ui/widgets/shared/open_container_wrapper.dart
+++ b/lib/ui/widgets/shared/open_container_wrapper.dart
@ -2,21 +2,19 @@ import 'package:animations/animations.dart';
 import 'package:flutter/material.dart';

 class OpenContainerWrapper extends StatelessWidget {
-  final OpenContainerBuilder openBuilder;
-  final CloseContainerBuilder closedBuilder;
-
  const OpenContainerWrapper({
    Key? key,
    required this.openBuilder,
    required this.closedBuilder,
  }) : super(key: key);
+  final OpenContainerBuilder openBuilder;
+  final CloseContainerBuilder closedBuilder;

  @override
  Widget build(BuildContext context) {
    return OpenContainer(
      openBuilder: openBuilder,
      closedBuilder: closedBuilder,
-      transitionType: ContainerTransitionType.fade,
      transitionDuration: const Duration(milliseconds: 400),
      openColor: Theme.of(context).colorScheme.primary,
      closedColor: Colors.transparent,
--- a/lib/ui/widgets/shared/search_bar.dart
+++ b/lib/ui/widgets/shared/search_bar.dart
@ -1,10 +1,6 @@
 import 'package:flutter/material.dart';

 class SearchBar extends StatefulWidget {
-  final String? hintText;
-  final bool showSelectIcon;
-  final Function(bool)? onSelectAll;
-
  const SearchBar({
    Key? key,
    required this.hintText,
@ -12,6 +8,9 @@ class SearchBar extends StatefulWidget {
    this.onSelectAll,
    required this.onQueryChanged,
  }) : super(key: key);
+  final String? hintText;
+  final bool showSelectIcon;
+  final Function(bool)? onSelectAll;

  final Function(String) onQueryChanged;