fix: improve installed apps check

lib/services/manager_api.dart

@@ -1,10 +1,23 @@
+import 'dart:convert';
 import 'dart:io';
+import 'package:device_apps/device_apps.dart';
+import 'package:injectable/injectable.dart';
 import 'package:package_info_plus/package_info_plus.dart';
 import 'package:revanced_manager/constants.dart';
+import 'package:revanced_manager/models/patched_application.dart';
 import 'package:revanced_manager/services/github_api.dart';
+import 'package:revanced_manager/services/root_api.dart';
+import 'package:shared_preferences/shared_preferences.dart';
 
+@lazySingleton
 class ManagerAPI {
   final GithubAPI _githubAPI = GithubAPI();
+  final RootAPI _rootAPI = RootAPI();
+  late SharedPreferences _prefs;
+
+  Future<void> initialize() async {
+    _prefs = await SharedPreferences.getInstance();
+  }
 
   Future<File?> downloadPatches(String extension) async {
     return await _githubAPI.latestReleaseFile(extension, ghOrg, patchesRepo);
@@ -35,6 +48,89 @@ class ManagerAPI {
     return packageInfo.version;
   }
 
+  bool? isRooted() {
+    return _prefs.getBool('isRooted');
+  }
+
+  List<PatchedApplication> getPatchedApps() {
+    List<String> apps = _prefs.getStringList('patchedApps') ?? [];
+    return apps
+        .map((a) => PatchedApplication.fromJson(json.decode(a)))
+        .toList();
+  }
+
+  void setPatchedApps(List<PatchedApplication> patchedApps) {
+    _prefs.setStringList('patchedApps',
+        patchedApps.map((a) => json.encode(a.toJson())).toList());
+  }
+
+  void savePatchedApp(PatchedApplication app) {
+    List<PatchedApplication> patchedApps = getPatchedApps();
+    patchedApps.removeWhere((a) => a.packageName == app.packageName);
+    patchedApps.add(app);
+    setPatchedApps(patchedApps);
+  }
+
+  void saveApp(
+    ApplicationWithIcon application,
+    bool isRooted,
+    bool isFromStorage,
+  ) {
+    savePatchedApp(
+      PatchedApplication(
+        name: application.appName,
+        packageName: application.packageName,
+        version: application.versionName!,
+        apkFilePath: application.apkFilePath,
+        icon: application.icon,
+        patchDate: DateTime.now(),
+        isRooted: isRooted,
+        isFromStorage: isFromStorage,
+        appliedPatches: [],
+      ),
+    );
+  }
+
+  Future<void> reAssessSavedApps() async {
+    List<PatchedApplication> patchedApps = getPatchedApps();
+    bool isRoot = isRooted() ?? false;
+    for (PatchedApplication app in patchedApps) {
+      bool existsRoot = false;
+      if (isRoot) {
+        existsRoot = await _rootAPI.isAppInstalled(app.packageName);
+      }
+      bool existsNonRoot = await DeviceApps.isAppInstalled(app.packageName);
+      if (!existsRoot && !existsNonRoot) {
+        patchedApps.remove(app);
+      } else if (existsNonRoot) {
+        ApplicationWithIcon? application =
+            await DeviceApps.getApp(app.packageName, true)
+                as ApplicationWithIcon?;
+        if (application != null) {
+          int savedVersionInt =
+              int.parse(app.version.replaceFirst('v', '').replaceAll('.', ''));
+          int currentVersionInt = int.parse(application.versionName!
+              .replaceFirst('v', '')
+              .replaceAll('.', ''));
+          if (savedVersionInt < currentVersionInt) {
+            patchedApps.remove(app);
+          }
+        }
+      }
+    }
+    setPatchedApps(patchedApps);
+    List<String> apps = await _rootAPI.getInstalledApps();
+    for (String packageName in apps) {
+      if (!patchedApps.any((a) => a.packageName == packageName)) {
+        ApplicationWithIcon? application =
+            await DeviceApps.getApp(packageName, true) as ApplicationWithIcon?;
+        if (application != null) {
+          saveApp(application, true, false);
+        }
+      }
+    }
+  }
+
   Future<bool> hasAppUpdates(String packageName) async {
     // TODO: get status based on last update time on the folder of this app?
     return false;

lib/services/patcher_api.dart

@@ -4,6 +4,7 @@ import 'package:device_apps/device_apps.dart';
 import 'package:flutter/services.dart';
 import 'package:injectable/injectable.dart';
 import 'package:path_provider/path_provider.dart';
+import 'package:revanced_manager/app/app.locator.dart';
 import 'package:revanced_manager/models/patch.dart';
 import 'package:revanced_manager/models/patched_application.dart';
 import 'package:revanced_manager/services/manager_api.dart';
@@ -16,7 +17,7 @@ class PatcherAPI {
   static const patcherChannel = MethodChannel(
     'app.revanced.manager/patcher',
   );
-  final ManagerAPI _managerAPI = ManagerAPI();
+  final ManagerAPI _managerAPI = locator<ManagerAPI>();
   final RootAPI _rootAPI = RootAPI();
   Directory? _tmpDir;
   Directory? _workDir;
@@ -248,7 +249,7 @@ class PatcherAPI {
 
   Future<bool> checkOldPatch(PatchedApplication patchedApp) async {
     if (patchedApp.isRooted) {
-      return await _rootAPI.checkApp(patchedApp.packageName);
+      return await _rootAPI.isAppInstalled(patchedApp.packageName);
     }
     return false;
   }

lib/services/root_api.dart

@@ -5,15 +5,39 @@ class RootAPI {
   final String _postFsDataDirPath = "/data/adb/post-fs-data.d";
   final String _serviceDDirPath = "/data/adb/service.d";
 
-  Future<bool> checkApp(String packageName) async {
+  Future<bool> isAppInstalled(String packageName) async {
+    if (packageName.isNotEmpty) {
+      String? res = await Root.exec(
+        cmd: 'ls "$_managerDirPath/$packageName"',
+      );
+      if (res != null && res.isNotEmpty) {
+        res = await Root.exec(
+          cmd: 'ls "$_serviceDDirPath/$packageName.sh"',
+        );
+        return res != null && res.isNotEmpty;
+      }
+    }
+    return false;
+  }
+
+  Future<List<String>> getInstalledApps() async {
     try {
       String? res = await Root.exec(
-        cmd: 'ls -la "$_managerDirPath/$packageName"',
+        cmd: 'ls "$_managerDirPath"',
       );
-      return res != null && res.isNotEmpty;
+      if (res != null) {
+        List<String> apps = res.split('\n');
+        for (String packageName in apps) {
+          bool isInstalled = await isAppInstalled(packageName);
+          if (!isInstalled) {
+            apps.remove(packageName);
+          }
+        }
+      }
     } on Exception {
-      return false;
+      return List.empty();
     }
+    return List.empty();
   }
 
   Future<void> deleteApp(String packageName, String originalFilePath) async {