ReVanced/revanced-manager
1
0
Fork 0
mirror of https://github.com/revanced/revanced-manager.git synced 2025-04-29 21:44:26 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix: Delete cached APK only after successful patch (#2331)

Browse Source
This commit is contained in:
Benjamin 2024-12-23 16:48:57 -08:00 committed by GitHub
parent 1d6b074856
commit 4ba7ec1854
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
lib/services/patcher_api.dart
View File

@ -175,13 +175,6 @@ class PatcherAPI {
final File inApkFile = File('${workDir.path}/in.apk'); final File inApkFile = File('${workDir.path}/in.apk');
await File(apkFilePath).copy(inApkFile.path); await File(apkFilePath).copy(inApkFile.path);
if (isFromStorage) {
// The selected apk was copied to cacheDir by the file picker, so it's not needed anymore.
// rename() can't be used here, as Android system also counts the size of files moved out from cacheDir
// as part of the app's cache size.
File(apkFilePath).delete();
}
outFile = File('${workDir.path}/out.apk'); outFile = File('${workDir.path}/out.apk');
final Directory tmpDir = final Directory tmpDir =

6
lib/ui/views/installer/installer_viewmodel.dart
View File

@ -1,4 +1,6 @@
// ignore_for_file: use_build_context_synchronously // ignore_for_file: use_build_context_synchronously
import 'dart:io';
import 'package:device_apps/device_apps.dart'; import 'package:device_apps/device_apps.dart';
import 'package:flutter/foundation.dart'; import 'package:flutter/foundation.dart';
import 'package:flutter/material.dart'; import 'package:flutter/material.dart';
@ -566,6 +568,10 @@ class InstallerViewModel extends BaseViewModel {
Future<void> cleanPatcher() async { Future<void> cleanPatcher() async {
try { try {
_patcherAPI.cleanPatcher(); _patcherAPI.cleanPatcher();
if (_app.isFromStorage) {
// The selected apk was copied to cacheDir by the file picker, so it's not needed anymore.
File(_app.apkFilePath).delete();
}
locator<PatcherViewModel>().selectedApp = null; locator<PatcherViewModel>().selectedApp = null;
locator<PatcherViewModel>().selectedPatches.clear(); locator<PatcherViewModel>().selectedPatches.clear();
locator<PatcherViewModel>().notifyListeners(); locator<PatcherViewModel>().notifyListeners();