fix: Slight tweak and use Flutter suggested config

Signed-off-by: validcube <pun.butrach@gmail.com>
This commit is contained in:
validcube
2025-02-15 17:25:29 +07:00
parent 5b6426c453
commit 4b7b05ac0f
9 changed files with 55 additions and 63 deletions

View File

@ -87,7 +87,7 @@ jobs:
- name: Prepare comment
id: prepare-comment # This should work now?
run: |
COMMIT_HASH=$(git rev-parse --short HEAD)
echo "COMMIT_HASH=$(git rev-parse --short HEAD)" >> $GITHUB_ENV
if [[ "${{ steps.flutter-build.outcome }}" == "success" ]]; then
MESSAGE="✅ Succeeded build on $COMMIT_HASH."
else
@ -108,12 +108,12 @@ jobs:
${{ steps.prepare-comment.outputs.MESSAGE }}
Details: [_execution **${{ github.run_id }}** / attempt **${{ github.run_attempt }}**_](https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }})!
Details: [_Job execution **${{ github.run_id }}** / attempt **${{ github.run_attempt }}**_](https://github.com/${{ github.repository }}/actions/runs/${{ github.run_id }})!
### ⚙️ Workflow Steps
| Step | Status |
| ------------------------- | :------------------------------------------------------- |
| :------------------------ | :------------------------------------------------------- |
| **Get dependencies** | ${{ steps.get-dependencies.outcome || job.status }} |
| **Generate translations** | ${{ steps.generate-translations.outcome || job.status }} |
| **Generate code files** | ${{ steps.generate-code-files.outcome || job.status }} |
@ -123,7 +123,7 @@ jobs:
| Parameter | Value |
| :--------------- | :--------------------------------------- |
| App flavor | ${{ inputs.app-flavor }} |
| App flavor | ${{ inputs.app-flavor }} |
| Flutter version | ${{ inputs.flutter-version }} |
| Flutter channel | ${{ inputs.flutter-channel }} |
@ -131,7 +131,7 @@ jobs:
if: steps.flutter-build.outcome == 'success'
uses: actions/upload-artifact@v4
with:
name: revanced-manager-(${{ steps.prepare-comment.outputs.COMMIT_HASH }}-${{ inputs.pr-number }}-${{ inputs.app-flavor }}-${{ inputs.flutter-version }})
name: revanced-manager-(${{ env.COMMIT_HASH }}-${{ inputs.pr-number }}-${{ inputs.app-flavor }}-${{ inputs.flutter-version }})
path: |
build/app/outputs/flutter-apk/app-${{ inputs.app-flavor }}.apk
build/app/outputs/flutter-apk/app-${{ inputs.app-flavor }}.apk.sha1

View File

@ -25,7 +25,6 @@ jobs:
uses: subosito/flutter-action@v2
with:
cache: true
flutter-version: 3.27.x
- name: Sync translations from Crowdin
uses: crowdin/github-action@v2
@ -59,13 +58,13 @@ jobs:
dart run slang analyze
dart run slang clean
dart run slang normalize
dart run slang
cd assets/i18n
dart nuke.dart >> $GITHUB_STEP_SUMMARY
cd ../..
dart run slang
flutter analyze lib/gen/strings.g.dart --no-fatal-infos --no-fatal-warnings
- name: Commit translations