From 4da053804bbcb0ea1d78d446077286ee2931a2b1 Mon Sep 17 00:00:00 2001 From: Lachlan Wimsett <6858484+lachlanwimsett@users.noreply.github.com> Date: Sat, 9 Apr 2022 05:25:38 +1200 Subject: [PATCH] fix: correct implementation of indexOf (#5) LithoAdRemoval.indexOf never increments the index for the outer loop, causing an infinite loop --- .../java/fi/razerman/youtube/litho/LithoAdRemoval.java | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/app/src/main/java/fi/razerman/youtube/litho/LithoAdRemoval.java b/app/src/main/java/fi/razerman/youtube/litho/LithoAdRemoval.java index a625fa38..5dd8f108 100644 --- a/app/src/main/java/fi/razerman/youtube/litho/LithoAdRemoval.java +++ b/app/src/main/java/fi/razerman/youtube/litho/LithoAdRemoval.java @@ -188,14 +188,17 @@ public class LithoAdRemoval { return 0; } - int i = 0; - while (i < array.length - target.length + 1 ){ + for (int i = 0; i < array.length - target.length + 1; i++) { + boolean targetFound = true; for (int j = 0; j < target.length; j++) { if (array[i+j] != target[j]) { + targetFound = false; break; } } - return i; + if (targetFound) { + return i; + } } return -1; }