ReVanced/smali
1
0
Fork 0
mirror of https://github.com/revanced/smali.git synced 2025-05-04 16:44:25 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix how signed values are checked in Preconditions

Browse Source
This commit is contained in:
Ben Gruver 2012-10-30 23:05:06 -07:00
parent 8b5490919c
commit f8a63e41aa
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
dexlib2/src/main/java/org/jf/dexlib2/util/Preconditions.java
View File

@ -67,7 +67,7 @@ public class Preconditions {
} }
public static int checkNibbleLiteral(int literal) { public static int checkNibbleLiteral(int literal) {
if ((literal & 0xFFFFFFF0) != 0) { if (literal < -8 || literal > 7) {
throw new IllegalArgumentException( throw new IllegalArgumentException(
String.format("Invalid literal value: %d. Must be between -8 and 7, inclusive.", literal)); String.format("Invalid literal value: %d. Must be between -8 and 7, inclusive.", literal));
} }
@ -75,7 +75,7 @@ public class Preconditions {
} }
public static int checkByteLiteral(int literal) { public static int checkByteLiteral(int literal) {
if ((literal & 0xFFFFFF00) != 0) { if (literal < -128 || literal > 127) {
throw new IllegalArgumentException( throw new IllegalArgumentException(
String.format("Invalid literal value: %d. Must be between -128 and 127, inclusive.", literal)); String.format("Invalid literal value: %d. Must be between -128 and 127, inclusive.", literal));
} }
@ -83,7 +83,7 @@ public class Preconditions {
} }
public static int checkShortLiteral(int literal) { public static int checkShortLiteral(int literal) {
if ((literal & 0xFFFF0000) != 0) { if (literal < -32768 || literal > 32767) {
throw new IllegalArgumentException( throw new IllegalArgumentException(
String.format("Invalid literal value: %d. Must be between -32768 and 32767, inclusive.", literal)); String.format("Invalid literal value: %d. Must be between -32768 and 32767, inclusive.", literal));
} }
@ -101,21 +101,21 @@ public class Preconditions {
public static long checkLongHatLiteral(long literal) { public static long checkLongHatLiteral(long literal) {
if ((literal & 0xFFFFFFFFFFFFL) != 0) { if ((literal & 0xFFFFFFFFFFFFL) != 0) {
throw new IllegalArgumentException( throw new IllegalArgumentException(
String.format("Invalid literal value: %d. Low 16 bits must be zeroed out.", literal)); String.format("Invalid literal value: %d. Low 48 bits must be zeroed out.", literal));
} }
return literal; return literal;
} }
public static int checkByteCodeOffset(int register) { public static int checkByteCodeOffset(int register) {
if ((register & 0xFFFFFF00) != 0) { if (register < -128 || register > 127) {
throw new IllegalArgumentException( throw new IllegalArgumentException(
String.format("Invalid code offset: %d. Must be between -8 and 7, inclusive.", register)); String.format("Invalid code offset: %d. Must be between -128 and 127, inclusive.", register));
} }
return register; return register;
} }
public static int checkShortCodeOffset(int register) { public static int checkShortCodeOffset(int register) {
if ((register & 0xFFFF0000) != 0) { if (register < -32768 || register > 32768) {
throw new IllegalArgumentException( throw new IllegalArgumentException(
String.format("Invalid code offset: %d. Must be between -32768 and 32767, inclusive.", register)); String.format("Invalid code offset: %d. Must be between -32768 and 32767, inclusive.", register));
} }