ReVanced/smali
1
0
Fork 0
mirror of https://github.com/revanced/smali.git synced 2025-05-08 10:24:31 +02:00
Code Issues Packages Projects Releases Wiki Activity

Refactor the writeParameters method a bit

Browse Source 
- Accepts a method instead of the parameter list directly
- Uses the correct pN register values for non-static vs. static methods
- Adds a space after the # for the type comment
This commit is contained in:
Ben Gruver 2012-10-31 20:20:28 -07:00
parent db4316ef6d
commit c3a3ee3799
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
baksmali/src/main/java/org/jf/baksmali/Adaptors/MethodDefinition.java
View File

@ -113,7 +113,7 @@ public class MethodDefinition {
writer.write('\n');
writer.indent(4);
writeParameters(writer, method.getParameters());
writeParameters(writer, method);
AnnotationFormatter.writeTo(writer, method.getAnnotations());
writer.deindent(4);
writer.write(".end method\n");
@ -150,7 +150,7 @@ public class MethodDefinition {
writer.printSignedIntAsDec(methodImpl.getRegisterCount());
}
writer.write('\n');
writeParameters(writer, method.getParameters());
writeParameters(writer, method);
if (registerFormatter == null) {
registerFormatter = new RegisterFormatter(methodImpl.getRegisterCount(), parameterRegisterCount);
@ -202,10 +202,10 @@ public class MethodDefinition {
}
}
private static void writeParameters(IndentingWriter writer,
List<? extends MethodParameter> parameters) throws IOException {
int registerNumber = 0;
for (MethodParameter parameter: parameters) {
private static void writeParameters(IndentingWriter writer, Method method) throws IOException {
boolean isStatic = AccessFlags.STATIC.isSet(method.getAccessFlags());
int registerNumber = isStatic?0:1;
for (MethodParameter parameter: method.getParameters()) {
String parameterType = parameter.getType();
String parameterName = parameter.getName();
List<? extends Annotation> annotations = parameter.getAnnotations();
@ -217,7 +217,7 @@ public class MethodDefinition {
// TODO: does dalvik allow non-identifier parameter and/or local names?
writer.write(parameterName);
}
writer.write(" #");
writer.write(" # ");
writer.write(parameterType);
if (annotations.size() > 0) {
writer.indent(4);