From c308b24b6261ea81497a69e6d4d7ef6319943b10 Mon Sep 17 00:00:00 2001
From: "JesusFreke@JesusFreke.com"
 <JesusFreke@JesusFreke.com@55b6fa8a-2a1e-11de-a435-ffa8d773f76a>
Date: Mon, 25 Jan 2010 00:36:52 +0000
Subject: [PATCH] Implemented verification for aget-wide

git-svn-id: https://smali.googlecode.com/svn/trunk@588 55b6fa8a-2a1e-11de-a435-ffa8d773f76a
---
 .../dexlib/Code/Analysis/MethodAnalyzer.java  | 57 +++++++++++++++++++
 1 file changed, 57 insertions(+)

diff --git a/dexlib/src/main/java/org/jf/dexlib/Code/Analysis/MethodAnalyzer.java b/dexlib/src/main/java/org/jf/dexlib/Code/Analysis/MethodAnalyzer.java
index bc0f24ec..2a3ac89f 100644
--- a/dexlib/src/main/java/org/jf/dexlib/Code/Analysis/MethodAnalyzer.java
+++ b/dexlib/src/main/java/org/jf/dexlib/Code/Analysis/MethodAnalyzer.java
@@ -510,6 +510,8 @@ public class MethodAnalyzer {
                 return handle32BitPrimitiveAget(analyzedInstruction, RegisterType.Category.Char);
             case AGET_SHORT:
                 return handle32BitPrimitiveAget(analyzedInstruction, RegisterType.Category.Short);
+            case AGET_WIDE:
+                return handleAgetWide(analyzedInstruction);
         }
 
         assert false;
@@ -1412,6 +1414,61 @@ public class MethodAnalyzer {
         return true;
     }
 
+    private boolean handleAgetWide(AnalyzedInstruction analyzedInstruction) {
+        ThreeRegisterInstruction instruction = (ThreeRegisterInstruction)analyzedInstruction.instruction;
+
+        RegisterType indexRegisterType = analyzedInstruction.getPreInstructionRegisterType(instruction.getRegisterC());
+        assert indexRegisterType != null;
+        if (indexRegisterType.category == RegisterType.Category.Unknown) {
+            return false;
+        }
+        checkRegister(indexRegisterType, Primitive32BitCategories);
+
+        RegisterType arrayRegisterType = analyzedInstruction.getPreInstructionRegisterType(instruction.getRegisterB());
+        assert arrayRegisterType != null;
+        if (indexRegisterType.category == RegisterType.Category.Unknown) {
+            return false;
+        }
+
+        if (arrayRegisterType.category != RegisterType.Category.Null) {
+            if (arrayRegisterType.category != RegisterType.Category.Reference) {
+                throw new ValidationException(String.format("Cannot use aget-wide with non-array type %s",
+                        arrayRegisterType.category.toString()));
+            }
+
+            assert arrayRegisterType.type != null;
+            if (arrayRegisterType.type.getClassType().charAt(0) != '[') {
+                throw new ValidationException(String.format("Cannot use aget-wide with non-array type %s",
+                        arrayRegisterType.type.getClassType()));
+            }
+
+            assert arrayRegisterType.type instanceof ClassPath.ArrayClassDef;
+            ClassPath.ArrayClassDef arrayClassDef = (ClassPath.ArrayClassDef)arrayRegisterType.type;
+
+            if (arrayClassDef.getArrayDimensions() != 1) {
+                throw new ValidationException(String.format("Cannot use aget-wide with multi-dimensional array type %s",
+                        arrayRegisterType.type.getClassType()));
+            }
+
+            char arrayBaseType = arrayClassDef.getBaseElementClass().getClassType().charAt(0);
+            if (arrayBaseType == 'J') {
+                setWideDestinationRegisterTypeAndPropagateChanges(analyzedInstruction,
+                        RegisterType.getRegisterType(RegisterType.Category.LongLo, null));
+            } else if (arrayBaseType == 'D') {
+                setWideDestinationRegisterTypeAndPropagateChanges(analyzedInstruction,
+                        RegisterType.getRegisterType(RegisterType.Category.DoubleLo, null));
+            } else {
+                throw new ValidationException(String.format("Cannot use aget-wide with array type %s. Incorrect " +
+                        "array type for the instruction.", arrayRegisterType.type.getClassType()));
+            }
+        } else {
+            setWideDestinationRegisterTypeAndPropagateChanges(analyzedInstruction,
+                        RegisterType.getRegisterType(RegisterType.Category.LongLo, null));
+        }
+
+        return true;
+    }
+
     private static boolean checkArrayFieldAssignment(RegisterType.Category arrayFieldCategory,
                                                   RegisterType.Category instructionCategory) {
         if (arrayFieldCategory == instructionCategory) {