ReVanced/smali
1
0
Fork 0
mirror of https://github.com/revanced/smali.git synced 2025-05-29 12:20:11 +02:00
Code Issues Packages Projects Releases Wiki Activity

Fix an unprotected read in SmaliClassReferenceSearcher

Browse Source
This commit is contained in:
Ben Gruver 2015-05-09 11:15:33 -07:00
parent 1895a4df82
commit 546fdfe3d1
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
smalidea/src/main/java/org/jf/smalidea/findUsages/SmaliClassReferenceSearcher.java
View File

@ -71,14 +71,22 @@ public class SmaliClassReferenceSearcher extends QueryExecutorBase<PsiReference,
final SingleTargetRequestResultProcessor processor = new SingleTargetRequestResultProcessor(element); final SingleTargetRequestResultProcessor processor = new SingleTargetRequestResultProcessor(element);
SearchScope querySearchScope = ApplicationManager.getApplication().runReadAction(
new Computable<SearchScope>() {
@Override public SearchScope compute() {
return queryParameters.getEffectiveSearchScope();
}
});
// TODO: is it possible to get a LocalSearchScope here? If so, how to handle it? // TODO: is it possible to get a LocalSearchScope here? If so, how to handle it?
if (!(queryParameters.getEffectiveSearchScope() instanceof GlobalSearchScope)) { if (!(querySearchScope instanceof GlobalSearchScope)) {
assert false;
return; return;
} }
PsiSearchHelper helper = PsiSearchHelper.SERVICE.getInstance(element.getProject()); PsiSearchHelper helper = PsiSearchHelper.SERVICE.getInstance(element.getProject());
// TODO: limit search scope to only smali files. See, e.g. AnnotatedPackagesSearcher.PackageInfoFilesOnly // TODO: limit search scope to only smali files. See, e.g. AnnotatedPackagesSearcher.PackageInfoFilesOnly
helper.processAllFilesWithWord(smaliType, (GlobalSearchScope)queryParameters.getEffectiveSearchScope(), helper.processAllFilesWithWord(smaliType, (GlobalSearchScope)querySearchScope,
new Processor<PsiFile>() { new Processor<PsiFile>() {
@Override @Override
public boolean process(PsiFile file) { public boolean process(PsiFile file) {