ReVanced/smali
1
0
Fork 0
mirror of https://github.com/revanced/smali.git synced 2025-05-04 16:44:25 +02:00
Code Issues Packages Projects Releases Wiki Activity

Don't pre-sort ClassDefItems

Browse Source
This commit is contained in:
Ben Gruver 2012-06-11 16:00:43 -07:00
parent 9a295c54e1
commit 4de8efcc31
2 changed files with 8 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
dexlib/src/main/java/org/jf/dexlib/ClassDefItem.java
View File

@ -197,9 +197,9 @@ public class ClassDefItem extends Item<ClassDefItem> {
/** {@inheritDoc} */ /** {@inheritDoc} */
public int compareTo(ClassDefItem o) { public int compareTo(ClassDefItem o) {
//The actual sorting for this class is implemented in SortClassDefItemSection. //The actual sorting for this class is done during the placement phase, in ClassDefPlacer.
//This method is just used for sorting the associated ClassDataItem items, so //This method is just used for sorting the associated ClassDataItem items after the ClassDefItems have been
//we can just do the comparison based on the offsets of the items //placed, so we can just do the comparison based on the offsets
return this.getOffset() - o.getOffset(); return this.getOffset() - o.getOffset();
} }

11
dexlib/src/main/java/org/jf/dexlib/DexFile.java
View File

@ -773,16 +773,15 @@ public class DexFile
int ret = ClassDefItem.placeClassDefItems(this, offset); int ret = ClassDefItem.placeClassDefItems(this, offset);
Collections.sort(this.items, new Comparator<ClassDefItem>() { Collections.sort(this.items);
public int compare(ClassDefItem a, ClassDefItem b) {
return a.getOffset() - b.getOffset();
}
});
this.offset = items.get(0).getOffset(); this.offset = items.get(0).getOffset();
return ret; return ret;
} }
protected void sortSection() {
// Do nothing. Sorting is handled by ClassDefItem.ClassDefPlacer, during placement
}
}; };
/** /**