From 3687f27ddd106fb0712dba8adcb48c110ad41c43 Mon Sep 17 00:00:00 2001 From: "JesusFreke@JesusFreke.com" Date: Mon, 24 Aug 2009 05:47:29 +0000 Subject: [PATCH] When interning an item, don't forget to add the item to the items list git-svn-id: https://smali.googlecode.com/svn/trunk@413 55b6fa8a-2a1e-11de-a435-ffa8d773f76a --- dexlib/src/main/java/org/jf/dexlib/Section.java | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/dexlib/src/main/java/org/jf/dexlib/Section.java b/dexlib/src/main/java/org/jf/dexlib/Section.java index e9650424..d7cf78f7 100644 --- a/dexlib/src/main/java/org/jf/dexlib/Section.java +++ b/dexlib/src/main/java/org/jf/dexlib/Section.java @@ -34,8 +34,6 @@ import org.jf.dexlib.Util.AlignmentUtils; import java.util.*; -import junit.framework.Assert; - public abstract class Section { /** * A list of the items that this section contains. @@ -90,7 +88,7 @@ public abstract class Section { for (int i=0; i < items.size(); i++) { T item = items.get(i); - Assert.assertTrue("This section contains a null item", item != null); + assert item != null; offset = AlignmentUtils.alignOffset(offset, ItemType.ItemAlignment); offset = item.placeAt(offset, i); } @@ -179,6 +177,7 @@ public abstract class Section { T internedItem = getInternedItem(item); if (internedItem == null) { uniqueItems.put(item, item); + items.add(item); return item; } return internedItem; @@ -202,7 +201,7 @@ public abstract class Section { private void buildInternedItemMap() { uniqueItems = new HashMap(); for (T item: items) { - Assert.assertTrue("item shouldn't be null here", item != null); + assert item != null; uniqueItems.put(item, item); } }