ReVanced/smali
1
0
Fork 0
mirror of https://github.com/revanced/smali.git synced 2025-05-10 11:24:30 +02:00
Code Issues Packages Projects Releases Wiki Activity

misc TODO review/cleanup

Browse Source 
git-svn-id: https://smali.googlecode.com/svn/trunk@130 55b6fa8a-2a1e-11de-a435-ffa8d773f76a
This commit is contained in:
JesusFreke@JesusFreke.com 2009-06-08 01:24:40 +00:00
parent 0fa57d3fe1
commit 34a4a30e34
3 changed files with 3 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/main/antlr3/org/JesusFreke/smali/smaliLexer.g
View File

@ -923,9 +923,7 @@ fragment TYPE_FIELD_METHOD_LITERAL_EMITCHILDREN
MEMBER_NAME_EMIT MEMBER_NAME_EMIT
( METHOD_PROTOTYPE_EMITCHILDREN ( METHOD_PROTOTYPE_EMITCHILDREN
| COLON_EMIT NONVOID_TYPE_DESCRIPTOR_EMITCHILD))? | COLON_EMIT NONVOID_TYPE_DESCRIPTOR_EMITCHILD))?
//TODO: allow void and primitive type here? | PRIMITIVE_TYPE_EMIT;
| PRIMITIVE_TYPE_EMIT
| VOID_TYPE_EMIT;
fragment ENUM_EMIT fragment ENUM_EMIT
: ENUM {emit($ENUM, ENUM);}; : ENUM {emit($ENUM, ENUM);};

6
src/main/antlr3/org/JesusFreke/smali/smaliParser.g
View File

@ -176,13 +176,11 @@ smali_file
EOF EOF
{ {
if (!$smali_file::hasClassSpec) { if (!$smali_file::hasClassSpec) {
//TODO: throw correct exception type throw new SemanticException(input, "The file must contain a .class directive");
throw new RuntimeException("The file must contain a .class directive");
} }
if (!$smali_file::hasSuperSpec) { if (!$smali_file::hasSuperSpec) {
//TODO: throw correct exception type throw new SemanticException(input, "The file must contain a .super directive");
throw new RuntimeException("The file must contain a .super directive");
} }
} }
-> ^(I_CLASS_DEF -> ^(I_CLASS_DEF

1
src/main/antlr3/org/JesusFreke/smali/smaliTreeWalker.g
View File

@ -1061,7 +1061,6 @@ register_list[int totalMethodRegisters, int methodParameterRegisters] returns[by
: ^(I_REGISTER_LIST : ^(I_REGISTER_LIST
(REGISTER (REGISTER
{ {
//TODO: shouldn't this be == 6?
if ($registerCount == 5) { if ($registerCount == 5) {
throw new SemanticException(input, "A list of registers can only have a maximum of 5 registers. Use the <op>/range alternate opcode instead."); throw new SemanticException(input, "A list of registers can only have a maximum of 5 registers. Use the <op>/range alternate opcode instead.");
} }