From 2e52e0e6e4d9bd042b8560c489c48468a5408c41 Mon Sep 17 00:00:00 2001 From: "JesusFreke@JesusFreke.com" Date: Thu, 24 Dec 2009 08:07:23 +0000 Subject: [PATCH] remove unneeded TODO: and added a new one git-svn-id: https://smali.googlecode.com/svn/trunk@516 55b6fa8a-2a1e-11de-a435-ffa8d773f76a --- dexlib/src/main/java/org/jf/dexlib/CodeItem.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dexlib/src/main/java/org/jf/dexlib/CodeItem.java b/dexlib/src/main/java/org/jf/dexlib/CodeItem.java index 68ebd388..8c19a23a 100644 --- a/dexlib/src/main/java/org/jf/dexlib/CodeItem.java +++ b/dexlib/src/main/java/org/jf/dexlib/CodeItem.java @@ -309,7 +309,6 @@ public class CodeItem extends Item { /** {@inheritDoc} */ public String getConciseIdentity() { - //TODO: should mention the method name here return "code_item @0x" + Integer.toHexString(getOffset()); } @@ -399,6 +398,7 @@ public class CodeItem extends Item { * - Replace const-string instruction with const-string/jumbo, when the string index is too big * - Replace goto and goto/16 with a larger version of goto, when the target is too far away * TODO: we should be able to replace if-* instructions with targets that are too far away with a negated if followed by a goto/32 to the original target + * TODO: remove multiple nops that occur before a switch/array data pseudo instruction. In some cases, multiple smali-baksmali cycles with changes in between could cause nops to start piling up * * The above fixes are applied iteratively, until no more fixes have been performed */