From 216ca5376b8c5a121beebdaf4d2b5259b2f38b95 Mon Sep 17 00:00:00 2001 From: Ben Gruver Date: Thu, 10 Oct 2013 19:37:56 -0700 Subject: [PATCH] Always use the 035 version magic value when writing a dex file --- dexlib2/src/main/java/org/jf/dexlib2/writer/DexWriter.java | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/dexlib2/src/main/java/org/jf/dexlib2/writer/DexWriter.java b/dexlib2/src/main/java/org/jf/dexlib2/writer/DexWriter.java index 6d09a5a6..ed591f7a 100644 --- a/dexlib2/src/main/java/org/jf/dexlib2/writer/DexWriter.java +++ b/dexlib2/src/main/java/org/jf/dexlib2/writer/DexWriter.java @@ -1172,11 +1172,8 @@ public abstract class DexWriter< } private void writeHeader(@Nonnull DexDataWriter writer, int dataOffset, int fileSize) throws IOException { - if (api < 14) { - writer.write(HeaderItem.MAGIC_VALUES[0]); - } else { - writer.write(HeaderItem.MAGIC_VALUES[1]); - } + // always write the 035 version, there's no reason to use the 036 version for now + writer.write(HeaderItem.MAGIC_VALUES[0]); // checksum placeholder writer.writeInt(0);