From 146fbfd33ae5f5acb92853d1f21c0a8ebceb453a Mon Sep 17 00:00:00 2001 From: "JesusFreke@JesusFreke.com" Date: Thu, 24 Dec 2009 08:07:44 +0000 Subject: [PATCH] Throw an error if a switch data pseudo-instruction is encountered when auto-fixing a method. git-svn-id: https://smali.googlecode.com/svn/trunk@518 55b6fa8a-2a1e-11de-a435-ffa8d773f76a --- dexlib/src/main/java/org/jf/dexlib/CodeItem.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/dexlib/src/main/java/org/jf/dexlib/CodeItem.java b/dexlib/src/main/java/org/jf/dexlib/CodeItem.java index 5bf50e56..4db48cd8 100644 --- a/dexlib/src/main/java/org/jf/dexlib/CodeItem.java +++ b/dexlib/src/main/java/org/jf/dexlib/CodeItem.java @@ -549,8 +549,7 @@ public class CodeItem extends Item { int originalSwitchOffset = originalSwitchOffsetByOriginalSwitchDataOffset.get(originalDataOffset); if (originalSwitchOffset == 0) { - //TODO: is it safe to skip an unreferenced switch data instruction? Or should it throw an exception? - continue; + throw new RuntimeException("This method contains an unreferenced switch data block, and can't be automatically fixed."); } assert newOffsetsByOriginalOffset.indexOfKey(originalSwitchOffset) >= 0;