ReVanced/smali
1
0
Fork 0
mirror of https://github.com/revanced/smali.git synced 2025-05-11 11:54:29 +02:00
Code Issues Packages Projects Releases Wiki Activity

Delete some unneeded TODOs

Browse Source
This commit is contained in:
Ben Gruver 2013-04-29 23:49:55 -07:00
parent 894327c7ed
commit 03a4ffa1f4
2 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
dexlib2/src/main/java/org/jf/dexlib2/writer/builder/BuilderStringPool.java
View File

@ -72,7 +72,6 @@ class BuilderStringPool implements StringSection<BuilderStringReference, Builder
@Nonnull @Override public Collection<? extends Entry<? extends BuilderStringReference, Integer>> getItems() {
return new BuilderMapEntryCollection<BuilderStringReference>(internedItems.values()) {
@Override protected int getValue(@Nonnull BuilderStringReference key) {
// TODO: see what the performance of using key.getIndex() for everything is like
return key.index;
}

1
dexlib2/src/main/java/org/jf/dexlib2/writer/util/InstructionWriteUtil.java
View File

@ -151,7 +151,6 @@ public class InstructionWriteUtil<Insn extends Instruction, StringRef extends St
for (Instruction instruction: originalInstructions) {
if (instruction.getOpcode().equals(Opcode.CONST_STRING)) {
ReferenceInstruction refInstr = (ReferenceInstruction) instruction;
// TODO: add the necessary generic plumbing to the Instruction interface to make this work without a warning (ugh)
int referenceIndex = stringIndexProvider.getItemIndex((StringRef)refInstr.getReference());
if (referenceIndex > 0xFFFF) {
if (codeOffsetShifts == null) {