From 4b4608ddbc0ccb0eba94d70cfaed84a6914b99e8 Mon Sep 17 00:00:00 2001 From: Alexandre Teles Date: Mon, 10 Apr 2023 20:49:40 -0300 Subject: [PATCH] fix: typing issues --- src/app/api.py | 8 ++++---- src/app/generator.py | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/app/api.py b/src/app/api.py index 7abcfa2..f242841 100644 --- a/src/app/api.py +++ b/src/app/api.py @@ -4,11 +4,11 @@ import requests class Api: - _api_key: str + _api_key: str | None @abstractmethod - def __init__(self, api_key: str = None) -> None: - self._api_key: str = api_key + def __init__(self, api_key: str | None = None) -> None: + self._api_key = api_key @abstractmethod def get_release( @@ -108,7 +108,7 @@ class GitHubApi(Api): ).json() return list(map(transform_release, releases)) # List might not be needed. else: - latest_release: object = requests.get( + latest_release: dict = requests.get( f"https://api.github.com/repos/{repository}/releases/latest?prerelease={prerelease}" ).json() return transform_release(latest_release) diff --git a/src/app/generator.py b/src/app/generator.py index e3dfd8c..718c9bf 100644 --- a/src/app/generator.py +++ b/src/app/generator.py @@ -99,7 +99,7 @@ class ApiProvider: def __init__(self, apis: list[Api]) -> None: self._apis = apis - def get(self, name: str) -> Api: + def get(self, name: str) -> Api | None: for api in self._apis: if api.name == name: return api