From f5b33c78cb289b2d8263af8f4433077de72a05f1 Mon Sep 17 00:00:00 2001
From: inotia00 <108592928+inotia00@users.noreply.github.com>
Date: Thu, 27 Jun 2024 23:26:55 +0900
Subject: [PATCH] feat(YouTube/Settings): show AlertDialog when changing some
 settings value (matches ReVanced)

---
 .../resources/youtube/settings/host/values/strings.xml | 10 +++++++---
 .../resources/youtube/settings/xml/revanced_prefs.xml  |  2 +-
 2 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/src/main/resources/youtube/settings/host/values/strings.xml b/src/main/resources/youtube/settings/host/values/strings.xml
index edca5626e..3ac3d0d57 100644
--- a/src/main/resources/youtube/settings/host/values/strings.xml
+++ b/src/main/resources/youtube/settings/host/values/strings.xml
@@ -329,10 +329,13 @@ This does not bypass the age restriction. It just accepts it automatically."</st
     <string name="revanced_enable_tablet_layout_title">Enable tablet layout</string>
     <string name="revanced_enable_tablet_layout_summary">Spoofs the dpi to use some tablet layouts.</string>
     <string name="revanced_spoof_app_version_title">Spoof app version</string>
-    <string name="revanced_spoof_app_version_summary">"Spoofs the client version to an old version.
+    <string name="revanced_spoof_app_version_summary_on">Version spoofed</string>
+    <string name="revanced_spoof_app_version_summary_off">Version not spoofed</string>
+    <string name="revanced_spoof_app_version_user_dialog_message">"App version will be spoofed to an older version of YouTube.
 
-• This will change the appearance of the app, but unknown side effects may occur.
-• If later disabled, the old UI may remain until the app data is cleared."</string>
+This will change the appearance and features of the app, but unknown side effects may occur.
+
+If later turned off, it is recommended to clear the app data to prevent UI bugs."</string>
     <string name="revanced_spoof_app_version_target_title">Edit spoof app version</string>
     <string name="revanced_spoof_app_version_target_summary">Type the spoof app version target.</string>
     <string name="revanced_spoof_app_version_target_entry_title">Spoof app version target</string>
@@ -1523,6 +1526,7 @@ Limitation: Feed videos will play for less than 1 minute before encountering pla
     <string name="revanced_spoof_client_title">Spoof client</string>
     <string name="revanced_spoof_client_summary_on">Client is spoofed.</string>
     <string name="revanced_spoof_client_summary_off">"Client is not spoofed. Video playback may not work."</string>
+    <string name="revanced_spoof_client_user_dialog_message">Turning off this setting may cause video playback issues.</string>
     <string name="revanced_spoof_client_stats_for_nerds_title">Show in Stats for nerds</string>
     <string name="revanced_spoof_client_stats_for_nerds_summary_on">Spoofed client is shown in Stats for nerds.</string>
     <string name="revanced_spoof_client_stats_for_nerds_summary_off">Spoofed client is hidden in Stats for nerds.</string>
diff --git a/src/main/resources/youtube/settings/xml/revanced_prefs.xml b/src/main/resources/youtube/settings/xml/revanced_prefs.xml
index f3471000d..be034e9b8 100644
--- a/src/main/resources/youtube/settings/xml/revanced_prefs.xml
+++ b/src/main/resources/youtube/settings/xml/revanced_prefs.xml
@@ -220,7 +220,7 @@
         <SwitchPreference android:title="@string/revanced_enable_tablet_layout_title" android:key="revanced_enable_tablet_layout" android:summary="@string/revanced_enable_tablet_layout_summary" />SETTINGS: LAYOUT_SWITCH -->
 
         <!-- SETTINGS: SPOOF_APP_VERSION
-        <SwitchPreference android:title="@string/revanced_spoof_app_version_title" android:key="revanced_spoof_app_version" android:summary="@string/revanced_spoof_app_version_summary" />
+        <SwitchPreference android:title="@string/revanced_spoof_app_version_title" android:key="revanced_spoof_app_version" android:summaryOn="@string/revanced_spoof_app_version_summary_on" android:summaryOff="@string/revanced_spoof_app_version_summary_off" />
         <ListPreference android:title="@string/revanced_spoof_app_version_target_entry_title" android:key="revanced_spoof_app_version_target" android:entries="@array/revanced_spoof_app_version_target_entries" android:entryValues="@array/revanced_spoof_app_version_target_entry_values" />
         <app.revanced.integrations.shared.settings.preference.ResettableEditTextPreference android:hint="18.17.43" android:title="@string/revanced_spoof_app_version_target_title" android:key="revanced_spoof_app_version_target" android:summary="@string/revanced_spoof_app_version_target_summary" android:inputType="text" android:dependency="revanced_spoof_app_version" />SETTINGS: SPOOF_APP_VERSION -->