fix(YouTube - Overlay buttons): Overlay buttons do not disappear immediately when fullscreen button is clicked

extensions/shared/src/main/java/app/revanced/extension/youtube/patches/utils/PlayerControlsPatch.java

@@ -106,7 +106,7 @@ public class PlayerControlsPatch {
         }
     }
 
-    private static void changeVisibilityNegatedImmediately() {
+    public static void changeVisibilityNegatedImmediately() {
         // AlwaysRepeat.changeVisibilityNegatedImmediate();
         // CopyVideoUrl.changeVisibilityNegatedImmediate();
         // CopyVideoUrlTimestamp.changeVisibilityNegatedImmediate();

extensions/shared/src/main/java/app/revanced/extension/youtube/shared/BottomSheetState.kt

@@ -31,7 +31,7 @@ enum class BottomSheetState {
                 onChange(currentBottomSheetState)
             }
 
-        @Volatile // value is read/write from different threads
+        @Volatile // Read/write from different threads.
         private var currentBottomSheetState = CLOSED
 
         /**

extensions/shared/src/main/java/app/revanced/extension/youtube/shared/LockModeState.kt

@@ -40,7 +40,7 @@ enum class LockModeState {
                 onChange(value)
             }
 
-        @Volatile // value is read/write from different threads
+        @Volatile // Read/write from different threads.
         private var currentLockModeState = LOCK_MODE_STATE_ENUM_UNKNOWN
 
         /**

extensions/shared/src/main/java/app/revanced/extension/youtube/shared/PlayerControlsVisibility.kt

@@ -38,6 +38,7 @@ enum class PlayerControlsVisibility {
                 currentPlayerControlsVisibility = value
             }
 
+        @Volatile // Read/write from different threads.
         private var currentPlayerControlsVisibility: PlayerControlsVisibility? = null
     }
 }

extensions/shared/src/main/java/app/revanced/extension/youtube/shared/PlayerType.kt

@@ -71,7 +71,7 @@ enum class PlayerType {
                 onChange(value)
             }
 
-        @Volatile // value is read/write from different threads
+        @Volatile // Read/write from different threads.
         private var currentPlayerType = NONE
 
         /**

extensions/shared/src/main/java/app/revanced/extension/youtube/shared/ShortsPlayerState.kt

@@ -31,7 +31,7 @@ enum class ShortsPlayerState {
                 onChange(value)
             }
 
-        @Volatile // value is read/write from different threads
+        @Volatile // Read/write from different threads.
         private var currentShortsPlayerState = CLOSED
 
         /**

extensions/shared/src/main/java/app/revanced/extension/youtube/shared/VideoState.kt

@@ -39,6 +39,7 @@ enum class VideoState {
                 currentVideoState = value
             }
 
+        @Volatile // Read/write from different threads.
         private var currentVideoState: VideoState? = null
     }
 }

patches/src/main/kotlin/app/revanced/patches/youtube/utils/playercontrols/PlayerControlsPatch.kt

@@ -9,8 +9,11 @@ import app.revanced.patcher.patch.resourcePatch
 import app.revanced.patcher.util.proxy.mutableTypes.MutableMethod
 import app.revanced.patches.youtube.utils.extension.Constants.UTILS_PATH
 import app.revanced.patches.youtube.utils.extension.sharedExtensionPatch
+import app.revanced.patches.youtube.utils.fullscreen.enterFullscreenMethod
+import app.revanced.patches.youtube.utils.fullscreen.fullscreenButtonHookPatch
 import app.revanced.patches.youtube.utils.playerButtonsResourcesFingerprint
 import app.revanced.patches.youtube.utils.playerButtonsVisibilityFingerprint
+import app.revanced.patches.youtube.utils.playservice.is_19_23_or_greater
 import app.revanced.patches.youtube.utils.playservice.is_19_25_or_greater
 import app.revanced.patches.youtube.utils.playservice.versionCheckPatch
 import app.revanced.patches.youtube.utils.resourceid.sharedResourceIdPatch
@@ -46,6 +49,7 @@ private val playerControlsBytecodePatch = bytecodePatch(
         sharedExtensionPatch,
         sharedResourceIdPatch,
         versionCheckPatch,
+        fullscreenButtonHookPatch,
     )
 
     execute {
@@ -114,6 +118,18 @@ private val playerControlsBytecodePatch = bytecodePatch(
 
         // endregion
 
+        // region patch for fix buttons do not hide immediately when fullscreen button is clicked
+
+        // Reproduced only in RVX
+        if (is_19_23_or_greater) {
+            enterFullscreenMethod.addInstruction(
+                0,
+                "invoke-static {}, $EXTENSION_PLAYER_CONTROLS_CLASS_DESCRIPTOR->changeVisibilityNegatedImmediately()V"
+            )
+        }
+
+        // endregion
+
         // region patch initialize of overlay button or SponsorBlock button
 
         mapOf(