From f2436e3a6db17f1a3091402d78b798494c522bc5 Mon Sep 17 00:00:00 2001
From: inotia00 <ars258000@gmail.com>
Date: Fri, 17 Mar 2023 17:13:19 +0900
Subject: [PATCH] add `Show fullscreen title` settings

---
 .../fullscreenpanels/patch/HideFullscreenPanelsPatch.kt       | 4 ++--
 src/main/resources/youtube/settings/host/values/strings.xml   | 2 ++
 src/main/resources/youtube/settings/xml/revanced_prefs.xml    | 3 ++-
 3 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/src/main/kotlin/app/revanced/patches/youtube/layout/fullscreen/fullscreenpanels/patch/HideFullscreenPanelsPatch.kt b/src/main/kotlin/app/revanced/patches/youtube/layout/fullscreen/fullscreenpanels/patch/HideFullscreenPanelsPatch.kt
index fe0b34823..07cfe3c85 100644
--- a/src/main/kotlin/app/revanced/patches/youtube/layout/fullscreen/fullscreenpanels/patch/HideFullscreenPanelsPatch.kt
+++ b/src/main/kotlin/app/revanced/patches/youtube/layout/fullscreen/fullscreenpanels/patch/HideFullscreenPanelsPatch.kt
@@ -76,9 +76,9 @@ class HideFullscreenPanelsPatch : BytecodePatch(
 
             method.addInstructions(
                 invokeIndex, """
-                    invoke-static {}, $FULLSCREEN_LAYOUT->hideFullscreenPanel()Z
+                    invoke-static {}, $FULLSCREEN_LAYOUT->showFullscreenTitle()Z
                     move-result v$dummyRegister
-                    if-nez v$dummyRegister, :hidden
+                    if-eqz v$dummyRegister, :hidden
                 """, listOf(ExternalLabel("hidden", method.instruction(invokeIndex + 1)))
             )
         } ?: return LayoutConstructorFingerprint.toErrorResult()
diff --git a/src/main/resources/youtube/settings/host/values/strings.xml b/src/main/resources/youtube/settings/host/values/strings.xml
index 0974e10b5..a9da35aae 100644
--- a/src/main/resources/youtube/settings/host/values/strings.xml
+++ b/src/main/resources/youtube/settings/host/values/strings.xml
@@ -517,6 +517,8 @@ Since these setting is quite outdated, it may not be valid"</string>
     <string name="revanced_save_video_quality_wifi">Changing default Wi-Fi quality to:</string>
     <string name="revanced_save_video_speed">Changing default speed to:</string>
     <string name="revanced_seekbar_layout">Seekbar layout</string>
+    <string name="revanced_show_fullscreen_title_summary">Known issue: Title disappears when clicked</string>
+    <string name="revanced_show_fullscreen_title_title">Show fullscreen title</string>
     <string name="revanced_spoofing_type_general">Spoof to general video</string>
     <string name="revanced_spoofing_type_shorts">Spoof to shorts video</string>
     <string name="revanced_spoofing_type_title">Select protobuf to spoof</string>
diff --git a/src/main/resources/youtube/settings/xml/revanced_prefs.xml b/src/main/resources/youtube/settings/xml/revanced_prefs.xml
index b8f1effef..56adbb364 100644
--- a/src/main/resources/youtube/settings/xml/revanced_prefs.xml
+++ b/src/main/resources/youtube/settings/xml/revanced_prefs.xml
@@ -203,7 +203,8 @@
         <Preference android:title=" " android:selectable="false" android:summary="@string/revanced_fullscreen_layout" />PREFERENCE: FULLSCREEN_LAYOUT_SETTINGS -->
 
         <!-- SETTINGS: HIDE_FULLSCREEN_PANELS
-        <SwitchPreference android:title="@string/revanced_hide_fullscreen_panels_title" android:key="revanced_hide_fullscreen_panels" android:defaultValue="false" android:summaryOn="@string/revanced_hide_fullscreen_panels_summary_on" android:summaryOff="@string/revanced_hide_fullscreen_panels_summary_off" />SETTINGS: HIDE_FULLSCREEN_PANELS -->
+        <SwitchPreference android:title="@string/revanced_hide_fullscreen_panels_title" android:key="revanced_hide_fullscreen_panels" android:defaultValue="false" android:summaryOn="@string/revanced_hide_fullscreen_panels_summary_on" android:summaryOff="@string/revanced_hide_fullscreen_panels_summary_off" />
+        <SwitchPreference android:title="@string/revanced_show_fullscreen_title_title" android:key="revanced_show_fullscreen_title" android:defaultValue="true" android:summary="@string/revanced_show_fullscreen_title_summary" android:dependency="revanced_hide_fullscreen_panels" />SETTINGS: HIDE_FULLSCREEN_PANELS -->
 
         <!-- SETTINGS: HIDE_FULLSCREEN_BUTTON_CONTAINER
         <SwitchPreference android:title="@string/revanced_hide_fullscreen_button_container_title" android:key="revanced_hide_fullscreen_button_container" android:defaultValue="false" android:summaryOn="@string/revanced_hide_fullscreen_button_container_summary_on" android:summaryOff="@string/revanced_hide_fullscreen_button_container_summary_off" />SETTINGS: HIDE_FULLSCREEN_BUTTON_CONTAINER -->