diff --git a/extensions/shared/src/main/java/app/revanced/extension/music/patches/misc/AlbumMusicVideoPatch.java b/extensions/shared/src/main/java/app/revanced/extension/music/patches/misc/AlbumMusicVideoPatch.java index 08fca8a31..b6489c720 100644 --- a/extensions/shared/src/main/java/app/revanced/extension/music/patches/misc/AlbumMusicVideoPatch.java +++ b/extensions/shared/src/main/java/app/revanced/extension/music/patches/misc/AlbumMusicVideoPatch.java @@ -19,18 +19,9 @@ import app.revanced.extension.shared.utils.Logger; public class AlbumMusicVideoPatch { public enum RedirectType { - REDIRECT_DISMISS(true), - REDIRECT(false), - ON_CLICK_DISMISS(true), - ON_CLICK(false), - ON_LONG_CLICK_DISMISS(true), - ON_LONG_CLICK(false); - - public final boolean dismissQueue; - - RedirectType(boolean dismissQueue) { - this.dismissQueue = dismissQueue; - } + REDIRECT, + ON_CLICK, + ON_LONG_CLICK } private static final RedirectType REDIRECT_TYPE = @@ -39,17 +30,11 @@ public class AlbumMusicVideoPatch { private static final boolean DISABLE_MUSIC_VIDEO_IN_ALBUM = Settings.DISABLE_MUSIC_VIDEO_IN_ALBUM.get(); - private static final boolean DISMISS_QUEUE = - DISABLE_MUSIC_VIDEO_IN_ALBUM && REDIRECT_TYPE.dismissQueue; + private static final boolean REDIRECT = REDIRECT_TYPE == RedirectType.REDIRECT; - private static final boolean REDIRECT = - REDIRECT_TYPE == RedirectType.REDIRECT || REDIRECT_TYPE == RedirectType.REDIRECT_DISMISS; + private static final boolean ON_CLICK = REDIRECT_TYPE == RedirectType.ON_CLICK; - private static final boolean ON_CLICK = - REDIRECT_TYPE == RedirectType.ON_CLICK || REDIRECT_TYPE == RedirectType.ON_CLICK_DISMISS; - - private static final boolean ON_LONG_CLICK = - REDIRECT_TYPE == RedirectType.ON_LONG_CLICK || REDIRECT_TYPE == RedirectType.ON_LONG_CLICK_DISMISS; + private static final boolean ON_LONG_CLICK = REDIRECT_TYPE == RedirectType.ON_LONG_CLICK; private static final String YOUTUBE_MUSIC_ALBUM_PREFIX = "OLAK"; @@ -63,7 +48,7 @@ public class AlbumMusicVideoPatch { @GuardedBy("itself") private static final Map lastVideoIds = new LinkedHashMap<>() { - private static final int NUMBER_OF_LAST_VIDEO_IDS_TO_TRACK = 5; + private static final int NUMBER_OF_LAST_VIDEO_IDS_TO_TRACK = 10; @Override protected boolean removeEldestEntry(Map.Entry eldest) { @@ -153,10 +138,6 @@ public class AlbumMusicVideoPatch { private static void openMusic(@NonNull String songId) { try { - if (DISMISS_QUEUE) { - VideoUtils.dismissQueue(); - } - isVideoLaunched.compareAndSet(false, true); // The newly opened video is not a music video. diff --git a/extensions/shared/src/main/java/app/revanced/extension/music/settings/Settings.java b/extensions/shared/src/main/java/app/revanced/extension/music/settings/Settings.java index f2638e371..75c636200 100644 --- a/extensions/shared/src/main/java/app/revanced/extension/music/settings/Settings.java +++ b/extensions/shared/src/main/java/app/revanced/extension/music/settings/Settings.java @@ -180,7 +180,7 @@ public class Settings extends BaseSettings { public static final BooleanSetting DISABLE_CAIRO_SPLASH_ANIMATION = new BooleanSetting("revanced_disable_cairo_splash_animation", FALSE, true); public static final BooleanSetting DISABLE_DRC_AUDIO = new BooleanSetting("revanced_disable_drc_audio", FALSE, true); public static final BooleanSetting DISABLE_MUSIC_VIDEO_IN_ALBUM = new BooleanSetting("revanced_disable_music_video_in_album", FALSE, true); - public static final EnumSetting DISABLE_MUSIC_VIDEO_IN_ALBUM_REDIRECT_TYPE = new EnumSetting<>("revanced_disable_music_video_in_album_redirect_type", RedirectType.REDIRECT_DISMISS, true); + public static final EnumSetting DISABLE_MUSIC_VIDEO_IN_ALBUM_REDIRECT_TYPE = new EnumSetting<>("revanced_disable_music_video_in_album_redirect_type", RedirectType.REDIRECT, true); public static final BooleanSetting ENABLE_OPUS_CODEC = new BooleanSetting("revanced_enable_opus_codec", FALSE, true); public static final BooleanSetting SETTINGS_IMPORT_EXPORT = new BooleanSetting("revanced_extended_settings_import_export", FALSE, false); public static final BooleanSetting SPOOF_CLIENT = new BooleanSetting("revanced_spoof_client", FALSE, true); diff --git a/patches/src/main/kotlin/app/revanced/patches/music/misc/album/AlbumMusicVideoPatch.kt b/patches/src/main/kotlin/app/revanced/patches/music/misc/album/AlbumMusicVideoPatch.kt index 1479cc65f..e24c51738 100644 --- a/patches/src/main/kotlin/app/revanced/patches/music/misc/album/AlbumMusicVideoPatch.kt +++ b/patches/src/main/kotlin/app/revanced/patches/music/misc/album/AlbumMusicVideoPatch.kt @@ -5,7 +5,6 @@ import app.revanced.patcher.extensions.InstructionExtensions.addInstructionsWith import app.revanced.patcher.extensions.InstructionExtensions.getInstruction import app.revanced.patcher.patch.bytecodePatch import app.revanced.patches.music.utils.compatibility.Constants.COMPATIBLE_PACKAGE -import app.revanced.patches.music.utils.dismiss.dismissQueueHookPatch import app.revanced.patches.music.utils.extension.Constants.MISC_PATH import app.revanced.patches.music.utils.patch.PatchList.DISABLE_MUSIC_VIDEO_IN_ALBUM import app.revanced.patches.music.utils.settings.CategoryType @@ -39,7 +38,6 @@ val albumMusicVideoPatch = bytecodePatch( dependsOn( settingsPatch, - dismissQueueHookPatch, videoInformationPatch, playerResponseMethodHookPatch, ) diff --git a/patches/src/main/resources/music/settings/host/values/arrays.xml b/patches/src/main/resources/music/settings/host/values/arrays.xml index 97897dac9..c1adaccde 100644 --- a/patches/src/main/resources/music/settings/host/values/arrays.xml +++ b/patches/src/main/resources/music/settings/host/values/arrays.xml @@ -15,19 +15,13 @@ FEmusic_library_corpus_artists - @string/revanced_disable_music_video_in_album_redirect_type_entry_redirect_dismiss @string/revanced_disable_music_video_in_album_redirect_type_entry_redirect - @string/revanced_disable_music_video_in_album_redirect_type_entry_on_click_dismiss @string/revanced_disable_music_video_in_album_redirect_type_entry_on_click - @string/revanced_disable_music_video_in_album_redirect_type_entry_on_long_click_dismiss @string/revanced_disable_music_video_in_album_redirect_type_entry_on_long_click - REDIRECT_DISMISS REDIRECT - ON_CLICK_DISMISS ON_CLICK - ON_LONG_CLICK_DISMISS ON_LONG_CLICK diff --git a/patches/src/main/resources/music/settings/host/values/strings.xml b/patches/src/main/resources/music/settings/host/values/strings.xml index e93faecae..c3479c6a5 100644 --- a/patches/src/main/resources/music/settings/host/values/strings.xml +++ b/patches/src/main/resources/music/settings/host/values/strings.xml @@ -428,11 +428,8 @@ Find the official song if a music video is detected playing from an album. • Powered by Piped Instance API." Redirection type Specifies how to redirect to official song. - Redirect (Dismiss queue) Redirect - Tap Audio / Video toggle (Dismiss queue) Tap Audio / Video toggle - Tap and hold Audio / Video toggle (Dismiss queue) Tap and hold Audio / Video toggle Enable debug logging Prints the debug log.