ReVanced/revanced-patches-ex
1
0
Fork 0
mirror of https://github.com/inotia00/revanced-patches.git synced 2025-06-12 21:27:43 +02:00
Code Issues Packages Projects Releases Wiki Activity

feat: apply code review suggestions

Browse Source
This commit is contained in:
inotia00
2024-08-06 11:50:56 +09:00
parent d647061d94
commit ec85abc1c7
14 changed files with 265 additions and 255 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/main/resources/youtube/settings/host/values/arrays.xml
View File

@ -94,22 +94,28 @@
<item>1440</item>
<item>2160</item>
</string-array>
<string-array name="revanced_external_downloader_label">
<string-array name="revanced_external_downloader_video_label">
<item>NewPipe</item>
<item>Seal</item>
<item>Tubular</item>
<item>YTDLnis</item>
</string-array>
<string-array name="revanced_external_downloader_package_name">
<string-array name="revanced_external_downloader_video_package_name">
<item>org.schabi.newpipe</item>
<item>com.junkfood.seal</item>
<item>org.polymorphicshade.tubular</item>
<item>com.deniscerri.ytdl</item>
</string-array>
<string-array name="revanced_external_downloader_website">
<item>https://github.com/TeamNewPipe/NewPipe/releases/latest</item>
<item>https://github.com/JunkFood02/Seal/releases/latest</item>
<item>https://github.com/polymorphicshade/Tubular/releases/latest</item>
<string-array name="revanced_external_downloader_video_website">
<item>https://github.com/deniscerri/ytdlnis/releases/latest</item>
</string-array>
<string-array name="revanced_external_downloader_playlist_label">
<item>YTDLnis</item>
</string-array>
<string-array name="revanced_external_downloader_playlist_package_name">
<item>com.deniscerri.ytdl</item>
</string-array>
<string-array name="revanced_external_downloader_playlist_website">
<item>https://github.com/deniscerri/ytdlnis/releases/latest</item>
</string-array>
<string-array name="revanced_miniplayer_type_19_15_entries">

38
src/main/resources/youtube/settings/host/values/strings.xml
View File

@ -4,17 +4,24 @@
<string name="accessibility_settings_edu_opt_in_text">Enable accessibility controls for the video player?</string>
<string name="accessibility_settings_edu_opt_out_text">Your controls are modified because an accessibility service is on.</string>
<!-- Shared PreferenceScreen -->
<!-- Shared -->
<string name="revanced_extended_settings_title">ReVanced Extended</string>
<string name="revanced_extended_settings_search_title">Search %s</string>
<!-- Shared Category -->
<string name="revanced_preference_category_experimental_flag">Experimental Flags</string>
<string name="revanced_extended_confirm_user_dialog_title">Do you wish to proceed?</string>
<string name="revanced_extended_restart_first_run">Restart to load the layout normally</string>
<string name="revanced_extended_restart_message">Refresh and restart</string>
<string name="revanced_playback_speed_normal">Normal</string>
<string name="revanced_external_downloader_package_name_video_title">Video downloader package name</string>
<string name="revanced_external_downloader_package_name_video_summary">Package name of your installed external downloader app, such as NewPipe or YTDLnis.</string>
<string name="revanced_external_downloader_dialog_title">External downloader</string>
<string name="revanced_external_downloader_not_installed_dialog_title">Warning</string>
<string name="revanced_external_downloader_not_installed_dialog_message">"%1$s is not installed.
Please download %2$s from the website."</string>
<string name="revanced_external_downloader_not_installed_warning">%s is not installed. Please install it.</string>
<!-- PreferenceScreen: Ads -->
<string name="revanced_preference_screen_ads_title">Ads</string>
@ -334,6 +341,16 @@ This does not bypass the age restriction. It just accepts it automatically."</st
<string name="revanced_enable_phone_layout_summary">Spoofs the dpi to use some phone layouts.</string>
<string name="revanced_enable_tablet_layout_title">Enable tablet layout</string>
<string name="revanced_enable_tablet_layout_summary">Spoofs the dpi to use some tablet layouts.</string>
<string name="revanced_override_video_download_button_title">Override video download button</string>
<string name="revanced_override_video_download_button_summary_on">Native video download button opens your external downloader.</string>
<string name="revanced_override_video_download_button_summary_off">Native video download button opens the native in-app downloader.</string>
<string name="revanced_override_playlist_download_button_title">Override playlist download button</string>
<string name="revanced_override_playlist_download_button_summary_on">Native playlist download button opens your external downloader.</string>
<string name="revanced_override_playlist_download_button_summary_off">Native playlist download button opens the native in-app downloader.</string>
<string name="revanced_external_downloader_package_name_playlist_title">Playlist downloader package name</string>
<string name="revanced_external_downloader_package_name_playlist_summary">Package name of your installed external downloader app, such as YTDLnis.</string>
<string name="revanced_spoof_app_version_title">Spoof app version</string>
<string name="revanced_spoof_app_version_summary_on">Version spoofed</string>
<string name="revanced_spoof_app_version_summary_off">Version not spoofed</string>
@ -505,9 +522,6 @@ You tab → View channel → Menu → Settings"</string>
Tap and hold to open YouTube settings."</string>
<string name="revanced_replace_toolbar_create_button_type_summary_off">"Tap to open YouTube settings.
Tap and hold to open RVX settings."</string>
<string name="revanced_hook_playlist_download_button_title">Override playlist download action</string>
<string name="revanced_hook_playlist_download_button_summary_off">Playlist download will behave like the original, and button might not appear.</string>
<string name="revanced_hook_playlist_download_button_summary_on">Playlist download button will be present, and the download will be handled by YTDLnis.</string>
<!-- PreferenceScreen: Player -->
@ -900,20 +914,6 @@ Tap and hold to undo."</string>
<string name="revanced_whitelist_sponsor_block">SponsorBlock</string>
<string name="revanced_whitelist_failure_generic">Failed to load channel information.</string>
<string name="revanced_external_downloader_package_name_title">External downloader package name</string>
<string name="revanced_external_downloader_package_name_summary">Package name of your installed external downloader app, such as NewPipe or YTDLnis.</string>
<string name="revanced_external_downloader_dialog_title">External downloader</string>
<string name="revanced_playlist_external_downloader_package_name_title">Playlist external downloader package name</string>
<string name="revanced_playlist_external_downloader_package_name_summary">Package name of your installed external downloader app used to download from playlists, currently only YTDLnis works.</string>
<string name="revanced_playlist_external_downloader_dialog_title">Playlist external downloader</string>
<string name="revanced_external_downloader_not_installed_dialog_title">Warning</string>
<string name="revanced_external_downloader_not_installed_dialog_message">"%1$s is not installed.
Please download %2$s from the website."</string>
<string name="revanced_external_downloader_not_installed_warning">%s is not installed. Please install it.</string>
<string name="revanced_external_downloader_action_title">Override download action button</string>
<string name="revanced_external_downloader_action_summary_on">Native download button opens your external downloader.</string>
<string name="revanced_external_downloader_action_summary_off">Native download button opens the native in-app downloader.</string>
<string name="revanced_overlay_button_speed_dialog_reset">Playback speed reset: %sx.</string>
<string name="revanced_overlay_button_not_allowed_warning">Tap and hold to change button state.</string>
<string name="revanced_share_copy_timestamp_success">Timestamp copied to clipboard. (%s)</string>

13
src/main/resources/youtube/settings/xml/revanced_prefs.xml
View File

@ -231,9 +231,10 @@
<SwitchPreference android:title="@string/revanced_enable_tablet_layout_title" android:key="revanced_enable_tablet_layout" android:summary="@string/revanced_enable_tablet_layout_summary" />SETTINGS: LAYOUT_SWITCH -->
<!-- SETTINGS: HOOK_DOWNLOAD_ACTIONS
<SwitchPreference android:title="@string/revanced_hook_playlist_download_button_title" android:key="revanced_hook_playlist_download_button" android:defaultValue="true" android:summaryOn="@string/revanced_hook_playlist_download_button_summary_on" android:summaryOff="@string/revanced_hook_playlist_download_button_summary_off"/>
<SwitchPreference android:title="@string/revanced_external_downloader_action_title" android:key="revanced_external_downloader_action" android:defaultValue="false" android:summaryOn="@string/revanced_external_downloader_action_summary_on" android:summaryOff="@string/revanced_external_downloader_action_summary_off" />
<app.revanced.integrations.youtube.settings.preference.ExternalPlaylistDownloaderPreference android:title="@string/revanced_playlist_external_downloader_package_name_title" android:key="revanced_playlist_external_downloader_package_name" android:summary="@string/revanced_playlist_external_downloader_package_name_summary" />SETTINGS: HOOK_DOWNLOAD_ACTIONS -->
<SwitchPreference android:title="@string/revanced_override_video_download_button_title" android:key="revanced_override_video_download_button" android:summaryOn="@string/revanced_override_video_download_button_summary_on" android:summaryOff="@string/revanced_override_video_download_button_summary_off" />
<SwitchPreference android:title="@string/revanced_override_playlist_download_button_title" android:key="revanced_override_playlist_download_button" android:summaryOn="@string/revanced_override_playlist_download_button_summary_on" android:summaryOff="@string/revanced_override_playlist_download_button_summary_off" />
<app.revanced.integrations.youtube.settings.preference.ExternalDownloaderVideoPreference android:title="@string/revanced_external_downloader_package_name_video_title" android:key="revanced_external_downloader_package_name_video" android:summary="@string/revanced_external_downloader_package_name_video_summary" />
<app.revanced.integrations.youtube.settings.preference.ExternalDownloaderPlaylistPreference android:title="@string/revanced_external_downloader_package_name_playlist_title" android:key="revanced_external_downloader_package_name_playlist" android:summary="@string/revanced_external_downloader_package_name_playlist_summary" />SETTINGS: HOOK_DOWNLOAD_ACTIONS -->
<!-- SETTINGS: SPOOF_APP_VERSION
<SwitchPreference android:title="@string/revanced_spoof_app_version_title" android:key="revanced_spoof_app_version" android:summaryOn="@string/revanced_spoof_app_version_summary_on" android:summaryOff="@string/revanced_spoof_app_version_summary_off" />
@ -386,9 +387,8 @@
<SwitchPreference android:title="@string/revanced_overlay_button_speed_dialog_title" android:key="revanced_overlay_button_speed_dialog" android:summary="@string/revanced_overlay_button_speed_dialog_summary" />
<SwitchPreference android:title="@string/revanced_overlay_button_time_ordered_playlist_title" android:key="revanced_overlay_button_time_ordered_playlist" android:summary="@string/revanced_overlay_button_time_ordered_playlist_summary" />
<SwitchPreference android:title="@string/revanced_overlay_button_whitelist_title" android:key="revanced_overlay_button_whitelist" android:summary="@string/revanced_overlay_button_whitelist_summary" />
<app.revanced.integrations.youtube.settings.preference.ExternalDownloaderPreference android:title="@string/revanced_external_downloader_package_name_title" android:key="revanced_external_downloader_package_name" android:summary="@string/revanced_external_downloader_package_name_summary" />
<app.revanced.integrations.youtube.settings.preference.WhitelistedChannelsPreference android:title="@string/revanced_whitelist_settings_title" android:key="revanced_whitelist_settings" android:summary="@string/revanced_whitelist_settings_summary" />
<PreferenceCategory android:title="@string/revanced_preference_category_experimental_flag" android:layout="@layout/revanced_settings_preferences_category" />SETTINGS: OVERLAY_BUTTONS -->
<app.revanced.integrations.youtube.settings.preference.ExternalDownloaderVideoPreference android:title="@string/revanced_external_downloader_package_name_video_title" android:key="revanced_external_downloader_package_name_video" android:summary="@string/revanced_external_downloader_package_name_video_summary" />
<app.revanced.integrations.youtube.settings.preference.WhitelistedChannelsPreference android:title="@string/revanced_whitelist_settings_title" android:key="revanced_whitelist_settings" android:summary="@string/revanced_whitelist_settings_summary" />SETTINGS: OVERLAY_BUTTONS -->
<!-- PREFERENCE_SCREENS: PLAYER_BUTTONS
</PreferenceScreen>PREFERENCE_SCREENS: PLAYER_BUTTONS -->
@ -695,6 +695,7 @@
<Preference android:title="Disable splash animation" android:summary="@string/revanced_patches_excluded" android:selectable="false"/>
<Preference android:title="Enable gradient loading screen" android:summary="@string/revanced_patches_excluded" android:selectable="false"/>
<Preference android:title="Hide layout components" android:summary="@string/revanced_patches_excluded" android:selectable="false"/>
<Preference android:title="Hook download actions" android:summary="@string/revanced_patches_excluded" android:selectable="false"/>
<Preference android:title="Layout switch" android:summary="@string/revanced_patches_excluded" android:selectable="false"/>
<Preference android:title="Miniplayer" android:summary="@string/revanced_patches_excluded" android:selectable="false"/>
<Preference android:title="Navigation bar components" android:summary="@string/revanced_patches_excluded" android:selectable="false"/>