From e74bc28d2b7ca3c4794dfa73d39fac8b7549fa0c Mon Sep 17 00:00:00 2001
From: inotia00 <108592928+inotia00@users.noreply.github.com>
Date: Thu, 9 May 2024 01:01:16 +0900
Subject: [PATCH] feat(YouTube/Seekbar components): add log indicating that
 `Restore old seekbar thumbnails` setting is deprecated in YouTube v19.17.41+

---
 .../player/seekbar/SeekbarComponentsPatch.kt  | 21 +++++++++++++++----
 .../youtube/settings/xml/revanced_prefs.xml   |  6 ++++--
 2 files changed, 21 insertions(+), 6 deletions(-)

diff --git a/src/main/kotlin/app/revanced/patches/youtube/player/seekbar/SeekbarComponentsPatch.kt b/src/main/kotlin/app/revanced/patches/youtube/player/seekbar/SeekbarComponentsPatch.kt
index 428166042..b1917ade3 100644
--- a/src/main/kotlin/app/revanced/patches/youtube/player/seekbar/SeekbarComponentsPatch.kt
+++ b/src/main/kotlin/app/revanced/patches/youtube/player/seekbar/SeekbarComponentsPatch.kt
@@ -258,10 +258,23 @@ object SeekbarComponentsPatch : BaseBytecodePatch(
 
         // region patch for restore old seekbar thumbnails
 
-        ThumbnailPreviewConfigFingerprint.literalInstructionBooleanHook(
-            45398577,
-            "$PLAYER_CLASS_DESCRIPTOR->restoreOldSeekbarThumbnails()Z"
-        )
+        ThumbnailPreviewConfigFingerprint.result?.let {
+            ThumbnailPreviewConfigFingerprint.literalInstructionBooleanHook(
+                45398577,
+                "$PLAYER_CLASS_DESCRIPTOR->restoreOldSeekbarThumbnails()Z"
+            )
+
+            /**
+             * Add settings
+             */
+            SettingsPatch.addPreference(
+                arrayOf(
+                    "PREFERENCE_SCREEN: PLAYER",
+                    "SETTINGS: SEEKBAR_COMPONENTS",
+                    "SETTINGS: RESTORE_OLD_SEEKBAR_THUMBNAILS"
+                )
+            )
+        } ?: println("WARNING: Restore old seekbar thumbnails setting is not supported in this version. Use YouTube 19.16.39 or earlier.")
 
         // endregion
 
diff --git a/src/main/resources/youtube/settings/xml/revanced_prefs.xml b/src/main/resources/youtube/settings/xml/revanced_prefs.xml
index 7715c7172..323dbd2ad 100644
--- a/src/main/resources/youtube/settings/xml/revanced_prefs.xml
+++ b/src/main/resources/youtube/settings/xml/revanced_prefs.xml
@@ -355,8 +355,10 @@
             <SwitchPreference android:title="@string/revanced_hide_seekbar_title" android:key="revanced_hide_seekbar" android:defaultValue="false" android:summaryOn="@string/revanced_hide_seekbar_summary_on" android:summaryOff="@string/revanced_hide_seekbar_summary_off" />
             <SwitchPreference android:title="@string/revanced_hide_seekbar_thumbnail_title" android:key="revanced_hide_seekbar_thumbnail" android:defaultValue="false" android:summaryOn="@string/revanced_hide_seekbar_thumbnail_summary_on" android:summaryOff="@string/revanced_hide_seekbar_thumbnail_summary_off" />
             <SwitchPreference android:title="@string/revanced_hide_seekbar_chapters_title" android:key="revanced_hide_seekbar_chapters" android:defaultValue="false" android:summaryOn="@string/revanced_hide_seekbar_chapters_summary_on" android:summaryOff="@string/revanced_hide_seekbar_chapters_summary_off" />
-            <SwitchPreference android:title="@string/revanced_hide_time_stamp_title" android:key="revanced_hide_time_stamp" android:defaultValue="false" android:summaryOn="@string/revanced_hide_time_stamp_summary_on" android:summaryOff="@string/revanced_hide_time_stamp_summary_off" />
-            <SwitchPreference android:title="@string/revanced_restore_old_seekbar_thumbnails_title" android:key="revanced_restore_old_seekbar_thumbnails" android:defaultValue="true" android:summaryOn="@string/revanced_restore_old_seekbar_thumbnails_summary_on" android:summaryOff="@string/revanced_restore_old_seekbar_thumbnails_summary_off" />
+            <SwitchPreference android:title="@string/revanced_hide_time_stamp_title" android:key="revanced_hide_time_stamp" android:defaultValue="false" android:summaryOn="@string/revanced_hide_time_stamp_summary_on" android:summaryOff="@string/revanced_hide_time_stamp_summary_off" />SETTINGS: SEEKBAR_COMPONENTS -->
+            <!-- SETTINGS: RESTORE_OLD_SEEKBAR_THUMBNAILS
+            <SwitchPreference android:title="@string/revanced_restore_old_seekbar_thumbnails_title" android:key="revanced_restore_old_seekbar_thumbnails" android:defaultValue="true" android:summaryOn="@string/revanced_restore_old_seekbar_thumbnails_summary_on" android:summaryOff="@string/revanced_restore_old_seekbar_thumbnails_summary_off" />SETTINGS: RESTORE_OLD_SEEKBAR_THUMBNAILS -->
+        <!-- SETTINGS: SEEKBAR_COMPONENTS
         </PreferenceScreen>SETTINGS: SEEKBAR_COMPONENTS -->
 
         <!-- SETTINGS: DESCRIPTION_COMPONENTS