From dde487258df5572f87c102bfd3a3bd6c9bd34a9e Mon Sep 17 00:00:00 2001 From: inotia00 Date: Thu, 20 Apr 2023 07:42:00 +0900 Subject: [PATCH] feat(sponsorblock): skip to video highlight --- .../youtube/settings/host/values/strings.xml | 8 ++++- .../layout/inline_sponsor_overlay.xml | 32 +++++++++++++------ .../layout/skip_sponsor_button.xml | 1 - 3 files changed, 29 insertions(+), 12 deletions(-) diff --git a/src/main/resources/youtube/settings/host/values/strings.xml b/src/main/resources/youtube/settings/host/values/strings.xml index f40359f54..3965520bc 100644 --- a/src/main/resources/youtube/settings/host/values/strings.xml +++ b/src/main/resources/youtube/settings/host/values/strings.xml @@ -573,6 +573,8 @@ Since these setting is quite outdated, it may not be valid" Similar to \'Sponsor\' except for unpaid or self promotion. Includes sections about merchandise, donations, or information about who they collaborated with Interaction Reminder (Subscribe) A short reminder to like, subscribe or follow them in the middle of content. If it is long or about something specific, it should instead be under self promotion + Highlight + The part of the video that most people are looking for Intermission/Intro Animation An interval without actual content. Could be a pause, static frame, or repeating animation. Does not include transitions containing information Endcards/Credits @@ -585,9 +587,11 @@ Since these setting is quite outdated, it may not be valid" Only for use in music videos. Sections of music videos without music, that aren\'t already covered by another category Skip + Highlight Skip sponsor Skip promo Skip interact + Skip to highlight Skip intro Skip outro Skip preview @@ -598,6 +602,7 @@ Since these setting is quite outdated, it may not be valid" Skipped sponsor Skipped self promotion Skipped annoying reminder + Skipped to highlight Skipped intro Skipped outro Skipped preview @@ -633,7 +638,7 @@ Since these setting is quite outdated, it may not be valid" Choose the segment category Category is disabled in settings. Enable category to submit. New SponsorBlock segment - Set %02d:%02d:%04d as the start or end of a new segment? + Set %02d:%02d:%03d as the start or end of a new segment? start end now @@ -641,6 +646,7 @@ Since these setting is quite outdated, it may not be valid" Time the segment ends at Are the times correct? The segment lasts from %02d:%02d to %02d:%02d (%d minutes %02d seconds)\nIs it ready to submit? + Start must be before the end Mark two locations on the time bar first Preview the segment, and ensure it skips smoothly Edit timing of segment manually diff --git a/src/main/resources/youtube/sponsorblock/layout/inline_sponsor_overlay.xml b/src/main/resources/youtube/sponsorblock/layout/inline_sponsor_overlay.xml index 9f4221735..2c0385549 100644 --- a/src/main/resources/youtube/sponsorblock/layout/inline_sponsor_overlay.xml +++ b/src/main/resources/youtube/sponsorblock/layout/inline_sponsor_overlay.xml @@ -1,6 +1,28 @@ + + + + - - \ No newline at end of file diff --git a/src/main/resources/youtube/sponsorblock/layout/skip_sponsor_button.xml b/src/main/resources/youtube/sponsorblock/layout/skip_sponsor_button.xml index 3a3167bb8..185960ec9 100644 --- a/src/main/resources/youtube/sponsorblock/layout/skip_sponsor_button.xml +++ b/src/main/resources/youtube/sponsorblock/layout/skip_sponsor_button.xml @@ -7,7 +7,6 @@ android:layout_width="wrap_content" android:layout_height="32dp" android:layout_gravity="center_vertical" - android:contentDescription="@string/sb_skip_button_compact" android:orientation="horizontal" android:padding="8dp">