ReVanced/revanced-patches-ex
1
0
Fork 0
mirror of https://github.com/inotia00/revanced-patches.git synced 2025-04-29 22:24:31 +02:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Improve XML performance (#139)

Browse Source
This commit is contained in:
kitadai31 2025-02-12 09:54:06 +09:00 committed by GitHub
parent fae60e63df
commit 325b43e394
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
7 changed files with 58 additions and 52 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
patches/src/main/kotlin/app/revanced/patches/music/layout/theme/DarkThemePatch.kt
View File

@ -112,10 +112,11 @@ val darkThemePatch = resourcePatch(
.valueOrThrow()
document("res/values/colors.xml").use { document ->
val resourcesNode = document.getElementsByTagName("resources").item(0) as Element
val resourcesNode = document.documentElement
val childNodes = resourcesNode.childNodes
for (i in 0 until resourcesNode.childNodes.length) {
val node = resourcesNode.childNodes.item(i) as? Element ?: continue
for (i in 0 until childNodes.length) {
val node = childNodes.item(i) as? Element ?: continue
val colorName = node.getAttribute("name")
if (DARK_COLOR.contains(colorName)) {

5
patches/src/main/kotlin/app/revanced/patches/shared/materialyou/BaseMaterialYouPatch.kt
View File

@ -37,8 +37,9 @@ private fun ResourcePatchContext.patchXmlFile(
val parentList = document.getElementsByTagName(parentNode).item(0) as Element
if (targetNode != null) {
for (i in 0 until parentList.childNodes.length) {
val node = parentList.childNodes.item(i) as? Element ?: continue
val childNodes = parentList.childNodes
for (i in 0 until childNodes.length) {
val node = childNodes.item(i) as? Element ?: continue
if (node.nodeName == targetNode && node.hasAttribute(attribute)) {
node.getAttributeNode(attribute).textContent = newValue

47
patches/src/main/kotlin/app/revanced/patches/shared/translations/BaseTranslationsPatch.kt
View File

@ -123,36 +123,35 @@ fun ResourcePatchContext.baseTranslationsPatch(
}.toHashSet().toTypedArray()
// Remove unselected app languages from RVX Settings
setOf(
"revanced_language_entries",
"revanced_language_entry_values",
).forEach { attributeName ->
document("res/values/arrays.xml").use { document ->
with(document) {
val nodesToRemove = mutableListOf<Node>()
document("res/values/arrays.xml").use { document ->
val targetAttributeNames = setOf(
"revanced_language_entries",
"revanced_language_entry_values",
)
val nodesToRemove = mutableListOf<Node>()
val resourcesNode = getElementsByTagName("resources").item(0) as Element
for (i in 0 until resourcesNode.childNodes.length) {
val node = resourcesNode.childNodes.item(i) as? Element ?: continue
val resourcesNode = document.documentElement
val childNodes = resourcesNode.childNodes
for (i in 0 until childNodes.length) {
val node = childNodes.item(i) as? Element ?: continue
if (node.getAttribute("name") == attributeName) {
for (j in 0 until node.childNodes.length) {
val item = node.childNodes.item(j) as? Element ?: continue
val text = item.textContent
val length = text.length
if (!text.endsWith("DEFAULT") && text.subSequence(length - 2, length) !in filteredAppLanguages) {
nodesToRemove.add(item)
}
}
if (node.getAttribute("name") in targetAttributeNames) {
val itemNodes = node.childNodes
for (j in 0 until itemNodes.length) {
val item = itemNodes.item(j) as? Element ?: continue
val text = item.textContent
val length = text.length
if (!text.endsWith("DEFAULT") && text.subSequence(length - 2, length) !in filteredAppLanguages) {
nodesToRemove.add(item)
}
}
// Remove the collected nodes (avoids NullPointerException)
for (n in nodesToRemove) {
n.parentNode?.removeChild(n)
}
}
}
// Remove the collected nodes (avoids NullPointerException)
for (n in nodesToRemove) {
n.parentNode?.removeChild(n)
}
}
}

8
patches/src/main/kotlin/app/revanced/patches/youtube/general/snackbar/SnackBarComponentsPatch.kt
View File

@ -348,14 +348,16 @@ val snackBarComponentsPatch = resourcePatch(
}
document("res/values/dimens.xml").use { document ->
val resourcesNode = document.getElementsByTagName("resources").item(0) as Element
val resourcesNode = document.documentElement
val childNodes = resourcesNode.childNodes
for (i in 0 until resourcesNode.childNodes.length) {
val node = resourcesNode.childNodes.item(i) as? Element ?: continue
for (i in 0 until childNodes.length) {
val node = childNodes.item(i) as? Element ?: continue
val dimenName = node.getAttribute("name")
if (dimenName.equals("snackbar_corner_radius")) {
node.textContent = cornerRadius
break
}
}
}

7
patches/src/main/kotlin/app/revanced/patches/youtube/layout/theme/ThemePatch.kt
View File

@ -77,10 +77,11 @@ val themePatch = resourcePatch(
arrayOf("values", "values-v31").forEach { path ->
document("res/$path/colors.xml").use { document ->
val resourcesNode = document.getElementsByTagName("resources").item(0) as Element
val resourcesNode = document.documentElement
val childNodes = resourcesNode.childNodes
for (i in 0 until resourcesNode.childNodes.length) {
val node = resourcesNode.childNodes.item(i) as? Element ?: continue
for (i in 0 until childNodes.length) {
val node = childNodes.item(i) as? Element ?: continue
node.textContent = when (node.getAttribute("name")) {
"yt_black0", "yt_black1", "yt_black1_opacity95", "yt_black1_opacity98", "yt_black2", "yt_black3",

25
patches/src/main/kotlin/app/revanced/patches/youtube/utils/settings/SettingsPatch.kt
View File

@ -223,22 +223,21 @@ val settingsPatch = resourcePatch(
/**
* remove ReVanced Extended Settings divider
*/
arrayOf("Theme.YouTube.Settings", "Theme.YouTube.Settings.Dark").forEach { themeName ->
document("res/values/styles.xml").use { document ->
with(document) {
val resourcesNode = getElementsByTagName("resources").item(0) as Element
document("res/values/styles.xml").use { document ->
val themeNames = arrayOf("Theme.YouTube.Settings", "Theme.YouTube.Settings.Dark")
with(document) {
val resourcesNode = documentElement
val childNodes = resourcesNode.childNodes
val newElement: Element = createElement("item")
newElement.setAttribute("name", "android:listDivider")
for (i in 0 until childNodes.length) {
val node = childNodes.item(i) as? Element ?: continue
for (i in 0 until resourcesNode.childNodes.length) {
val node = resourcesNode.childNodes.item(i) as? Element ?: continue
if (node.getAttribute("name") == themeName) {
newElement.appendChild(createTextNode("@null"))
node.appendChild(newElement)
if (node.getAttribute("name") in themeNames) {
val newElement = createElement("item").apply {
setAttribute("name", "android:listDivider")
appendChild(createTextNode("@null"))
}
node.appendChild(newElement)
}
}
}

11
patches/src/main/kotlin/app/revanced/util/ResourceUtils.kt
View File

@ -55,7 +55,8 @@ fun Node.cloneNodes(parent: Node) {
*/
fun Node.doRecursively(action: (Node) -> Unit) {
action(this)
for (i in 0 until this.childNodes.length) this.childNodes.item(i).doRecursively(action)
val childNodes = this.childNodes
for (i in 0 until childNodes.length) childNodes.item(i).doRecursively(action)
}
fun List<String>.getResourceGroup(fileNames: Array<String>) = map { directory ->
@ -164,10 +165,11 @@ fun ResourcePatchContext.addEntryValues(
) {
document(path).use { document ->
with(document) {
val resourcesNode = getElementsByTagName("resources").item(0) as Element
val resourcesNode = documentElement
val childNodes = resourcesNode.childNodes
val newElement: Element = createElement("item")
for (i in 0 until resourcesNode.childNodes.length) {
val node = resourcesNode.childNodes.item(i) as? Element ?: continue
for (i in 0 until childNodes.length) {
val node = childNodes.item(i) as? Element ?: continue
if (node.getAttribute("name") == attributeName) {
newElement.appendChild(createTextNode(attributeValue))
@ -177,6 +179,7 @@ fun ResourcePatchContext.addEntryValues(
} else {
node.insertBefore(newElement, node.firstChild)
}
break
}
}
}