feat(YouTube - Seekbar components): Remove Enable Cairo seekbar setting, which is no longer needed (Enabled by default in YouTube 19.34.42)

This commit is contained in:
inotia00 2024-12-15 14:26:18 +09:00
parent 969e845a87
commit 231f897bcc
6 changed files with 0 additions and 35 deletions

View File

@ -714,10 +714,6 @@ public class PlayerPatch {
return !Settings.RESTORE_OLD_SEEKBAR_THUMBNAILS.get(); return !Settings.RESTORE_OLD_SEEKBAR_THUMBNAILS.get();
} }
public static boolean enableCairoSeekbar() {
return Settings.ENABLE_CAIRO_SEEKBAR.get();
}
// endregion // endregion
public static int getQuickActionsTopMargin() { public static int getQuickActionsTopMargin() {

View File

@ -400,7 +400,6 @@ public class Settings extends BaseSettings {
public static final BooleanSetting RESTORE_OLD_SEEKBAR_THUMBNAILS = new BooleanSetting("revanced_restore_old_seekbar_thumbnails", public static final BooleanSetting RESTORE_OLD_SEEKBAR_THUMBNAILS = new BooleanSetting("revanced_restore_old_seekbar_thumbnails",
PatchStatus.OldSeekbarThumbnailsDefaultBoolean(), true); PatchStatus.OldSeekbarThumbnailsDefaultBoolean(), true);
public static final BooleanSetting ENABLE_SEEKBAR_THUMBNAILS_HIGH_QUALITY = new BooleanSetting("revanced_enable_seekbar_thumbnails_high_quality", FALSE, true, "revanced_enable_seekbar_thumbnails_high_quality_dialog_message"); public static final BooleanSetting ENABLE_SEEKBAR_THUMBNAILS_HIGH_QUALITY = new BooleanSetting("revanced_enable_seekbar_thumbnails_high_quality", FALSE, true, "revanced_enable_seekbar_thumbnails_high_quality_dialog_message");
public static final BooleanSetting ENABLE_CAIRO_SEEKBAR = new BooleanSetting("revanced_enable_cairo_seekbar", FALSE, true);
// PreferenceScreen: Player - Video description // PreferenceScreen: Player - Video description
public static final BooleanSetting DISABLE_ROLLING_NUMBER_ANIMATIONS = new BooleanSetting("revanced_disable_rolling_number_animations", FALSE); public static final BooleanSetting DISABLE_ROLLING_NUMBER_ANIMATIONS = new BooleanSetting("revanced_disable_rolling_number_animations", FALSE);

View File

@ -6,13 +6,6 @@ import app.revanced.util.or
import com.android.tools.smali.dexlib2.AccessFlags import com.android.tools.smali.dexlib2.AccessFlags
import com.android.tools.smali.dexlib2.Opcode import com.android.tools.smali.dexlib2.Opcode
internal val cairoSeekbarConfigFingerprint = legacyFingerprint(
name = "cairoSeekbarConfigFingerprint",
returnType = "Z",
parameters = emptyList(),
literals = listOf(45617850L),
)
internal val controlsOverlayStyleFingerprint = legacyFingerprint( internal val controlsOverlayStyleFingerprint = legacyFingerprint(
name = "controlsOverlayStyleFingerprint", name = "controlsOverlayStyleFingerprint",
opcodes = listOf(Opcode.CONST_HIGH16), opcodes = listOf(Opcode.CONST_HIGH16),

View File

@ -17,7 +17,6 @@ import app.revanced.patches.youtube.utils.patch.PatchList.SEEKBAR_COMPONENTS
import app.revanced.patches.youtube.utils.playerButtonsResourcesFingerprint import app.revanced.patches.youtube.utils.playerButtonsResourcesFingerprint
import app.revanced.patches.youtube.utils.playerButtonsVisibilityFingerprint import app.revanced.patches.youtube.utils.playerButtonsVisibilityFingerprint
import app.revanced.patches.youtube.utils.playerSeekbarColorFingerprint import app.revanced.patches.youtube.utils.playerSeekbarColorFingerprint
import app.revanced.patches.youtube.utils.playservice.is_19_23_or_greater
import app.revanced.patches.youtube.utils.playservice.versionCheckPatch import app.revanced.patches.youtube.utils.playservice.versionCheckPatch
import app.revanced.patches.youtube.utils.resourceid.inlineTimeBarColorizedBarPlayedColorDark import app.revanced.patches.youtube.utils.resourceid.inlineTimeBarColorizedBarPlayedColorDark
import app.revanced.patches.youtube.utils.resourceid.inlineTimeBarPlayedNotHighlightedColor import app.revanced.patches.youtube.utils.resourceid.inlineTimeBarPlayedNotHighlightedColor
@ -303,19 +302,6 @@ val seekbarComponentsPatch = bytecodePatch(
// endregion // endregion
// region patch for enable cairo seekbar
if (is_19_23_or_greater) {
cairoSeekbarConfigFingerprint.injectLiteralInstructionBooleanCall(
45617850L,
"$PLAYER_CLASS_DESCRIPTOR->enableCairoSeekbar()Z"
)
settingArray += "SETTINGS: ENABLE_CAIRO_SEEKBAR"
}
// endregion
// region add settings // region add settings
addPreference(settingArray, SEEKBAR_COMPONENTS) addPreference(settingArray, SEEKBAR_COMPONENTS)

View File

@ -1141,11 +1141,6 @@ Tap and hold to toggle the appended information type."</string>
Internet data usage may be higher, and seekbar thumbnails will have a slight delay before showing. Internet data usage may be higher, and seekbar thumbnails will have a slight delay before showing.
This feature works best with a very fast internet connection."</string> This feature works best with a very fast internet connection."</string>
<string name="revanced_enable_cairo_seekbar_title">Enable Cairo seekbar</string>
<string name="revanced_enable_cairo_seekbar_summary_on">"Cairo seekbar is enabled.
Side effect: Cairo theme is also applied to notification dots."</string>
<string name="revanced_enable_cairo_seekbar_summary_off">Cairo seekbar is disabled.</string>
<!-- PreferenceScreen: Player, PreferenceCategory: Player, PreferenceScreen: Video description --> <!-- PreferenceScreen: Player, PreferenceCategory: Player, PreferenceScreen: Video description -->
<string name="revanced_preference_screen_video_description_title">Video description</string> <string name="revanced_preference_screen_video_description_title">Video description</string>

View File

@ -481,10 +481,6 @@
<!-- SETTINGS: RESTORE_OLD_SEEKBAR_THUMBNAILS <!-- SETTINGS: RESTORE_OLD_SEEKBAR_THUMBNAILS
<SwitchPreference android:title="@string/revanced_restore_old_seekbar_thumbnails_title" android:key="revanced_restore_old_seekbar_thumbnails" android:summaryOn="@string/revanced_restore_old_seekbar_thumbnails_summary_on" android:summaryOff="@string/revanced_restore_old_seekbar_thumbnails_summary_off" />SETTINGS: RESTORE_OLD_SEEKBAR_THUMBNAILS --> <SwitchPreference android:title="@string/revanced_restore_old_seekbar_thumbnails_title" android:key="revanced_restore_old_seekbar_thumbnails" android:summaryOn="@string/revanced_restore_old_seekbar_thumbnails_summary_on" android:summaryOff="@string/revanced_restore_old_seekbar_thumbnails_summary_off" />SETTINGS: RESTORE_OLD_SEEKBAR_THUMBNAILS -->
<!-- SETTINGS: ENABLE_CAIRO_SEEKBAR
<PreferenceCategory android:title="@string/revanced_preference_category_experimental_flag" android:layout="@layout/revanced_settings_preferences_category"/>
<SwitchPreference android:title="@string/revanced_enable_cairo_seekbar_title" android:key="revanced_enable_cairo_seekbar" android:summaryOn="@string/revanced_enable_cairo_seekbar_summary_on" android:summaryOff="@string/revanced_enable_cairo_seekbar_summary_off" />SETTINGS: ENABLE_CAIRO_SEEKBAR -->
<!-- SETTINGS: SEEKBAR_COMPONENTS <!-- SETTINGS: SEEKBAR_COMPONENTS
</PreferenceScreen>SETTINGS: SEEKBAR_COMPONENTS --> </PreferenceScreen>SETTINGS: SEEKBAR_COMPONENTS -->