From 1cfe69ab471289eebd502c3b44860ba0dd7361b7 Mon Sep 17 00:00:00 2001
From: inotia00 <108592928+inotia00@users.noreply.github.com>
Date: Thu, 6 Mar 2025 11:58:14 +0900
Subject: [PATCH] fix(Hide ads): Change the default value of `Hide fullscreen
 ads` to false and add limitations to the description (Close
 https://github.com/inotia00/ReVanced_Extended/issues/2812)

---
 .../app/revanced/extension/shared/settings/BaseSettings.java | 2 +-
 .../app/revanced/patches/music/ads/general/AdsPatch.kt       | 2 +-
 .../main/resources/music/settings/host/values/strings.xml    | 5 ++++-
 3 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/extensions/shared/src/main/java/app/revanced/extension/shared/settings/BaseSettings.java b/extensions/shared/src/main/java/app/revanced/extension/shared/settings/BaseSettings.java
index 5c092e457..c91080390 100644
--- a/extensions/shared/src/main/java/app/revanced/extension/shared/settings/BaseSettings.java
+++ b/extensions/shared/src/main/java/app/revanced/extension/shared/settings/BaseSettings.java
@@ -51,7 +51,7 @@ public class BaseSettings {
     /**
      * These settings are used by YouTube and YouTube Music.
      */
-    public static final BooleanSetting HIDE_FULLSCREEN_ADS = new BooleanSetting("revanced_hide_fullscreen_ads", TRUE, true);
+    public static final BooleanSetting HIDE_FULLSCREEN_ADS = new BooleanSetting("revanced_hide_fullscreen_ads", FALSE, true);
     public static final BooleanSetting HIDE_PROMOTION_ALERT_BANNER = new BooleanSetting("revanced_hide_promotion_alert_banner", TRUE);
 
     public static final BooleanSetting DISABLE_AUTO_CAPTIONS = new BooleanSetting("revanced_disable_auto_captions", FALSE, true);
diff --git a/patches/src/main/kotlin/app/revanced/patches/music/ads/general/AdsPatch.kt b/patches/src/main/kotlin/app/revanced/patches/music/ads/general/AdsPatch.kt
index 56e345c17..23df8ddbd 100644
--- a/patches/src/main/kotlin/app/revanced/patches/music/ads/general/AdsPatch.kt
+++ b/patches/src/main/kotlin/app/revanced/patches/music/ads/general/AdsPatch.kt
@@ -194,7 +194,7 @@ val adsPatch = bytecodePatch(
         addSwitchPreference(
             CategoryType.ADS,
             "revanced_hide_fullscreen_ads",
-            "true"
+            "false"
         )
         addSwitchPreference(
             CategoryType.ADS,
diff --git a/patches/src/main/resources/music/settings/host/values/strings.xml b/patches/src/main/resources/music/settings/host/values/strings.xml
index 8044db243..8bae2e902 100644
--- a/patches/src/main/resources/music/settings/host/values/strings.xml
+++ b/patches/src/main/resources/music/settings/host/values/strings.xml
@@ -63,7 +63,10 @@ Please download %2$s from the website."</string>
     <string name="revanced_preference_screen_ads_title">Ads</string>
 
     <string name="revanced_hide_fullscreen_ads_title">Hide fullscreen ads</string>
-    <string name="revanced_hide_fullscreen_ads_summary">Hides fullscreen ads.</string>
+    <string name="revanced_hide_fullscreen_ads_summary">"Hides fullscreen ads.
+
+Limitations:
+• Sometimes you may see a blank black screen instead of the home feed."</string>
     <string name="revanced_fullscreen_ads_closed_toast">Fullscreen ads are closed.</string>
     <string name="revanced_hide_general_ads_title">Hide general ads</string>
     <string name="revanced_hide_general_ads_summary">Hides general ads.</string>