refactor: cleanup code

This commit is contained in:
Sculas 2022-08-24 00:17:51 +02:00
parent 4daacf0e91
commit cf1a19c4e1
No known key found for this signature in database
GPG Key ID: 1530BFF96D1EEB89
5 changed files with 10 additions and 15 deletions

View File

@ -72,7 +72,7 @@ dependencies {
implementation("org.jetbrains.kotlinx:kotlinx-serialization-json:1.3.3") implementation("org.jetbrains.kotlinx:kotlinx-serialization-json:1.3.3")
// Taxi (navigation) // Taxi (navigation)
implementation("com.github.X1nto:Taxi:1.0.0") implementation("com.github.X1nto:Taxi:1.2.0")
// Ktor // Ktor
val ktorVersion = "2.0.3" val ktorVersion = "2.0.3"

View File

@ -12,8 +12,7 @@ import androidx.compose.foundation.layout.fillMaxSize
import androidx.compose.ui.Modifier import androidx.compose.ui.Modifier
import app.revanced.manager.preferences.PreferencesManager import app.revanced.manager.preferences.PreferencesManager
import app.revanced.manager.ui.navigation.AppDestination import app.revanced.manager.ui.navigation.AppDestination
import app.revanced.manager.ui.screen.MainRootScreen import app.revanced.manager.ui.screen.MainDashboardScreen
import app.revanced.manager.ui.screen.SettingsScreen
import app.revanced.manager.ui.theme.ReVancedManagerTheme import app.revanced.manager.ui.theme.ReVancedManagerTheme
import com.xinto.taxi.Taxi import com.xinto.taxi.Taxi
import com.xinto.taxi.rememberBackstackNavigator import com.xinto.taxi.rememberBackstackNavigator
@ -39,7 +38,7 @@ class MainActivity : ComponentActivity() {
transitionSpec = { fadeIn() with fadeOut() } transitionSpec = { fadeIn() with fadeOut() }
) { destination -> ) { destination ->
when (destination) { when (destination) {
is AppDestination.Dashboard -> MainRootScreen(navigator = navigator) is AppDestination.Dashboard -> MainDashboardScreen(navigator = navigator)
} }
} }
} }

View File

@ -5,25 +5,19 @@ import androidx.compose.foundation.layout.Column
import androidx.compose.foundation.layout.fillMaxWidth import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.padding import androidx.compose.foundation.layout.padding
import androidx.compose.material3.ElevatedCard import androidx.compose.material3.ElevatedCard
import androidx.compose.material3.ExperimentalMaterial3Api
import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.Text import androidx.compose.material3.Text
import androidx.compose.runtime.Composable import androidx.compose.runtime.Composable
import androidx.compose.ui.Modifier import androidx.compose.ui.Modifier
import androidx.compose.ui.res.stringResource import androidx.compose.ui.res.stringResource
import androidx.compose.ui.unit.dp import androidx.compose.ui.unit.dp
@OptIn(ExperimentalMaterial3Api::class)
@Composable @Composable
fun HeadlineWithCard( fun HeadlineWithCard(
@StringRes headline: Int, @StringRes headline: Int,
content: @Composable () -> Unit content: @Composable () -> Unit
) { ) {
Column { Column {
Text( Text(stringResource(headline))
text = stringResource(headline),
style = MaterialTheme.typography.headlineSmall
)
ElevatedCard( ElevatedCard(
modifier = Modifier modifier = Modifier
.padding(top = 12.dp) .padding(top = 12.dp)

View File

@ -23,5 +23,6 @@ enum class DashboardDestination(
@StringRes val label: Int @StringRes val label: Int
) : Destination { ) : Destination {
DASHBOARD(Icons.Default.Dashboard, R.string.dashboard), DASHBOARD(Icons.Default.Dashboard, R.string.dashboard),
PATCHER(Icons.Default.Build, R.string.patcher) PATCHER(Icons.Default.Build, R.string.patcher),
SETTINGS(Icons.Default.Settings, R.string.settings)
} }

View File

@ -9,7 +9,6 @@ import androidx.compose.runtime.Composable
import androidx.compose.ui.Modifier import androidx.compose.ui.Modifier
import androidx.compose.ui.input.nestedscroll.nestedScroll import androidx.compose.ui.input.nestedscroll.nestedScroll
import androidx.compose.ui.res.stringResource import androidx.compose.ui.res.stringResource
import androidx.compose.ui.text.font.FontWeight
import app.revanced.manager.ui.navigation.AppDestination import app.revanced.manager.ui.navigation.AppDestination
import app.revanced.manager.ui.navigation.DashboardDestination import app.revanced.manager.ui.navigation.DashboardDestination
import com.xinto.taxi.BackstackNavigator import com.xinto.taxi.BackstackNavigator
@ -18,11 +17,12 @@ import com.xinto.taxi.rememberNavigator
@OptIn(ExperimentalMaterial3Api::class, ExperimentalAnimationApi::class) @OptIn(ExperimentalMaterial3Api::class, ExperimentalAnimationApi::class)
@Composable @Composable
fun MainRootScreen(navigator: BackstackNavigator<AppDestination>) { fun MainDashboardScreen(navigator: BackstackNavigator<AppDestination>) {
val scrollBehavior = TopAppBarDefaults.exitUntilCollapsedScrollBehavior( val scrollBehavior = TopAppBarDefaults.exitUntilCollapsedScrollBehavior(
decayAnimationSpec = rememberSplineBasedDecay(), decayAnimationSpec = rememberSplineBasedDecay(),
state = rememberTopAppBarState() state = rememberTopAppBarState()
) )
val mainRootNavigator = rememberNavigator(DashboardDestination.DASHBOARD) val mainRootNavigator = rememberNavigator(DashboardDestination.DASHBOARD)
val currentDestination = mainRootNavigator.currentDestination val currentDestination = mainRootNavigator.currentDestination
@ -31,7 +31,7 @@ fun MainRootScreen(navigator: BackstackNavigator<AppDestination>) {
.fillMaxSize() .fillMaxSize()
.nestedScroll(scrollBehavior.nestedScrollConnection), .nestedScroll(scrollBehavior.nestedScrollConnection),
topBar = { topBar = {
LargeTopAppBar( MediumTopAppBar(
title = { title = {
Text( Text(
text = stringResource(mainRootNavigator.currentDestination.label), text = stringResource(mainRootNavigator.currentDestination.label),
@ -65,6 +65,7 @@ fun MainRootScreen(navigator: BackstackNavigator<AppDestination>) {
when (destination) { when (destination) {
DashboardDestination.DASHBOARD -> DashboardScreen() DashboardDestination.DASHBOARD -> DashboardScreen()
DashboardDestination.PATCHER -> PatcherScreen() DashboardDestination.PATCHER -> PatcherScreen()
DashboardDestination.SETTINGS -> SettingsScreen()
} }
} }
} }