diff --git a/src/se/vidstige/jadb/managers/PackageManager.java b/src/se/vidstige/jadb/managers/PackageManager.java index 40d0fde..8609fd8 100644 --- a/src/se/vidstige/jadb/managers/PackageManager.java +++ b/src/se/vidstige/jadb/managers/PackageManager.java @@ -43,7 +43,7 @@ public class PackageManager { if (!result.contains("Success")) throw new JadbException(getErrorMessage(operation, target, result)); } - public void remove(RemoteFile file) throws IOException, JadbException { + private void remove(RemoteFile file) throws IOException, JadbException { InputStream s = device.executeShell("rm", "-f", Bash.quote(file.getPath())); Stream.readAll(s, StandardCharsets.UTF_8); } @@ -51,7 +51,7 @@ public class PackageManager { private void install(File apkFile, List extraArguments) throws IOException, JadbException { RemoteFile remote = new RemoteFile("/sdcard/tmp/" + apkFile.getName()); device.push(apkFile, remote); - ArrayList arguments = new ArrayList<>(); + List arguments = new ArrayList<>(); arguments.add("install"); arguments.addAll(extraArguments); arguments.add(remote.getPath()); @@ -91,14 +91,16 @@ public class PackageManager { // public static class InstallOption { + private final StringBuilder stringBuilder = new StringBuilder(); + InstallOption(String ... varargs) { + String suffix = ""; for(String str: varargs) { - stringBuilder.append(str).append(" "); + stringBuilder.append(suffix).append(str); + suffix = " "; } } - private final StringBuilder stringBuilder = new StringBuilder(); - private String getStringRepresentation() { return stringBuilder.toString(); } diff --git a/test/se/vidstige/jadb/test/unit/PackageManagerTest.java b/test/se/vidstige/jadb/test/unit/PackageManagerTest.java index 4f72f47..c21d0ab 100644 --- a/test/se/vidstige/jadb/test/unit/PackageManagerTest.java +++ b/test/se/vidstige/jadb/test/unit/PackageManagerTest.java @@ -90,5 +90,4 @@ public class PackageManagerTest { //Assert assertEquals(expected, actual); } - } \ No newline at end of file