53 Commits

Author SHA1 Message Date
Connor Tumbleson
8254764c6c More robust ResFileValue detection
Previously in 4882396163f978884256e008fc7fae9201f156b4, strings that
resembled a filepath (ie res/foo/file), would be assigned to a
ResFileValue, which when attempted to be casted to ResScalarValue would
error out.

Attempting to check the filesystem for such files, slowed apktool's
execution majorly. In order to prevent this, the ClassCastException
and other checks related to checking ResFileValue when type is string
was added.

This allows bogus strings such as (res/foo/file) to be added, but the
exception is caught and allows decoding to continues. Fixes #921.
2015-05-14 13:27:22 -05:00
Connor Tumbleson
9cb3df85d8 Catch attr lookup on internal attributes
Internal attributes will fail the AttrDecoder. Catch the errors
and simply return the undecoded value which will be correct. Fixes #913
2015-05-10 07:36:44 -05:00
Connor Tumbleson
48285bde03 Prevent frameworks from modifying sharedLibrary
Since all frameworks are decoded the same via readPackage(), reading
a framework that was a sharedLibrary would throw the sharedLibrary
flag for the apk. Since packageName isn't set until after the first
decode, we check the values to make sure we only set this variable on
the first apk decoded. Refs #936
2015-05-05 07:43:48 -05:00
Connor Tumbleson
3cdd8243c7 Read res header completely 2015-04-16 08:14:57 -05:00
Connor Tumbleson
bb6cd98dfa fix regression of lang qualifiers
- values-xx was improperly decoded as values-b+xx
 - added unit test
2015-04-11 12:39:38 -05:00
Connor Tumbleson
0a74de4ab0 Shared Library Rebuilding Support
- handles references with shared resources
 - adds support for --shared-lib
 - update unit-tests
2015-03-14 08:04:33 -05:00
Connor Tumbleson
4638c06de4 Merge pull request #100 from iBotPeaches/bcp47-support
[WIP] Initial support for BCP47 tags
2015-02-25 16:46:22 -06:00
Furniel
ddb4f9770d SPI are not 9patches
- skip these by copying raw
2015-02-24 12:36:43 +02:00
Connor Tumbleson
d40710005f Handle BCP additional fields (script & variant)
layoutDirection was being read in error. layoutDirection is read
via bit shifting over screenLayout (byte 32, 33)

The then removed layoutDirection freed up 2 bytes. This gave us
12 bytes of unknown space from byte 36 to 48. This corresponded
to localeScript[4] and localeVariant[8]

Adding proper support for those bytes fixed BCP support
2015-02-19 09:05:00 -06:00
Connor Tumbleson
af65dea319 Initial support for BCP47 tags
- needs script/variant support
- currently only region(s) supported
2015-02-17 11:48:39 -06:00
Connor Tumbleson
e9d21f84af Handle apks that utilize Shared Resources
- shared resource is currently hardcoded to pkgId 2 like AOSP
 - merry christmas
2014-12-25 09:56:25 -06:00
Connor Tumbleson
9b1c7d22ef JEB - Fix decompressor when string arrays aren't 4-byte aligned 2014-11-01 21:21:35 -05:00
Connor Tumbleson
9031c22365 [skip] update all copyrights to 2014 2014-10-23 18:14:48 -05:00
Connor Tumbleson
869d287aaa Cleanup
- switch to java7 try-with-resources
 - add check in unit-tests for checking control
2014-10-22 22:03:59 -05:00
Connor Tumbleson
3e6fc8c5ef QMG are not 9patches
- skip these by copying raw
2014-10-22 21:56:54 -05:00
Connor Tumbleson
986b585f26 Removes hardcoded extension of PNG to allow OEM versions (qmg)
- adds unit-tests via two qmg files (one 9 patch, one regular)
2014-10-22 16:32:05 -05:00
Connor Tumbleson
06bcff5b6f [skip] update changelog, code style fixes 2014-10-05 12:35:03 -05:00
Connor Tumbleson
62db52fe7b Handle APKs with NULL padding on StringPools
- issue 664
2014-10-05 12:34:38 -05:00
Connor Tumbleson
e126a51b4b handles manifests with missing named attributes.
- fixes #512
2014-06-18 10:59:54 -05:00
Connor Tumbleson
848f0d6b5f fixed regression introduced in: b149d7bd495db35a373e3b84cf77e52cd09d5b0b 2014-05-30 06:33:17 -05:00
Connor Tumbleson
a3897bfe0d [spelling] Nul -> Null 2014-05-12 17:11:28 -05:00
Connor Tumbleson
fc0b584af1 [skip] adjusted spacing to match new standard 2014-05-12 17:01:08 -05:00
Connor Tumbleson
b149d7bd49 cleaned up XmlPullStreamDecoder
-- removed optimize for manifest bool
 -- take attr value once, then re-use
 -- used passed ResTable, instead of re-init
2014-05-12 17:00:31 -05:00
Connor Tumbleson
d90bea10ce malformed styles
if styles are malformed html, then recreation fails with OutOfBounds,
end tag if error occurs to prevent crash
2014-02-09 20:45:16 -06:00
Connor Tumbleson
94b90a6dd2 add code style doc rules, adjusting stringblock to 120 margin 2014-02-09 19:23:25 -06:00
Connor Tumbleson
086139a037 code cleanup of 2014 2014-02-09 19:01:57 -06:00
Connor Tumbleson
ca314b9aae fix abused lengths (strings over 32768) for UTF-16 strings 2014-02-09 18:48:40 -06:00
Connor Tumbleson
e48ab8b9b9 threadsafe StringBlock 2014-02-07 07:35:03 -06:00
Connor Tumbleson
e254cec648 rework manifest renaming
Issue #526, correctly handles apks where a renamed package is required, by comparing the package name present
in AndroidManifest.xml and resources.arsc. If different, we take the package name present
in resources.arsc (original) and replace it in the <manifest> tag of AndroidManifest.xml. The previous value in
AndroidManifest.xml (renamed) becomes the value to be passed to aapt on rebuild via --rename-manifest-package

Both these values along with the package id of the original are stored in apktool.yml, for use during the
rebuild
2014-01-07 10:59:37 -06:00
Connor Tumbleson
1d745ac0ad correctly handles abused length strings - jtmuhone 2013-12-18 08:41:18 -06:00
Connor Tumbleson
68c1809a48 Handles multiple package framework files correctly. 2013-10-12 15:40:06 -05:00
Connor Tumbleson
63b0dd1edb fixes JDK bug: 5051418 2013-07-08 12:27:33 -05:00
Connor Tumbleson
832978a549 fixes issue 469, added -m / --match-original
fixes xml output not having newline after xml declaration
2013-06-12 10:04:28 -05:00
Connor Tumbleson
be73563c43 handle all version(s) as strings, and change java to 1.7 2013-05-02 12:56:18 -05:00
Connor Tumbleson
3a5530e67b remove hardcoded htc stuff 2013-04-03 14:07:18 -05:00
Connor Tumbleson
a48c11dc1c cleanup of various functions
Removed attr sorting that was never enabled and never worked, added @todo elements for unknown file handling, updated usage output
2013-04-01 16:41:27 -05:00
Connor Tumbleson
2e44e3a856 handle com.htc.resources correctly 2013-03-31 09:05:07 -05:00
Connor Tumbleson
c5d2ecf96f fixed #401 (versionCode / versionName) 2013-03-21 08:58:14 -05:00
Felipe Barriga Richards
9677119324 Issue 359: Can't decompile Notif Pro 0.31 / Tested on other apk 2013-03-21 05:48:12 -05:00
M1cha
071ce71a61 apktool-lib: fix recompiling framework apk's with dependencies by using static package-id 2013-03-19 12:55:58 -05:00
Connor Tumbleson
e6cf72f1d2 Merge pull request #71 from rchiossi/master
Fix for Null Reference while extracting Resources.
2013-02-27 17:26:56 -08:00
Rodrigo Chiossi
bad8392487 Fix null mConfig in addMissingResSpecs() 2013-02-27 12:09:06 -03:00
Connor Tumbleson
8a9af4ab31 update known bytes to 38 2013-02-24 10:53:40 -06:00
Connor Tumbleson
e82c0754de Code cleanup of 2013
Signed-off-by: Connor Tumbleson <connor.tumbleson@gmail.com>
2013-02-12 21:12:17 -06:00
Connor Tumbleson
7fe733bf43 adding support for htc .r.9.png 2013-01-21 08:25:57 -06:00
Connor Tumbleson
3b0ca62fb0 fix warnings related to <uses-sdk> 2012-12-23 10:10:36 -06:00
Connor Tumbleson
04b5508c3a Android 4.2 support finally ? updated some internal libs, fixed --renamed-package 2012-12-18 19:40:42 -06:00
Connor Tumbleson
f065a5be92 properly store package information (manifest AND resources.arsc info) in apktool.yml for renamed packages 2012-12-13 21:14:41 -06:00
Connor Tumbleson
da68943022 Starting work on Bug #252 2012-12-01 12:36:51 -06:00
Connor Tumbleson
b4db7735a5 only check for layoutDir if over sdk 17 2012-11-19 07:56:19 -06:00