ReVanced/Apktool
1
0
Fork 0
mirror of https://github.com/revanced/Apktool.git synced 2025-06-13 13:27:37 +02:00
Code Issues Packages Projects Releases Wiki Activity

More robust ResFileValue detection

Browse Source 
Previously in 4882396163, strings that
resembled a filepath (ie res/foo/file), would be assigned to a
ResFileValue, which when attempted to be casted to ResScalarValue would
error out.

Attempting to check the filesystem for such files, slowed apktool's
execution majorly. In order to prevent this, the ClassCastException
and other checks related to checking ResFileValue when type is string
was added.

This allows bogus strings such as (res/foo/file) to be added, but the
exception is caught and allows decoding to continues. Fixes #921.
This commit is contained in:
Connor Tumbleson
2015-05-14 13:22:43 -05:00
parent 9cb3df85d8
commit 8254764c6c
5 changed files with 26 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
brut.apktool/apktool-lib/src/test/resources/brut/apktool/testapp/res/raw/no_extension Normal file
View File

@ -0,0 +1 @@
This file has no extension.