Solved some warnings

src/api/core/accounts.rs

@@ -1,11 +1,9 @@
-use rocket::Route;
 use rocket::response::status::BadRequest;
 
 use rocket_contrib::{Json, Value};
 
 use db::DbConn;
 use db::models::*;
-use util;
 
 use auth::Headers;
 
@@ -64,7 +62,7 @@ fn register(data: Json<RegisterData>, conn: DbConn) -> Result<(), BadRequest<Jso
 }
 
 #[get("/accounts/profile")]
-fn profile(headers: Headers, conn: DbConn) -> Result<Json, BadRequest<Json>> {
+fn profile(headers: Headers) -> Result<Json, BadRequest<Json>> {
     Ok(Json(headers.user.to_json()))
 }
 
@@ -140,7 +138,7 @@ fn post_email(data: Json<Value>, headers: Headers, conn: DbConn) -> Result<(), B
 fn delete_account(data: Json<Value>, headers: Headers, conn: DbConn) -> Result<(), BadRequest<Json>> {
     let password_hash = data["masterPasswordHash"].as_str().unwrap();
 
-    let mut user = headers.user;
+    let user = headers.user;
 
     if !user.check_valid_password(password_hash) {
         err!("Invalid password")
@@ -154,7 +152,7 @@ fn delete_account(data: Json<Value>, headers: Headers, conn: DbConn) -> Result<(
 }
 
 #[get("/accounts/revision-date")]
-fn revision_date(headers: Headers, conn: DbConn) -> Result<String, BadRequest<Json>> {
+fn revision_date(headers: Headers) -> Result<String, BadRequest<Json>> {
     let revision_date = headers.user.updated_at.timestamp();
     Ok(revision_date.to_string())
 }

src/api/core/ciphers.rs

@@ -1,7 +1,6 @@
-use std::io::{Cursor, Read};
 use std::path::Path;
 
-use rocket::{Route, Data};
+use rocket::Data;
 use rocket::http::ContentType;
 use rocket::response::status::BadRequest;
 
@@ -221,7 +220,7 @@ fn post_attachment(uuid: String, data: Data, content_type: &ContentType, headers
             .memory_threshold(0)
             .size_limit(None)
             .with_path(path) {
-            SaveResult::Full(SavedData::File(path, size)) => size as i32,
+            SaveResult::Full(SavedData::File(_, size)) => size as i32,
             _ => return
         };
 
@@ -233,8 +232,8 @@ fn post_attachment(uuid: String, data: Data, content_type: &ContentType, headers
     Ok(Json(cipher.to_json(&conn)))
 }
 
-#[post("/ciphers/<uuid>/attachment/<attachment_id>/delete", data = "<data>")]
-fn delete_attachment_post(uuid: String, attachment_id: String, data: Json<Value>, headers: Headers, conn: DbConn) -> Result<(), BadRequest<Json>> {
+#[post("/ciphers/<uuid>/attachment/<attachment_id>/delete", data = "<_data>")]
+fn delete_attachment_post(uuid: String, attachment_id: String, _data: Json<Value>, headers: Headers, conn: DbConn) -> Result<(), BadRequest<Json>> {
     // Data contains a json object with the id, but we don't need it
     delete_attachment(uuid, attachment_id, headers, conn)
 }

src/api/core/folders.rs

@@ -1,11 +1,9 @@
-use rocket::Route;
 use rocket::response::status::BadRequest;
 
 use rocket_contrib::{Json, Value};
 
 use db::DbConn;
 use db::models::*;
-use util;
 
 use auth::Headers;
 
@@ -23,7 +21,7 @@ fn get_folders(headers: Headers, conn: DbConn) -> Result<Json, BadRequest<Json>>
 
 #[get("/folders/<uuid>")]
 fn get_folder(uuid: String, headers: Headers, conn: DbConn) -> Result<Json, BadRequest<Json>> {
-    let mut folder = match Folder::find_by_uuid(&uuid, &conn) {
+    let folder = match Folder::find_by_uuid(&uuid, &conn) {
         Some(folder) => folder,
         _ => err!("Invalid folder")
     };
@@ -79,8 +77,8 @@ fn put_folder(uuid: String, data: Json<Value>, headers: Headers, conn: DbConn) -
     Ok(Json(folder.to_json()))
 }
 
-#[post("/folders/<uuid>/delete", data = "<data>")]
-fn delete_folder_post(uuid: String, data: Json<Value>, headers: Headers, conn: DbConn) -> Result<(), BadRequest<Json>> {
+#[post("/folders/<uuid>/delete", data = "<_data>")]
+fn delete_folder_post(uuid: String, _data: Json<Value>, headers: Headers, conn: DbConn) -> Result<(), BadRequest<Json>> {
     // Data contains a json object with the id, but we don't need it
     delete_folder(uuid, headers, conn)
 }

src/api/core/mod.rs

@@ -64,11 +64,9 @@ pub fn routes() -> Vec<Route> {
 use rocket::Route;
 use rocket::response::status::BadRequest;
 
-use rocket_contrib::{Json, Value};
+use rocket_contrib::Json;
 
 use db::DbConn;
-use db::models::*;
-use util;
 
 use auth::Headers;
 
@@ -107,7 +105,7 @@ fn post_eq_domains(data: Json<EquivDomainData>, headers: Headers, conn: DbConn)
     let excluded_globals = &data.ExcludedGlobalEquivalentDomains;
     let equivalent_domains = &data.EquivalentDomains;
 
-    let mut user = headers.user;
+    let user = headers.user;
 
 
     //BODY. "{\"ExcludedGlobalEquivalentDomains\":[2],\"EquivalentDomains\":[[\"uoc.edu\",\"uoc.es\"]]}"

src/api/core/two_factor.rs

@@ -1,4 +1,3 @@
-use rocket::Route;
 use rocket::response::status::BadRequest;
 
 use rocket_contrib::{Json, Value};
@@ -6,7 +5,6 @@ use rocket_contrib::{Json, Value};
 use data_encoding::BASE32;
 
 use db::DbConn;
-use db::models::*;
 
 use util;
 use crypto;