From c8945b8091edab0f05fdb2f9801044e10a5e7614 Mon Sep 17 00:00:00 2001 From: Puyodead1 <14828766+Puyodead1@users.noreply.github.com> Date: Mon, 2 Aug 2021 20:53:07 -0400 Subject: [PATCH] Update README + added note about bearer token from env being deprecated + updated example commands to reflect code changes --- README.md | 12 +++++++++--- main.py | 2 +- 2 files changed, 10 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index e04d49b..164c908 100644 --- a/README.md +++ b/README.md @@ -90,13 +90,19 @@ optional arguments: --download-assets If specified, lecture assets will be downloaded --download-captions If specified, captions will be downloaded --keep-vtt If specified, .vtt files won't be removed - --skip-hls If specified, hls streams will be skipped (faster fetching) (hls streams usually contain 1080p - quality for non-drm lectures) + --skip-hls If specified, HLS streams will be skipped (faster fetching, HLS streams usually contain 1080p + quality for non-DRM lectures) --use_mkv If specified, MKV container will be used instead of MP4, subtitles will be muxed (if subtitles are requested) --info If specified, only course information will be printed, nothing will be downloaded ``` +
+ +### NOTE: Loading bearer token from a .env file or system environment is deprecated and may break in the future, pass the token as a command argument instead! + +## Command Examples: + - Passing a Bearer Token and Course ID as an argument - `python main.py -c -b ` - `python main.py -c https://www.udemy.com/courses/myawesomecourse -b ` @@ -125,7 +131,7 @@ optional arguments: - Print course information only: - `python main.py -c --info` - Specify max number of concurrent downloads: - - `python main.py -c --concurrent-downloads 20` + - `python main.py -c --concurrent-connections 20` - `python main.py -c -cd 20` # Credits diff --git a/main.py b/main.py index 645cbf6..1e7fee6 100644 --- a/main.py +++ b/main.py @@ -1356,7 +1356,7 @@ if __name__ == "__main__": "--skip-hls", dest="skip_hls", action="store_true", - help="If specified, hls streams will be skipped (faster fetching) (hls streams usually contain 1080p quality for non-drm lectures)", + help="If specified, HLS streams will be skipped (faster fetching, HLS streams usually contain 1080p quality for non-DRM lectures)", ) parser.add_argument( "--use_mkv",