Working downloads for DashManifestRaw sources with RequestExecutors

app/src/main/java/com/futo/platformplayer/UISlideOverlays.kt

@@ -15,14 +15,18 @@ import com.futo.platformplayer.api.media.models.channels.IPlatformChannel
 import com.futo.platformplayer.api.media.models.streams.VideoUnMuxedSourceDescriptor
 import com.futo.platformplayer.api.media.models.streams.sources.HLSVariantAudioUrlSource
 import com.futo.platformplayer.api.media.models.streams.sources.HLSVariantVideoUrlSource
+import com.futo.platformplayer.api.media.models.streams.sources.IAudioSource
 import com.futo.platformplayer.api.media.models.streams.sources.IAudioUrlSource
 import com.futo.platformplayer.api.media.models.streams.sources.IHLSManifestAudioSource
 import com.futo.platformplayer.api.media.models.streams.sources.IHLSManifestSource
+import com.futo.platformplayer.api.media.models.streams.sources.IVideoSource
 import com.futo.platformplayer.api.media.models.streams.sources.IVideoUrlSource
 import com.futo.platformplayer.api.media.models.subtitles.ISubtitleSource
 import com.futo.platformplayer.api.media.models.video.IPlatformVideo
 import com.futo.platformplayer.api.media.models.video.IPlatformVideoDetails
 import com.futo.platformplayer.api.media.models.video.SerializedPlatformVideo
+import com.futo.platformplayer.api.media.platforms.js.models.sources.JSDashManifestRawAudioSource
+import com.futo.platformplayer.api.media.platforms.js.models.sources.JSDashManifestRawSource
 import com.futo.platformplayer.downloads.VideoLocal
 import com.futo.platformplayer.fragment.mainactivity.main.SubscriptionGroupFragment
 import com.futo.platformplayer.helpers.VideoHelper
@@ -392,8 +396,8 @@ class UISlideOverlays {
 
 
             val requiresAudio = descriptor is VideoUnMuxedSourceDescriptor;
-            var selectedVideo: IVideoUrlSource? = null;
+            var selectedVideo: IVideoSource? = null;
-            var selectedAudio: IAudioUrlSource? = null;
+            var selectedAudio: IAudioSource? = null;
             var selectedSubtitle: ISubtitleSource? = null;
 
             val videoSources = descriptor.videoSources;
@@ -450,6 +454,26 @@ class UISlideOverlays {
                             )
                         }
 
+                        is JSDashManifestRawSource -> {
+                            val estSize = VideoHelper.estimateSourceSize(it);
+                            val prefix = if(estSize > 0) "±" + estSize.toHumanBytesSize() + " " else "";
+                            SlideUpMenuItem(
+                                container.context,
+                                R.drawable.ic_movie,
+                                it.name,
+                                "${it.width}x${it.height}",
+                                (prefix + it.codec).trim(),
+                                tag = it,
+                                call = {
+                                    selectedVideo = it
+                                    menu?.selectOption(videoSources, it);
+                                    if(selectedAudio != null || !requiresAudio)
+                                        menu?.setOk(container.context.getString(R.string.download));
+                                },
+                                invokeParent = false
+                            )
+                        }
+
                         is IHLSManifestSource -> {
                             SlideUpMenuItem(
                                 container.context,
@@ -465,19 +489,20 @@ class UISlideOverlays {
                         }
 
                         else -> {
-                            throw Exception("Unhandled source type")
+                            Logger.w(TAG, "Unhandled source type for UISlideOverlay download items");
+                            null;//throw Exception("Unhandled source type")
                         }
                     }
-                }).flatten().toList()
+                }.filterNotNull()).flatten().toList()
             ));
 
             if(Settings.instance.downloads.getDefaultVideoQualityPixels() > 0 && videoSources.isNotEmpty()) {
                 //TODO: Add HLS support here
                 selectedVideo = VideoHelper.selectBestVideoSource(
-                    videoSources.filter { it is IVideoUrlSource && it.isDownloadable() }.asIterable(),
+                    videoSources.filter { it is IVideoSource && it.isDownloadable() }.asIterable(),
                     Settings.instance.downloads.getDefaultVideoQualityPixels(),
                     FutoVideoPlayerBase.PREFERED_VIDEO_CONTAINERS
-                ) as IVideoUrlSource?;
+                ) as IVideoSource?;
             }
 
             if (audioSources != null) {
@@ -504,6 +529,25 @@ class UISlideOverlays {
                                 );
                             }
 
+                            is JSDashManifestRawAudioSource -> {
+                                val estSize = VideoHelper.estimateSourceSize(it);
+                                val prefix = if(estSize > 0) "±" + estSize.toHumanBytesSize() + " " else "";
+                                SlideUpMenuItem(
+                                    container.context,
+                                    R.drawable.ic_music,
+                                    it.name,
+                                    "${it.bitrate}",
+                                    (prefix + it.codec).trim(),
+                                    tag = it,
+                                    call = {
+                                        selectedAudio = it
+                                        menu?.selectOption(audioSources, it);
+                                        menu?.setOk(container.context.getString(R.string.download));
+                                    },
+                                    invokeParent = false
+                                );
+                            }
+
                             is IHLSManifestAudioSource -> {
                                 SlideUpMenuItem(
                                     container.context,
@@ -519,16 +563,17 @@ class UISlideOverlays {
                             }
 
                             else -> {
-                                throw Exception("Unhandled source type")
+                                Logger.w(TAG, "Unhandled source type for UISlideOverlay download items");
+                                null;//throw Exception("Unhandled source type")
                             }
                         }
-                    }));
+                    }.filterNotNull()));
 
                 //TODO: Add HLS support here
-                selectedAudio = VideoHelper.selectBestAudioSource(audioSources.filter { it is IAudioUrlSource && it.isDownloadable() }.asIterable(),
+                selectedAudio = VideoHelper.selectBestAudioSource(audioSources.filter { it is IAudioSource && it.isDownloadable() }.asIterable(),
                     FutoVideoPlayerBase.PREFERED_AUDIO_CONTAINERS,
                     Settings.instance.playback.getPrimaryLanguage(container.context),
-                    if(Settings.instance.downloads.isHighBitrateDefault()) 9999999 else 1) as IAudioUrlSource?;
+                    if(Settings.instance.downloads.isHighBitrateDefault()) 9999999 else 1) as IAudioSource?;
             }
 
             if(contentResolver != null && subtitleSources.isNotEmpty()) {
@@ -623,8 +668,9 @@ class UISlideOverlays {
                             }
                         }
                         catch(ex: Throwable) {
+                            Logger.e(TAG, "Fetching details for download failed due to: " + ex.message, ex);
                             withContext(Dispatchers.Main) {
-                                UIDialogs.toast(container.context.getString(R.string.failed_to_fetch_details_for_download));
+                                UIDialogs.toast(container.context.getString(R.string.failed_to_fetch_details_for_download) + "\n" + ex.message);
                                 handleUnknownDownload();
                                 loader.hide(true);
                             }

app/src/main/java/com/futo/platformplayer/api/media/platforms/js/models/sources/JSDashManifestRawAudioSource.kt

@@ -14,7 +14,7 @@ import com.futo.platformplayer.getOrThrow
 import com.futo.platformplayer.others.Language
 import com.futo.platformplayer.states.StateDeveloper
 
-class JSDashManifestRawAudioSource : JSSource, IAudioSource {
+class JSDashManifestRawAudioSource : JSSource, IAudioSource, IJSDashManifestRawSource {
     override val container : String = "application/dash+xml";
     override val name : String;
     override val codec: String;
@@ -25,9 +25,9 @@ class JSDashManifestRawAudioSource : JSSource, IAudioSource {
     override val language: String;
 
     val url: String;
-    var manifest: String?;
+    override var manifest: String?;
 
-    val hasGenerate: Boolean;
+    override val hasGenerate: Boolean;
 
     constructor(plugin: JSClient, obj: V8ValueObject) : super(TYPE_DASH_RAW, plugin, obj) {
         val contextName = "DashRawSource";
@@ -43,7 +43,7 @@ class JSDashManifestRawAudioSource : JSSource, IAudioSource {
         hasGenerate = _obj.has("generate");
     }
 
-    fun generate(): String? {
+    override fun generate(): String? {
         if(!hasGenerate)
             return manifest;
         if(_obj.isClosed)

app/src/main/java/com/futo/platformplayer/api/media/platforms/js/models/sources/JSDashManifestRawSource.kt

@@ -15,7 +15,12 @@ import com.futo.platformplayer.getOrNull
 import com.futo.platformplayer.getOrThrow
 import com.futo.platformplayer.states.StateDeveloper
 
-open class JSDashManifestRawSource: JSSource, IVideoSource {
+interface IJSDashManifestRawSource {
+    val hasGenerate: Boolean;
+    var manifest: String?;
+    fun generate(): String?;
+}
+open class JSDashManifestRawSource: JSSource, IVideoSource, IJSDashManifestRawSource {
     override val container : String = "application/dash+xml";
     override val name : String;
     override val width: Int;
@@ -26,9 +31,9 @@ open class JSDashManifestRawSource: JSSource, IVideoSource {
     override val priority: Boolean;
 
     var url: String?;
-    var manifest: String?;
+    override var manifest: String?;
 
-    val hasGenerate: Boolean;
+    override val hasGenerate: Boolean;
     val canMerge: Boolean;
 
     constructor(plugin: JSClient, obj: V8ValueObject) : super(TYPE_DASH_RAW, plugin, obj) {
@@ -47,7 +52,7 @@ open class JSDashManifestRawSource: JSSource, IVideoSource {
         hasGenerate = _obj.has("generate");
     }
 
-    open fun generate(): String? {
+    override open fun generate(): String? {
         if(!hasGenerate)
             return manifest;
         if(_obj.isClosed)

app/src/main/java/com/futo/platformplayer/downloads/VideoDownload.kt

@@ -12,6 +12,7 @@ import com.futo.platformplayer.api.media.models.streams.VideoUnMuxedSourceDescri
 import com.futo.platformplayer.api.media.models.streams.sources.AudioUrlSource
 import com.futo.platformplayer.api.media.models.streams.sources.IAudioSource
 import com.futo.platformplayer.api.media.models.streams.sources.IAudioUrlSource
+import com.futo.platformplayer.api.media.models.streams.sources.IDashManifestSource
 import com.futo.platformplayer.api.media.models.streams.sources.IHLSManifestSource
 import com.futo.platformplayer.api.media.models.streams.sources.IVideoSource
 import com.futo.platformplayer.api.media.models.streams.sources.IVideoUrlSource
@@ -25,6 +26,12 @@ import com.futo.platformplayer.api.media.models.video.IPlatformVideo
 import com.futo.platformplayer.api.media.models.video.IPlatformVideoDetails
 import com.futo.platformplayer.api.media.models.video.SerializedPlatformVideo
 import com.futo.platformplayer.api.media.models.video.SerializedPlatformVideoDetails
+import com.futo.platformplayer.api.media.platforms.js.models.JSRequestExecutor
+import com.futo.platformplayer.api.media.platforms.js.models.JSVideo
+import com.futo.platformplayer.api.media.platforms.js.models.sources.IJSDashManifestRawSource
+import com.futo.platformplayer.api.media.platforms.js.models.sources.JSDashManifestRawAudioSource
+import com.futo.platformplayer.api.media.platforms.js.models.sources.JSDashManifestRawSource
+import com.futo.platformplayer.api.media.platforms.js.models.sources.JSSource
 import com.futo.platformplayer.constructs.Event1
 import com.futo.platformplayer.exceptions.DownloadException
 import com.futo.platformplayer.helpers.FileHelper.Companion.sanitizeFileName
@@ -46,6 +53,8 @@ import kotlinx.coroutines.awaitAll
 import kotlinx.coroutines.coroutineScope
 import kotlinx.coroutines.suspendCancellableCoroutine
 import kotlinx.coroutines.withContext
+import kotlinx.serialization.Contextual
+import kotlinx.serialization.Transient
 import java.io.File
 import java.io.FileOutputStream
 import java.io.IOException
@@ -56,6 +65,7 @@ import java.util.concurrent.ForkJoinPool
 import java.util.concurrent.ForkJoinTask
 import java.util.concurrent.ThreadLocalRandom
 import kotlin.coroutines.resumeWithException
+import kotlin.time.times
 
 @kotlinx.serialization.Serializable
 class VideoDownload {
@@ -71,12 +81,38 @@ class VideoDownload {
 
     var targetPixelCount: Long? = null;
     var targetBitrate: Long? = null;
+    var targetVideoName: String? = null;
+    var targetAudioName: String? = null;
+
     var videoSource: VideoUrlSource?;
     var audioSource: AudioUrlSource?;
+    @Contextual
+    @Transient
+    val videoSourceToUse: IVideoSource? get () = if(requiresLiveVideoSource) videoSourceLive as IVideoSource? else videoSource as IVideoSource?;
+    @Contextual
+    @Transient
+    val audioSourceToUse: IAudioSource? get () = if(requiresLiveAudioSource) audioSourceLive as IAudioSource? else audioSource as IAudioSource?;
+
+
     var subtitleSource: SubtitleRawSource?;
     @kotlinx.serialization.Serializable(with = OffsetDateTimeNullableSerializer::class)
     var prepareTime: OffsetDateTime? = null;
 
+    var requiresLiveVideoSource: Boolean = false;
+    @Contextual
+    @kotlinx.serialization.Transient
+    var videoSourceLive: JSSource? = null;
+    val isLiveVideoSourceValid get() = videoSourceLive?.getUnderlyingObject()?.isClosed?.let { !it } ?: false;
+
+    var requiresLiveAudioSource: Boolean = false;
+    @Contextual
+    @kotlinx.serialization.Transient
+    var audioSourceLive: JSSource? = null;
+    val isLiveAudioSourceValid get() = audioSourceLive?.getUnderlyingObject()?.isClosed?.let { !it } ?: false;
+
+    var hasVideoRequestExecutor: Boolean = false;
+    var hasAudioRequestExecutor: Boolean = false;
+
     var progress: Double = 0.0;
     var isCancelled = false;
 
@@ -118,14 +154,27 @@ class VideoDownload {
         this.subtitleSource = null;
         this.targetPixelCount = targetPixelCount;
         this.targetBitrate = targetBitrate;
+        this.hasVideoRequestExecutor = video is JSSource && video.hasRequestExecutor;
+        this.requiresLiveVideoSource = false;
+        this.targetVideoName = videoSource?.name;
     }
-    constructor(video: IPlatformVideoDetails, videoSource: IVideoUrlSource?, audioSource: IAudioUrlSource?, subtitleSource: SubtitleRawSource?) {
+    constructor(video: IPlatformVideoDetails, videoSource: IVideoSource?, audioSource: IAudioSource?, subtitleSource: SubtitleRawSource?) {
         this.video = SerializedPlatformVideo.fromVideo(video);
         this.videoDetails = SerializedPlatformVideoDetails.fromVideo(video, if (subtitleSource != null) listOf(subtitleSource) else listOf());
-        this.videoSource = VideoUrlSource.fromUrlSource(videoSource);
+        this.videoSource = if(videoSource is IVideoUrlSource) VideoUrlSource.fromUrlSource(videoSource) else null;
-        this.audioSource = AudioUrlSource.fromUrlSource(audioSource);
+        this.audioSource = if(audioSource is IAudioUrlSource) AudioUrlSource.fromUrlSource(audioSource) else null;
+        this.videoSourceLive = if(videoSource is JSSource) videoSource else null;
+        this.audioSourceLive = if(audioSource is JSSource) audioSource else null;
         this.subtitleSource = subtitleSource;
         this.prepareTime = OffsetDateTime.now();
+        this.hasVideoRequestExecutor = videoSource is JSSource && videoSource.hasRequestExecutor;
+        this.hasAudioRequestExecutor = audioSource is JSSource && audioSource.hasRequestExecutor;
+        this.requiresLiveVideoSource = this.hasVideoRequestExecutor || (videoSource is JSDashManifestRawSource && videoSource.hasGenerate);
+        this.requiresLiveAudioSource = this.hasAudioRequestExecutor || (audioSource is JSDashManifestRawAudioSource && audioSource.hasGenerate);
+        this.targetVideoName = videoSource?.name;
+        this.targetAudioName = audioSource?.name;
+        this.targetPixelCount = if(videoSource != null) (videoSource.width * videoSource.height).toLong() else null;
+        this.targetBitrate = if(audioSource != null) audioSource.bitrate.toLong() else null;
     }
 
     fun withGroup(groupType: String, groupID: String): VideoDownload {
@@ -156,9 +205,21 @@ class VideoDownload {
 
     suspend fun prepare(client: ManagedHttpClient) {
         Logger.i(TAG, "VideoDownload Prepare [${name}]");
+
+        //If live sources are required, ensure a live object is present
+        if(requiresLiveVideoSource && !isLiveVideoSourceValid) {
+            videoDetails = null;
+            videoSource = null;
+            videoSourceLive = null;
+        }
+        if(requiresLiveAudioSource && !isLiveAudioSourceValid) {
+            videoDetails = null;
+            audioSource = null;
+            videoSourceLive = null;
+        }
         if(video == null && videoDetails == null)
             throw IllegalStateException("Missing information for download to complete");
-        if(targetPixelCount == null && targetBitrate == null && videoSource == null && audioSource == null)
+        if(targetPixelCount == null && targetBitrate == null && videoSource == null && audioSource == null && targetVideoName == null && targetAudioName == null)
             throw IllegalStateException("No sources or query values set");
 
         //Fetch full video object and determine source
@@ -192,19 +253,28 @@ class VideoDownload {
                         videoSources.add(source)
                     }
                 }
+                var vsource: IVideoSource? = null;
 
-                val vsource = VideoHelper.selectBestVideoSource(videoSources, targetPixelCount!!.toInt(), arrayOf())
+                if(targetVideoName != null)
+                    vsource = videoSources.find { x -> x.isDownloadable() && x.name == targetVideoName };
+                if(vsource == null && targetPixelCount == null)
+                    throw IllegalStateException("Could not find comparable downloadable video stream (No target pixel count)");
+                if(vsource == null)
+                    vsource = VideoHelper.selectBestVideoSource(videoSources, targetPixelCount!!.toInt(), arrayOf())
                 //    ?: throw IllegalStateException("Could not find a valid video source for video");
-                if(vsource != null) {
+
-                    if (vsource is IVideoUrlSource)
+                if(vsource == null)
-                        videoSource = VideoUrlSource.fromUrlSource(vsource)
+                    videoSource = null;
-                    else
+                else if(vsource is IVideoUrlSource)
-                        throw DownloadException("Video source is not supported for downloading (yet)", false);
+                    videoSource = VideoUrlSource.fromUrlSource(vsource)
-                }
+                else if(vsource is JSSource && requiresLiveVideoSource)
+                    videoSourceLive = vsource;
+                else
+                    throw DownloadException("Video source is not supported for downloading (yet)", false);
             }
 
             if(audioSource == null && targetBitrate != null) {
-                val audioSources = arrayListOf<IAudioSource>()
+                var audioSources = mutableListOf<IAudioSource>()
                 val video = original.video
                 if (video is VideoUnMuxedSourceDescriptor) {
                     for (source in video.audioSources) {
@@ -226,25 +296,38 @@ class VideoDownload {
                     }
                 }
 
-                val asource = VideoHelper.selectBestAudioSource(audioSources, arrayOf(), null, targetBitrate)
+                var asource: IAudioSource? = null;
-                    ?: if(videoSource != null ) null
+                if(targetAudioName != null) {
-                    else throw DownloadException("Could not find a valid video or audio source for download")
+                    val filteredAudioSources = audioSources.filter { x -> x.isDownloadable() && x.name == targetAudioName }.toTypedArray();
+                    if(filteredAudioSources.size == 1)
+                        asource = filteredAudioSources.first();
+                    else if(filteredAudioSources.size > 1)
+                        audioSources = filteredAudioSources.toMutableList();
+                }
+                if(asource == null && targetBitrate == null)
+                    throw IllegalStateException("Could not find comparable downloadable video stream (No target bitrate)");
+                if(asource == null)
+                    asource = VideoHelper.selectBestAudioSource(audioSources, arrayOf(), null, targetBitrate)
+                        ?: if(videoSource != null ) null
+                        else throw DownloadException("Could not find a valid video or audio source for download")
                 if(asource == null)
                     audioSource = null;
                 else if(asource is IAudioUrlSource)
                     audioSource = AudioUrlSource.fromUrlSource(asource)
+                else if(asource is JSSource && requiresLiveAudioSource)
+                    audioSourceLive = asource;
                 else
                     throw DownloadException("Audio source is not supported for downloading (yet)", false);
             }
 
-            if(videoSource == null && audioSource == null)
+            if(((!requiresLiveVideoSource && videoSource == null) || (requiresLiveVideoSource && !isLiveVideoSourceValid)) || ((!requiresLiveAudioSource && audioSource == null) || (requiresLiveAudioSource && !isLiveAudioSourceValid)))
                 throw DownloadException("No valid sources found for video/audio");
         }
     }
 
     suspend fun download(context: Context, client: ManagedHttpClient, onProgress: ((Double) -> Unit)? = null) = coroutineScope {
         Logger.i(TAG, "VideoDownload Download [${name}]");
-        if(videoDetails == null || (videoSource == null && audioSource == null))
+        if(videoDetails == null || (videoSourceToUse == null && audioSourceToUse == null))
             throw IllegalStateException("Missing information for download to complete");
         val downloadDir = StateDownloads.instance.getDownloadsDirectory();
 
@@ -253,12 +336,19 @@ class VideoDownload {
 
         if(isCancelled) throw CancellationException("Download got cancelled");
 
-        if(videoSource != null) {
+        val actualVideoSource = if(requiresLiveVideoSource && videoSourceLive is IVideoSource)
-            videoFileName = "${videoDetails!!.id.value!!} [${videoSource!!.width}x${videoSource!!.height}].${videoContainerToExtension(videoSource!!.container)}".sanitizeFileName();
+            videoSourceLive as IVideoSource?;
+        else videoSource;
+        val actualAudioSource = if(requiresLiveAudioSource && audioSourceLive is IAudioSource)
+            audioSourceLive as IAudioSource?;
+        else audioSource;
+
+        if(actualVideoSource != null) {
+            videoFileName = "${videoDetails!!.id.value!!} [${actualVideoSource!!.width}x${actualVideoSource!!.height}].${videoContainerToExtension(actualVideoSource!!.container)}".sanitizeFileName();
             videoFilePath = File(downloadDir, videoFileName!!).absolutePath;
         }
-        if(audioSource != null) {
+        if(actualAudioSource != null) {
-            audioFileName = "${videoDetails!!.id.value!!} [${audioSource!!.language}-${audioSource!!.bitrate}].${audioContainerToExtension(audioSource!!.container)}".sanitizeFileName();
+            audioFileName = "${videoDetails!!.id.value!!} [${actualAudioSource!!.language}-${actualAudioSource!!.bitrate}].${audioContainerToExtension(actualAudioSource!!.container)}".sanitizeFileName();
             audioFilePath = File(downloadDir, audioFileName!!).absolutePath;
         }
         if(subtitleSource != null) {
@@ -273,7 +363,7 @@ class VideoDownload {
         var lastAudioLength: Long = 0;
         var lastAudioRead: Long = 0;
 
-        if(videoSource != null) {
+        if(actualVideoSource != null) {
             sourcesToDownload.add(async {
                 Logger.i(TAG, "Started downloading video");
 
@@ -296,13 +386,18 @@ class VideoDownload {
                     }
                 }
 
-                videoFileSize = when (videoSource!!.container) {
+                if(actualVideoSource is IVideoUrlSource)
-                    "application/vnd.apple.mpegurl" -> downloadHlsSource(context, "Video", client, videoSource!!.getVideoUrl(), File(downloadDir, videoFileName!!), progressCallback)
+                    videoFileSize = when (videoSource!!.container) {
-                    else -> downloadFileSource("Video", client, videoSource!!.getVideoUrl(), File(downloadDir, videoFileName!!), progressCallback)
+                        "application/vnd.apple.mpegurl" -> downloadHlsSource(context, "Video", client, videoSource!!.getVideoUrl(), File(downloadDir, videoFileName!!), progressCallback)
+                        else -> downloadFileSource("Video", client, videoSource!!.getVideoUrl(), File(downloadDir, videoFileName!!), progressCallback)
+                    }
+                else if(actualVideoSource is JSDashManifestRawSource) {
+                    videoFileSize = downloadDashFileSource("Video", client, actualVideoSource, File(downloadDir, videoFileName!!), progressCallback);
                 }
+                else throw NotImplementedError("NotImplemented video download: " + actualVideoSource.javaClass.name);
             });
         }
-        if(audioSource != null) {
+        if(actualAudioSource != null) {
             sourcesToDownload.add(async {
                 Logger.i(TAG, "Started downloading audio");
 
@@ -325,10 +420,15 @@ class VideoDownload {
                     }
                 }
 
-                audioFileSize = when (audioSource!!.container) {
+                if(actualAudioSource is IAudioUrlSource)
-                    "application/vnd.apple.mpegurl" -> downloadHlsSource(context, "Audio", client, audioSource!!.getAudioUrl(), File(downloadDir, audioFileName!!), progressCallback)
+                    audioFileSize = when (audioSource!!.container) {
-                    else -> downloadFileSource("Audio", client, audioSource!!.getAudioUrl(), File(downloadDir, audioFileName!!), progressCallback)
+                        "application/vnd.apple.mpegurl" -> downloadHlsSource(context, "Audio", client, audioSource!!.getAudioUrl(), File(downloadDir, audioFileName!!), progressCallback)
+                        else -> downloadFileSource("Audio", client, audioSource!!.getAudioUrl(), File(downloadDir, audioFileName!!), progressCallback)
+                    }
+                else if(actualAudioSource is JSDashManifestRawAudioSource) {
+                    audioFileSize = downloadDashFileSource("Audio", client, actualAudioSource, File(downloadDir, audioFileName!!), progressCallback);
                 }
+                else throw NotImplementedError("NotImplemented audio download: " + actualAudioSource.javaClass.name);
             });
         }
         if (subtitleSource != null) {
@@ -473,6 +573,86 @@ class VideoDownload {
         }
     }
 
+    private fun downloadDashFileSource(name: String, client: ManagedHttpClient, source: IJSDashManifestRawSource, targetFile: File, onProgress: (Long, Long, Long) -> Unit): Long {
+        if(targetFile.exists())
+            targetFile.delete();
+
+        targetFile.createNewFile();
+
+        val sourceLength: Long?;
+        val fileStream = FileOutputStream(targetFile);
+
+        try{
+            var manifest = source.manifest;
+            if(source.hasGenerate)
+                manifest = source.generate();
+            if(manifest == null)
+                throw IllegalStateException("No manifest after generation");
+
+            //TODO: Temporary naive assume single-sourced dash
+            val foundTemplate = REGEX_DASH_TEMPLATE.find(manifest);
+            if(foundTemplate == null || foundTemplate.groupValues.size != 3)
+                throw IllegalStateException("No SegmentTemplate found in manifest (unsupported dash?)");
+            val foundTemplateUrl = foundTemplate.groupValues[1];
+            val foundCues = REGEX_DASH_CUE.findAll(foundTemplate.groupValues[2]);
+            if(foundCues.count() <= 0)
+                throw IllegalStateException("No Cues found in manifest (unsupported dash?)");
+
+            val executor = if(source is JSSource && source.hasRequestExecutor)
+                source.getRequestExecutor();
+            else
+                null;
+            val speedTracker = SpeedTracker(1000);
+
+            Logger.i(TAG, "Download $name Dash, CueCount: " + foundCues.count().toString());
+
+            var written = 0;
+            var indexCounter = 0;
+            onProgress(foundCues.count().toLong(), 0, 0);
+            for(cue in foundCues) {
+                val t = cue.groupValues[1];
+                val d = cue.groupValues[2];
+
+                val url = foundTemplateUrl.replace("\$Number\$", indexCounter.toString());
+
+                val data = if(executor != null)
+                    executor.executeRequest(url, mapOf());
+                else {
+                    val resp = client.get(url, mutableMapOf());
+                    if(!resp.isOk)
+                        throw IllegalStateException("Dash request failed for index " + indexCounter.toString() + ", with code: " + resp.code.toString());
+                    resp.body!!.bytes()
+                }
+                fileStream.write(data, 0, data.size);
+                speedTracker.addWork(data.size.toLong());
+                written += data.size;
+
+                onProgress(foundCues.count().toLong(), indexCounter.toLong(), speedTracker.lastSpeed);
+
+                indexCounter++;
+            }
+            sourceLength = written.toLong();
+
+            Logger.i(TAG, "$name downloadSource Finished");
+        }
+        catch(ioex: IOException) {
+            if(targetFile.exists() ?: false)
+                targetFile.delete();
+            if(ioex.message?.contains("ENOSPC") ?: false)
+                throw Exception("Not enough space on device", ioex);
+            else
+                throw ioex;
+        }
+        catch(ex: Throwable) {
+            if(targetFile.exists() ?: false)
+                targetFile.delete();
+            throw ex;
+        }
+        finally {
+            fileStream.close();
+        }
+        return sourceLength!!;
+    }
     private fun downloadFileSource(name: String, client: ManagedHttpClient, videoUrl: String, targetFile: File, onProgress: (Long, Long, Long) -> Unit): Long {
         if(targetFile.exists())
             targetFile.delete();
@@ -659,7 +839,7 @@ class VideoDownload {
 
     fun validate() {
         Logger.i(TAG, "VideoDownload Validate [${name}]");
-        if(videoSource != null) {
+        if(videoSourceToUse != null) {
             if(videoFilePath == null)
                 throw IllegalStateException("Missing video file name after download");
             val expectedFile = File(videoFilePath!!);
@@ -670,7 +850,7 @@ class VideoDownload {
                     throw IllegalStateException("Expected size [${videoFileSize}], but found ${expectedFile.length()}");
             }
         }
-        if(audioSource != null) {
+        if(audioSourceToUse != null) {
             if(audioFilePath == null)
                 throw IllegalStateException("Missing audio file name after download");
             val expectedFile = File(audioFilePath!!);
@@ -692,15 +872,15 @@ class VideoDownload {
     fun complete() {
         Logger.i(TAG, "VideoDownload Complete [${name}]");
         val existing = StateDownloads.instance.getCachedVideo(id);
-        val localVideoSource = videoFilePath?.let { LocalVideoSource.fromSource(videoSource!!, it, videoFileSize ?: 0) };
+        val localVideoSource = videoFilePath?.let { LocalVideoSource.fromSource(videoSourceToUse!!, it, videoFileSize ?: 0) };
-        val localAudioSource = audioFilePath?.let { LocalAudioSource.fromSource(audioSource!!, it, audioFileSize ?: 0) };
+        val localAudioSource = audioFilePath?.let { LocalAudioSource.fromSource(audioSourceToUse!!, it, audioFileSize ?: 0) };
         val localSubtitleSource = subtitleFilePath?.let { LocalSubtitleSource.fromSource(subtitleSource!!, it) };
 
-        if(localVideoSource != null && videoSource != null && videoSource is IStreamMetaDataSource)
+        if(localVideoSource != null && videoSourceToUse != null && videoSourceToUse is IStreamMetaDataSource)
-            localVideoSource.streamMetaData = (videoSource as IStreamMetaDataSource).streamMetaData;
+            localVideoSource.streamMetaData = (videoSourceToUse as IStreamMetaDataSource).streamMetaData;
 
-        if(localAudioSource != null && audioSource != null && audioSource is IStreamMetaDataSource)
+        if(localAudioSource != null && audioSourceToUse != null && audioSourceToUse is IStreamMetaDataSource)
-            localAudioSource.streamMetaData = (audioSource as IStreamMetaDataSource).streamMetaData;
+            localAudioSource.streamMetaData = (audioSourceToUse as IStreamMetaDataSource).streamMetaData;
 
         if(existing != null) {
             existing.videoSerialized = videoDetails!!;
@@ -757,6 +937,9 @@ class VideoDownload {
         const val GROUP_PLAYLIST = "Playlist";
         const val GROUP_WATCHLATER= "WatchLater";
 
+        val REGEX_DASH_TEMPLATE = Regex("<SegmentTemplate .*?media=\"(.*?)\".*?>(.*?)<\\/SegmentTemplate>", RegexOption.DOT_MATCHES_ALL);
+        val REGEX_DASH_CUE = Regex("<S .*?t=\"([0-9]*?)\".*?d=\"([0-9]*?)\".*?\\/>", RegexOption.DOT_MATCHES_ALL);
+
         fun videoContainerToExtension(container: String): String? {
             if (container.contains("video/mp4") || container == "application/vnd.apple.mpegurl")
                 return "mp4";
@@ -803,4 +986,27 @@ class VideoDownload {
                 return "subtitle";
         }
     }
+
+    class SpeedTracker {
+        private val segmentStart: Long;
+        private val intervalMs: Long;
+        private var workDone: Long;
+        var lastSpeed: Long;
+        constructor(intervalMs: Long) {
+            segmentStart = System.currentTimeMillis();
+            this.intervalMs = intervalMs;
+            this.workDone = 0;
+            this.lastSpeed = 0;
+        }
+        fun addWork(work: Long) {
+            val now = System.currentTimeMillis();
+            if((now - segmentStart) > intervalMs)
+            {
+                lastSpeed = workDone;
+                workDone = 0;
+            }
+            workDone += work;
+        }
+
+    }
 }

app/src/main/java/com/futo/platformplayer/helpers/VideoHelper.kt

@@ -20,6 +20,8 @@ import com.futo.platformplayer.api.media.models.streams.sources.IVideoSource
 import com.futo.platformplayer.api.media.models.streams.sources.IVideoUrlSource
 import com.futo.platformplayer.api.media.models.video.IPlatformVideoDetails
 import com.futo.platformplayer.api.media.platforms.js.models.sources.JSAudioUrlRangeSource
+import com.futo.platformplayer.api.media.platforms.js.models.sources.JSDashManifestRawAudioSource
+import com.futo.platformplayer.api.media.platforms.js.models.sources.JSDashManifestRawSource
 import com.futo.platformplayer.api.media.platforms.js.models.sources.JSSource
 import com.futo.platformplayer.api.media.platforms.js.models.sources.JSVideoUrlRangeSource
 import com.futo.platformplayer.logging.Logger
@@ -45,8 +47,8 @@ class VideoHelper {
             return false
         }
 
-        fun isDownloadable(source: IVideoSource) = source is IVideoUrlSource || source is IHLSManifestSource;
+        fun isDownloadable(source: IVideoSource) = source is IVideoUrlSource || source is IHLSManifestSource || source is JSDashManifestRawSource;
-        fun isDownloadable(source: IAudioSource) = (source is IAudioUrlSource || source is IHLSManifestAudioSource) && source !is IAudioUrlWidevineSource
+        fun isDownloadable(source: IAudioSource) = (source is IAudioUrlSource || source is IHLSManifestAudioSource || source is JSDashManifestRawAudioSource) && source !is IAudioUrlWidevineSource
 
         fun selectBestVideoSource(desc: IVideoSourceDescriptor, desiredPixelCount : Int, prefContainers : Array<String>) : IVideoSource? = selectBestVideoSource(desc.videoSources.toList(), desiredPixelCount, prefContainers);
         fun selectBestVideoSource(sources: Iterable<IVideoSource>, desiredPixelCount : Int, prefContainers : Array<String>) : IVideoSource? {

app/src/main/java/com/futo/platformplayer/services/DownloadService.kt

@@ -183,14 +183,21 @@ class DownloadService : Service() {
             Logger.w(TAG, "Video Download [${download.name}] expired, re-preparing");
             download.videoDetails = null;
 
+            if(download.targetVideoName == null && download.videoSource != null)
+                download.targetVideoName = download.videoSource!!.name;
             if(download.targetPixelCount == null && download.videoSource != null)
                 download.targetPixelCount = (download.videoSource!!.width * download.videoSource!!.height).toLong();
             download.videoSource = null;
+
+            if(download.targetAudioName == null && download.audioSource != null)
+                download.targetAudioName = download.audioSource!!.name;
             if(download.targetBitrate == null && download.audioSource != null)
                 download.targetBitrate = download.audioSource!!.bitrate.toLong();
             download.audioSource = null;
         }
-        if(download.videoDetails == null || (download.videoSource == null && download.audioSource == null))
+        if(download.videoDetails == null ||
+            ((download.videoSource == null && download.audioSource == null) &&
+                (download.requiresLiveVideoSource && !download.isLiveVideoSourceValid) && (download.requiresLiveAudioSource && !download.isLiveAudioSourceValid)))
             download.changeState(VideoDownload.State.PREPARING);
         notifyDownload(download);
 

app/src/main/java/com/futo/platformplayer/states/StateDownloads.kt

@@ -8,7 +8,9 @@ import com.futo.platformplayer.Settings
 import com.futo.platformplayer.UIDialogs
 import com.futo.platformplayer.api.http.ManagedHttpClient
 import com.futo.platformplayer.api.media.PlatformID
+import com.futo.platformplayer.api.media.models.streams.sources.IAudioSource
 import com.futo.platformplayer.api.media.models.streams.sources.IAudioUrlSource
+import com.futo.platformplayer.api.media.models.streams.sources.IVideoSource
 import com.futo.platformplayer.api.media.models.streams.sources.IVideoUrlSource
 import com.futo.platformplayer.api.media.models.streams.sources.LocalAudioSource
 import com.futo.platformplayer.api.media.models.streams.sources.LocalSubtitleSource
@@ -334,7 +336,7 @@ class StateDownloads {
     fun download(video: IPlatformVideo, targetPixelcount: Long?, targetBitrate: Long?) {
         download(VideoDownload(video, targetPixelcount, targetBitrate));
     }
-    fun download(video: IPlatformVideoDetails, videoSource: IVideoUrlSource?, audioSource: IAudioUrlSource?, subtitleSource: SubtitleRawSource?) {
+    fun download(video: IPlatformVideoDetails, videoSource: IVideoSource?, audioSource: IAudioSource?, subtitleSource: SubtitleRawSource?) {
         download(VideoDownload(video, videoSource, audioSource, subtitleSource));
     }