Mirrors/cobalt
1
0
Fork 0
mirror of https://github.com/wukko/cobalt.git synced 2025-05-28 20:40:12 +02:00
Code Issues Packages Projects Releases Wiki Activity

web/workers/ffmpeg: error codes, better error handling, remove logs

Browse Source
This commit is contained in:
wukko 2025-05-14 15:37:31 +06:00
parent 8139e77b66
commit 345df13647
No known key found for this signature in database
GPG Key ID: 3E30B3F26C7B4AA2
1 changed files with 49 additions and 32 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

81
web/src/lib/task-manager/workers/ffmpeg.ts
View File

@ -1,17 +1,15 @@
import LibAVWrapper from "$lib/libav"; import LibAVWrapper from "$lib/libav";
import type { FileInfo } from "$lib/types/libav"; import type { FileInfo } from "$lib/types/libav";
const error = (code: string) => {
self.postMessage({
cobaltFFmpegWorker: {
error: `error.${code}`,
}
})
}
const ffmpeg = async (variant: string, files: File[], args: string[], output: FileInfo) => { const ffmpeg = async (variant: string, files: File[], args: string[], output: FileInfo) => {
if (!(files && output && args)) return; if (!(files && output && args)) {
self.postMessage({
cobaltFFmpegWorker: {
error: "queue.ffmpeg.no_args",
}
});
return;
}
const ff = new LibAVWrapper((progress) => { const ff = new LibAVWrapper((progress) => {
self.postMessage({ self.postMessage({
@ -29,23 +27,41 @@ const ffmpeg = async (variant: string, files: File[], args: string[], output: Fi
ff.init({ variant }); ff.init({ variant });
const error = (code: string) => {
self.postMessage({
cobaltFFmpegWorker: {
error: code,
}
});
ff.terminate();
}
try { try {
// probing just the first file in files array (usually audio) for duration progress // probing just the first file in files array (usually audio) for duration progress
const probeFile = files[0]; const probeFile = files[0];
if (!probeFile) return error("couldn't probe one of files"); if (!probeFile) {
return error("queue.ffmpeg.probe_failed");
}
const file_info = await ff.probe(probeFile).catch((e) => { let file_info;
if (e?.message?.toLowerCase().includes("out of memory")) {
console.error("uh oh! out of memory"); try {
file_info = await ff.probe(probeFile);
} catch (e) {
console.error("error from ffmpeg worker @ file_info:");
if (e instanceof Error && e?.message?.toLowerCase().includes("out of memory")) {
console.error(e); console.error(e);
error("remux.out_of_resources"); error("queue.ffmpeg.out_of_memory");
self.close(); return self.close();
} else {
console.error(e);
return error("queue.ffmpeg.probe_failed");
} }
}); }
if (!file_info?.format) { if (!file_info?.format) {
return error("remux.corrupted"); return error("queue.ffmpeg.no_input_format");
} }
self.postMessage({ self.postMessage({
@ -58,27 +74,27 @@ const ffmpeg = async (variant: string, files: File[], args: string[], output: Fi
for (const file of files) { for (const file of files) {
if (!file.type) { if (!file.type) {
// TODO: better & more appropriate error code return error("queue.ffmpeg.no_input_type");
return error("remux.corrupted");
} }
} }
const render = await ff let render;
.render({
try {
render = await ff.render({
files, files,
output, output,
args, args,
})
.catch((e) => {
console.error("uh-oh! render error");
console.error(e);
// TODO: better error codes, there are more reasons for a crash
error("remux.out_of_resources");
}); });
} catch (e) {
console.error("error from the ffmpeg worker @ render:");
console.error(e);
// TODO: more granular error codes
return error("queue.ffmpeg.crashed");
}
if (!render) { if (!render) {
console.log("not a valid file"); return error("queue.ffmpeg.no_render");
return error("incorrect input or output");
} }
await ff.terminate(); await ff.terminate();
@ -89,8 +105,9 @@ const ffmpeg = async (variant: string, files: File[], args: string[], output: Fi
} }
}); });
} catch (e) { } catch (e) {
console.log(e); console.error("error from the ffmpeg worker:")
return error("remux.crashed"); console.error(e);
return error("queue.ffmpeg.crashed");
} }
} }