Avoid injecting script to unrelated sites (#665)

* Avoid injecting script to unrelated sites

* unnecessary comment
This commit is contained in:
Nguyễn Kim Kha 2020-05-26 13:17:35 +10:00 committed by GitHub
parent ad1afe9b63
commit e33f019c1f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -348,13 +348,18 @@ extensionApi.webRequest.onBeforeSendHeaders.addListener(function (details) {
} }
if (tabId !== -1) { if (tabId !== -1) {
// run contentScript inside tab extensionApi.tabs.get(tabId, function (currentTab) {
extensionApi.tabs.executeScript(tabId, { // Validate url of current tab to avoid injecting script to unrelated sites
file: 'src/js/contentScript.js', if (currentTab && isSiteEnabled(currentTab)) {
runAt: 'document_start' // run contentScript inside tab
}, function (res) { extensionApi.tabs.executeScript(tabId, {
if (extensionApi.runtime.lastError || res[0]) { file: 'src/js/contentScript.js',
runAt: 'document_start'
}, function (res) {
if (extensionApi.runtime.lastError || res[0]) {
}
});
} }
}); });
} }