From 818cdb7e79ffcf1e8fd02211a999560eafb09e79 Mon Sep 17 00:00:00 2001
From: Arkadiusz Hiler <ahiler@codeweavers.com>
Date: Tue, 16 May 2023 18:30:46 +0300
Subject: [PATCH] media-converter: Avoid holding state lock.

---
 media-converter/src/videoconv/imp.rs | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/media-converter/src/videoconv/imp.rs b/media-converter/src/videoconv/imp.rs
index 917bae73..2dc0237e 100644
--- a/media-converter/src/videoconv/imp.rs
+++ b/media-converter/src/videoconv/imp.rs
@@ -728,6 +728,7 @@ impl VideoConv {
                 true
             },
             QueryViewMut::Duration(ref mut q) => {
+                if q.format() != gst::Format::Bytes { return false };
 
                 let mut state = self.state.lock().unwrap();
 
@@ -741,10 +742,8 @@ impl VideoConv {
                 }
 
                 if let Some(sz) = state.our_duration {
-                    if q.format() == gst::Format::Bytes {
-                        q.set(gst::format::Bytes::from_u64(sz));
-                        return true
-                    }
+                    q.set(gst::format::Bytes::from_u64(sz));
+                    return true
                 }
 
                 false