Mirrors/PrismLauncher
1
0
Fork 0
mirror of https://github.com/PrismLauncher/PrismLauncher.git synced 2025-05-20 16:27:15 +02:00
Code Issues Packages Projects Releases Wiki Activity

remove infinite loop in writeVarInt()

Browse Source
This commit is contained in:
iTrooz 2024-11-28 17:29:35 +01:00
parent 26f50f9b81
commit 873232ebe3
No known key found for this signature in database
GPG Key ID: 8B83F77667B1BC6A
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
launcher/ui/pages/instance/McClient.cpp
View File

@ -7,6 +7,7 @@
#include "McClient.h" #include "McClient.h"
#include <qtconcurrentrun.h> #include <qtconcurrentrun.h>
// 7 first bits
#define SEGMENT_BITS 0x7F #define SEGMENT_BITS 0x7F
#define CONTINUE_BIT 0x80 #define CONTINUE_BIT 0x80
@ -99,17 +100,15 @@ QJsonObject McClient::readResponse() {
// From https://wiki.vg/Protocol#VarInt_and_VarLong // From https://wiki.vg/Protocol#VarInt_and_VarLong
void McClient::writeVarInt(QByteArray &data, int value) { void McClient::writeVarInt(QByteArray &data, int value) {
while (true) { while ((value & ~SEGMENT_BITS)) { // check if the value is too big to fit in 7 bits
if ((value & ~SEGMENT_BITS) == 0) { // Write 7 bits
data.append(value);
return;
}
data.append((value & SEGMENT_BITS) | CONTINUE_BIT); data.append((value & SEGMENT_BITS) | CONTINUE_BIT);
// Erase theses 7 bits from the value to write
// Note: >>> means that the sign bit is shifted with the rest of the number rather than being left alone // Note: >>> means that the sign bit is shifted with the rest of the number rather than being left alone
value >>= 7; value >>= 7;
} }
data.append(value);
} }
// From https://wiki.vg/Protocol#VarInt_and_VarLong // From https://wiki.vg/Protocol#VarInt_and_VarLong