fix: beginResetModel called before endResetModel (#3657)

This commit is contained in:
Alexandru Ionut Tripon 2025-04-18 18:46:59 +03:00 committed by GitHub
commit 6f38ab3fb0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -295,13 +295,11 @@ void VersionProxyModel::sourceDataChanged(const QModelIndex& source_top_left, co
void VersionProxyModel::setSourceModel(QAbstractItemModel* replacingRaw) void VersionProxyModel::setSourceModel(QAbstractItemModel* replacingRaw)
{ {
auto replacing = dynamic_cast<BaseVersionList*>(replacingRaw); auto replacing = dynamic_cast<BaseVersionList*>(replacingRaw);
beginResetModel();
m_columns.clear(); m_columns.clear();
if (!replacing) { if (!replacing) {
roles.clear(); roles.clear();
filterModel->setSourceModel(replacing); filterModel->setSourceModel(replacing);
endResetModel();
return; return;
} }
@ -343,8 +341,6 @@ void VersionProxyModel::setSourceModel(QAbstractItemModel* replacingRaw)
hasLatest = true; hasLatest = true;
} }
filterModel->setSourceModel(replacing); filterModel->setSourceModel(replacing);
endResetModel();
} }
QModelIndex VersionProxyModel::getRecommended() const QModelIndex VersionProxyModel::getRecommended() const