From 5eb417ff2be159330558999082ecb64e3ee8f003 Mon Sep 17 00:00:00 2001 From: iTrooz Date: Thu, 28 Nov 2024 23:54:51 +0100 Subject: [PATCH] Always autodelete signal connections with `this` captured when the objet is deleted, just to be sure --- launcher/ui/pages/instance/ServerPingTask.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/launcher/ui/pages/instance/ServerPingTask.cpp b/launcher/ui/pages/instance/ServerPingTask.cpp index 42144f354..260405dc0 100644 --- a/launcher/ui/pages/instance/ServerPingTask.cpp +++ b/launcher/ui/pages/instance/ServerPingTask.cpp @@ -9,7 +9,7 @@ void ServerPingTask::executeTask() { // Resolve the actual IP and port for the server McResolver *resolver = new McResolver(nullptr, m_domain, m_port); - QObject::connect(resolver, &McResolver::succeeded, [this, resolver](QString ip, int port) { + QObject::connect(resolver, &McResolver::succeeded, this, [this, resolver](QString ip, int port) { qDebug() << "Resolved Address for" << m_domain << ": " << ip << ":" << port; // Now that we have the IP and port, query the server @@ -18,7 +18,7 @@ void ServerPingTask::executeTask() { // Wait for query to finish QFutureWatcher *watcher = new QFutureWatcher(); - QObject::connect(watcher, &QFutureWatcher::finished, [this, client, onlineFuture, watcher]() { + QObject::connect(watcher, &QFutureWatcher::finished, this, [this, client, onlineFuture, watcher]() { client->deleteLater(); watcher->deleteLater();